diff mbox

[02/13] constify unset_in_environ

Message ID 1406055319-26380-3-git-send-email-tromey@redhat.com
State Committed
Headers

Commit Message

Tom Tromey July 22, 2014, 6:55 p.m. UTC 
  This constifies an argument to unset_in_environ.

2014-07-22  Tom Tromey  <tromey@redhat.com>

	* environ.c (unset_in_environ): Make "var" const.
	* environ.h (unset_in_environ): Update.
---
 gdb/ChangeLog | 5 +++++
 gdb/environ.c | 2 +-
 gdb/environ.h | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

Comments

Pedro Alves July 24, 2014, 1:44 a.m. UTC | #1 
Looks good.

Thanks,
Pedro Alves

On 07/22/2014 07:55 PM, Tom Tromey wrote:
> This constifies an argument to unset_in_environ.
> 
> 2014-07-22  Tom Tromey  <tromey@redhat.com>
> 
> 	* environ.c (unset_in_environ): Make "var" const.
> 	* environ.h (unset_in_environ): Update.
> ---
>  gdb/ChangeLog | 5 +++++
>  gdb/environ.c | 2 +-
>  gdb/environ.h | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/environ.c b/gdb/environ.c
> index 7092a1a..d661a01 100644
> --- a/gdb/environ.c
> +++ b/gdb/environ.c
> @@ -161,7 +161,7 @@ set_in_environ (struct gdb_environ *e, const char *var, const char *value)
>  /* Remove the setting for variable VAR from environment E.  */
>  
>  void
> -unset_in_environ (struct gdb_environ *e, char *var)
> +unset_in_environ (struct gdb_environ *e, const char *var)
>  {
>    int len = strlen (var);
>    char **vector = e->vector;
> diff --git a/gdb/environ.h b/gdb/environ.h
> index 43f6bd4..5c4fac1 100644
> --- a/gdb/environ.h
> +++ b/gdb/environ.h
> @@ -42,7 +42,7 @@ extern char *get_in_environ (const struct gdb_environ *, const char *);
>  
>  extern void set_in_environ (struct gdb_environ *, const char *, const char *);
>  
> -extern void unset_in_environ (struct gdb_environ *, char *);
> +extern void unset_in_environ (struct gdb_environ *, const char *);
>  
>  extern char **environ_vector (struct gdb_environ *);
>  
>
diff mbox

Patch

diff --git a/gdb/environ.c b/gdb/environ.c
index 7092a1a..d661a01 100644
--- a/gdb/environ.c
+++ b/gdb/environ.c
@@ -161,7 +161,7 @@  set_in_environ (struct gdb_environ *e, const char *var, const char *value)
 /* Remove the setting for variable VAR from environment E.  */
 
 void
-unset_in_environ (struct gdb_environ *e, char *var)
+unset_in_environ (struct gdb_environ *e, const char *var)
 {
   int len = strlen (var);
   char **vector = e->vector;
diff --git a/gdb/environ.h b/gdb/environ.h
index 43f6bd4..5c4fac1 100644
--- a/gdb/environ.h
+++ b/gdb/environ.h
@@ -42,7 +42,7 @@  extern char *get_in_environ (const struct gdb_environ *, const char *);
 
 extern void set_in_environ (struct gdb_environ *, const char *, const char *);
 
-extern void unset_in_environ (struct gdb_environ *, char *);
+extern void unset_in_environ (struct gdb_environ *, const char *);
 
 extern char **environ_vector (struct gdb_environ *);