From patchwork Fri Jul 11 02:48:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Bronson X-Patchwork-Id: 2003 Received: (qmail 10735 invoked by alias); 11 Jul 2014 02:49:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 10682 invoked by uid 89); 11 Jul 2014 02:49:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f45.google.com Received: from mail-qg0-f45.google.com (HELO mail-qg0-f45.google.com) (209.85.192.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Jul 2014 02:49:32 +0000 Received: by mail-qg0-f45.google.com with SMTP id f51so419155qge.32 for ; Thu, 10 Jul 2014 19:49:30 -0700 (PDT) X-Received: by 10.140.49.76 with SMTP id p70mr81032607qga.86.1405046970384; Thu, 10 Jul 2014 19:49:30 -0700 (PDT) Received: from hydrogen (naesten-pt.tunnel.tserv4.nyc4.ipv6.he.net. [2001:470:1f06:57::2]) by mx.google.com with ESMTPSA id q4sm1908509qat.15.2014.07.10.19.49.28 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 10 Jul 2014 19:49:29 -0700 (PDT) Received: from naesten by hydrogen with local (Exim 4.82) (envelope-from ) id 1X5Qtr-0008VV-2N; Thu, 10 Jul 2014 22:49:27 -0400 From: Samuel Bronson To: libstdc++@gcc.gnu.org, GCC Patches Cc: Samuel Bronson , Jonathan Wakely , GDB Patches , Tom Tromey Subject: [PATCH v2 1/3] Make libstdc++ testsuite work with pre-color GCC versions again Date: Thu, 10 Jul 2014 22:48:17 -0400 Message-Id: <1405046899-32639-2-git-send-email-naesten@gmail.com> In-Reply-To: <1405046899-32639-1-git-send-email-naesten@gmail.com> References: <1400701554-18062-1-git-send-email-naesten@gmail.com> <1405046899-32639-1-git-send-email-naesten@gmail.com> MIME-Version: 1.0 X-IsSubscribed: yes When I try to build & test just libstdc++, or to run the testsuite from trunk against my installed libstdc++, the testsuite tries to pass "-fdiagnostics-color=never" to the system GCC, which is too old to know what that is. Since I really just want to test a patch for the gdb pretty-printers, and since evidently my machine is too puny to actually build GCC, this is a bit problematic. According to the documentation, setting GCC_COLORS to "" in the environment should be just as effective, while it clearly can't cause older GCCs to freak out, so that's just what I've done. (I've also taken the liberty of swapping the "set ccflags" and "set cxxflags" lines here so that ccflags doesn't end up with two "-DLOCALEDIR" flags.) libstdc++-v3/ * testsuite/lib/libstdc++.exp (libstdc++_init): Set $GCC_COLORS="" instead of insisting that GCC understand -fdiagnostics-color=never Signed-off-by: Samuel Bronson --- libstdc++-v3/testsuite/lib/libstdc++.exp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp index d91bed6..0fdfbdc 100644 --- a/libstdc++-v3/testsuite/lib/libstdc++.exp +++ b/libstdc++-v3/testsuite/lib/libstdc++.exp @@ -289,9 +289,11 @@ proc libstdc++_init { testfile } { v3track cxxflags 2 + # Should be as good as -fdiagnostics-color=never, but more compatible + setenv GCC_COLORS "" # Always use MO files built by this test harness. - set cxxflags "-fdiagnostics-color=never $cxxflags -DLOCALEDIR=\".\"" set ccflags "$cxxflags -DLOCALEDIR=\".\"" + set cxxflags "$cxxflags -DLOCALEDIR=\".\"" # If a PCH file is available, use it. We must delay performing # this check until $cxx and such have been initialized because we