[2/3] constify to_disconnect

Message ID 1402323354-27308-3-git-send-email-tromey@redhat.com
State Committed
Headers

Commit Message

Tom Tromey June 9, 2014, 2:15 p.m. UTC
  This constifies an parameter of to_disconnect and updates
target_disconnect as well.

2014-06-09  Tom Tromey  <tromey@redhat.com>

	* target.h (struct target_ops) <to_disconnect>: Make parameter
	const.
	(target_disconnect): Update.
	* target.c (target_disconnect): Make "args" const.
	* target-delegates.c: Rebuild.
	* remote.c (remote_disconnect): Update.
	* record.h (record_disconnect): Update.
	* record.c (record_disconnect): Update.
	* inf-child.c (inf_child_disconnect): Update.
---
 gdb/ChangeLog          | 12 ++++++++++++
 gdb/inf-child.c        |  2 +-
 gdb/record.c           |  2 +-
 gdb/record.h           |  2 +-
 gdb/remote.c           |  2 +-
 gdb/target-delegates.c |  4 ++--
 gdb/target.c           |  2 +-
 gdb/target.h           |  4 ++--
 8 files changed, 21 insertions(+), 9 deletions(-)
  

Patch

diff --git a/gdb/inf-child.c b/gdb/inf-child.c
index dbadde8..897e635 100644
--- a/gdb/inf-child.c
+++ b/gdb/inf-child.c
@@ -140,7 +140,7 @@  inf_child_open (char *arg, int from_tty)
 /* Implement the to_disconnect target_ops method.  */
 
 static void
-inf_child_disconnect (struct target_ops *target, char *args, int from_tty)
+inf_child_disconnect (struct target_ops *target, const char *args, int from_tty)
 {
   if (args != NULL)
     error (_("Argument given to \"disconnect\"."));
diff --git a/gdb/record.c b/gdb/record.c
index 5a7a88c..b801b7f 100644
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -130,7 +130,7 @@  record_unpush (struct target_ops *t)
 /* See record.h.  */
 
 void
-record_disconnect (struct target_ops *t, char *args, int from_tty)
+record_disconnect (struct target_ops *t, const char *args, int from_tty)
 {
   gdb_assert (t->to_stratum == record_stratum);
 
diff --git a/gdb/record.h b/gdb/record.h
index f5987e3..29784ad 100644
--- a/gdb/record.h
+++ b/gdb/record.h
@@ -57,7 +57,7 @@  extern int record_read_memory (struct gdbarch *gdbarch,
 extern void cmd_record_goto (char *arg, int from_tty);
 
 /* The default "to_disconnect" target method for record targets.  */
-extern void record_disconnect (struct target_ops *, char *, int);
+extern void record_disconnect (struct target_ops *, const char *, int);
 
 /* The default "to_detach" target method for record targets.  */
 extern void record_detach (struct target_ops *, const char *, int);
diff --git a/gdb/remote.c b/gdb/remote.c
index 43e25ae..6174070 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -4347,7 +4347,7 @@  extended_remote_detach (struct target_ops *ops, const char *args, int from_tty)
 /* Same as remote_detach, but don't send the "D" packet; just disconnect.  */
 
 static void
-remote_disconnect (struct target_ops *target, char *args, int from_tty)
+remote_disconnect (struct target_ops *target, const char *args, int from_tty)
 {
   if (args)
     error (_("Argument given to \"disconnect\" when remotely debugging."));
diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index 522d52b..4eefae8 100644
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -28,14 +28,14 @@  tdefault_detach (struct target_ops *self, const char *arg1, int arg2)
 }
 
 static void
-delegate_disconnect (struct target_ops *self, char *arg1, int arg2)
+delegate_disconnect (struct target_ops *self, const char *arg1, int arg2)
 {
   self = self->beneath;
   self->to_disconnect (self, arg1, arg2);
 }
 
 static void
-tdefault_disconnect (struct target_ops *self, char *arg1, int arg2)
+tdefault_disconnect (struct target_ops *self, const char *arg1, int arg2)
 {
   tcomplain ();
 }
diff --git a/gdb/target.c b/gdb/target.c
index a9255d7..f3226b9 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -2087,7 +2087,7 @@  target_detach (const char *args, int from_tty)
 }
 
 void
-target_disconnect (char *args, int from_tty)
+target_disconnect (const char *args, int from_tty)
 {
   /* If we're in breakpoints-always-inserted mode or if breakpoints
      are global across processes, we have to remove them before
diff --git a/gdb/target.h b/gdb/target.h
index 87d2a83..7f9714e 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -414,7 +414,7 @@  struct target_ops
       TARGET_DEFAULT_IGNORE ();
     void (*to_detach) (struct target_ops *ops, const char *, int)
       TARGET_DEFAULT_IGNORE ();
-    void (*to_disconnect) (struct target_ops *, char *, int)
+    void (*to_disconnect) (struct target_ops *, const char *, int)
       TARGET_DEFAULT_NORETURN (tcomplain ());
     void (*to_resume) (struct target_ops *, ptid_t, int, enum gdb_signal)
       TARGET_DEFAULT_NORETURN (noprocess ());
@@ -1177,7 +1177,7 @@  extern void target_detach (const char *, int);
 /* Disconnect from the current target without resuming it (leaving it
    waiting for a debugger).  */
 
-extern void target_disconnect (char *, int);
+extern void target_disconnect (const char *, int);
 
 /* Resume execution of the target process PTID (or a group of
    threads).  STEP says whether to single-step or to run free; SIGGNAL