From patchwork Tue May 27 21:07:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 1174 Received: (qmail 7750 invoked by alias); 27 May 2014 21:07:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7739 invoked by uid 89); 27 May 2014 21:07:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 27 May 2014 21:07:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8A4551161C5 for ; Tue, 27 May 2014 17:07:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Av+OCniX0jmg for ; Tue, 27 May 2014 17:07:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5AE0D1161C3 for ; Tue, 27 May 2014 17:07:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id F1A4D40E27; Tue, 27 May 2014 14:07:25 -0700 (PDT) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [obv] Unnecessary restore of timeout global at end of gdb.base/completion.exp Date: Tue, 27 May 2014 14:07:16 -0700 Message-Id: <1401224836-18195-1-git-send-email-brobecker@adacore.com> Hello, This patch removes some code in gdb.base/compilation.exp which is aimed at restoring the original timeout global value after having changed it for this testcase. Restoring the timeout global is not necessary as this is taken care of by gdb_init, which is called at the start of each testing. gdb/ChangeLog: * gdb.base/completion.exp: Remove code aimed at restoring TIMEOUT. Tested on x86_64-linux. I will push by end of week if there are no objections. Thank you! diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base/completion.exp index 2608309..2a85df5 100644 --- a/gdb/testsuite/gdb.base/completion.exp +++ b/gdb/testsuite/gdb.base/completion.exp @@ -66,7 +66,6 @@ if ![runto_main] then { perror "tests suppressed" } -set oldtimeout1 $timeout set timeout 30 gdb_test_no_output "complete print values\[0\].x." \ @@ -747,7 +746,4 @@ gdb_test_multiple "" "$test" { } } -# Restore globals modified in this test... -set timeout $oldtimeout1 - return 0