[obv] Unnecessary restore of timeout global at end of gdb.base/completion.exp

Message ID 1401224836-18195-1-git-send-email-brobecker@adacore.com
State Committed
Headers

Commit Message

Joel Brobecker May 27, 2014, 9:07 p.m. UTC
  Hello,

This patch removes some code in gdb.base/compilation.exp which
is aimed at restoring the original timeout global value after having
changed it for this testcase. Restoring the timeout global is not
necessary as this is taken care of by gdb_init, which is called
at the start of each testing.

gdb/ChangeLog:

        * gdb.base/completion.exp: Remove code aimed at restoring TIMEOUT.

Tested on x86_64-linux.  I will push by end of week if there are
no objections.

Thank you!
  

Comments

Joel Brobecker June 2, 2014, 3:43 p.m. UTC | #1
> gdb/ChangeLog:
> 
>         * gdb.base/completion.exp: Remove code aimed at restoring TIMEOUT.
> 
> Tested on x86_64-linux.  I will push by end of week if there are
> no objections.

This one is now in...
  

Patch

diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base/completion.exp
index 2608309..2a85df5 100644
--- a/gdb/testsuite/gdb.base/completion.exp
+++ b/gdb/testsuite/gdb.base/completion.exp
@@ -66,7 +66,6 @@  if ![runto_main] then {
         perror "tests suppressed"
 }
 
-set oldtimeout1 $timeout
 set timeout 30
 
 gdb_test_no_output "complete print values\[0\].x." \
@@ -747,7 +746,4 @@  gdb_test_multiple "" "$test" {
     }
 }
 
-# Restore globals modified in this test...
-set timeout $oldtimeout1
-
 return 0