From patchwork Wed May 21 21:22:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 1066 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id BAA8536007B for ; Wed, 21 May 2014 14:23:02 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 7E87A63FC5A2A; Wed, 21 May 2014 14:23:02 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 59F5263FE908B for ; Wed, 21 May 2014 14:23:02 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-type; q=dns; s=default; b=MifO9eXqKaiQZzGt 8sfd4mPLQfOSUmlFulDHyFZyOOmcv2u2BAGMHrOIBJdWfks8o6Gp29PsDqIluheW X94AsbR2YwwtCbG4l79oERI9Ez8fqjzkm+iBGLY3ygZI1e5yRI2ukfuwmbwr9/wG kHoBaZDQs9Zahy5R5qL0fidPtKM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-type; s=default; bh=4K6oKiarrpgLHsnpPr6GOo w0uN0=; b=vb1AeaecrP7Xmo3QLpWIhF7Kp3lN9GBXKaERTIZ/Hzu3AuGxISJPpj NTmJPjfO3W5Pd7UoTjA9/5yJzCsDQ2WefgOZ0//VtDIZNcp47TzRQMY/CKrrVh3S BJ65aWIsaz+/Cp4hiCA4qIczMtaEsqpmTsuMB7zCj90i4heWlGMqk= Received: (qmail 19750 invoked by alias); 21 May 2014 21:23:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19739 invoked by uid 89); 21 May 2014 21:22:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 May 2014 21:22:57 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 81.EF.27529.079CC735; Wed, 21 May 2014 17:42:40 +0200 (CEST) Received: from simark-hp.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.90) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 21 May 2014 17:22:54 -0400 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] Revert "Fix argument passing in mi_run_cmd_full" Date: Wed, 21 May 2014 17:22:48 -0400 Message-ID: <1400707368-8524-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in This reverts commit 8c217a4b684386aa5ce6a078dffbe63265a524e6. Following this https://sourceware.org/ml/gdb-patches/2014-05/msg00462.html I suggest reverting my previous commit. I will follow with another patch to add comments, to clarify some things as stated in the mail thread. I ran make check with on gdb.mi, and the test that the commit broke passes again. gdb/testsuite/ChangeLog: 2014-05-21 Simon Marchi * lib/mi-support.exp (mi_run_cmd_full): Revert to original behavior for $args, pass it directly to "run". --- gdb/testsuite/lib/mi-support.exp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp index afe13e8..6d011b9 100644 --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -818,11 +818,9 @@ proc mi_run_cmd_full {use_mi_command args} { if {$use_mi_command} { set run_prefix "220-exec-" set run_match "220" - set set_args_cmd "-exec-arguments" } else { set run_prefix "" set run_match "" - set set_args_cmd "set args" } if [target_info exists gdb_init_command] { @@ -864,16 +862,7 @@ proc mi_run_cmd_full {use_mi_command args} { return 0 } - send_gdb "${set_args_cmd} $args\n" - gdb_expect { - -re "$mi_gdb_prompt$" { } - default { - perror "settings args failed" - return -1 - } - } - - send_gdb "${run_prefix}run\n" + send_gdb "${run_prefix}run $args\n" gdb_expect { -re "${run_match}\\^running\r\n(\\*running,thread-id=\"\[^\"\]+\"\r\n|=thread-created,id=\"1\",group-id=\"\[0-9\]+\"\r\n)*(${library_loaded_re})*(${thread_selected_re})?${mi_gdb_prompt}" { }