From patchwork Mon May 19 18:56:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 1014 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id 183B636007B for ; Mon, 19 May 2014 11:56:59 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id 98F081958A03; Mon, 19 May 2014 11:56:58 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id DD4DC1958A51 for ; Mon, 19 May 2014 11:56:55 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=Frw4p46ILn4wqJ4g0x4JWZ3Cf5zyCHXq53qTYgxvo3TI3h66neiEB e9vMpixl5D2waN/3hioY/JOS2JOmMizbOIYNjvd17wIeKUrzq9nH1XeKQtffQvbc UUYlGI2k8VDsSXniTU1Fr9RECIy9Lg4pMsaWFzpNAvxet1iry/JMbI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=IziWI+U+wcxXCui8n/Ux+C10/2Y=; b=tjQyA0rjoM2jzoeoS2GkN8ELXvTz 5lsRNOu+fkqLwpsiNs+XAP+x2LJdDJP01PRD0dhSzZnSsF3NrznUVmFmNb4+GG2Y xRQLRzEnMEBT43hWTQWENAJymocUL4Vw8O5TdlJet+Ugf9eHyBVnTlgG4bkDCk9R TDvURNzv8DOMrfg= Received: (qmail 11988 invoked by alias); 19 May 2014 18:56:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11978 invoked by uid 89); 19 May 2014 18:56:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 19 May 2014 18:56:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BE372116185 for ; Mon, 19 May 2014 14:56:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id t7NsGqvO6wkC for ; Mon, 19 May 2014 14:56:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8C3441160EC for ; Mon, 19 May 2014 14:56:50 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B32B343848; Mon, 19 May 2014 11:56:49 -0700 (PDT) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA(7.8)+NEWS] Remove "set/show remotebaud" (deprecated) commands. Date: Mon, 19 May 2014 11:56:48 -0700 Message-Id: <1400525808-20354-1-git-send-email-brobecker@adacore.com> X-DH-Original-To: gdb@patchwork.siddhesh.in Hello, This patch removes support for the "set/show remotebaud" command, which were deprecated in GDB 7.7, and should be now be removed ahead of cutting the GDB 7.8 branch. This should take care of the one item that's on my list pre- branching 7.8. gdb/ChangeLog: * serial.c (_initialize_serial): Remove support for the "set remotebaud" and "show remotebaud" commands. * NEWS: Add entry documenting the removal of that command. gdb/testsuite/ChangeLog: * config/monitor.exp (gdb_target_monitor): Replace use of "set remotebaud" by "set serial baud". Tested on x86_64-linux. The testsuite change was tested by hand by copy/pasting the command and making sure that it works... OK to commit? Thanks, diff --git a/gdb/NEWS b/gdb/NEWS index 00ec8b9..fc5ef45 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -113,6 +113,10 @@ PowerPC64 GNU/Linux little-endian powerpc64le-*-linux* and "assf"), have been deprecated. Use the "sharedlibrary" command, or its alias "share", instead. +* The commands "set remotebaud" and "show remotebaud" are no longer + supported. Use "set serial baud" and "show serial baud" (respectively) + instead. + *** Changes in GDB 7.7 * Improved support for process record-replay and reverse debugging on diff --git a/gdb/serial.c b/gdb/serial.c index 7471a6b..e780bbe 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -671,34 +671,6 @@ using remote targets."), serial_baud_show_cmd, &serial_set_cmdlist, &serial_show_cmdlist); - /* The commands "set/show serial baud" used to have a different name. - Add aliases to those names to facilitate the transition, and mark - them as deprecated, in order to make users aware of the fact that - the command names have been changed. */ - { - const char *cmd_name; - struct cmd_list_element *cmd; - - /* FIXME: There is a limitation in the deprecation mechanism, - and the warning ends up not being displayed for prefixed - aliases. So use a real command instead of an alias. */ - add_setshow_zinteger_cmd ("remotebaud", class_alias, &baud_rate, _("\ -Set baud rate for remote serial I/O."), _("\ -Show baud rate for remote serial I/O."), _("\ -This value is used to set the speed of the serial port when debugging\n\ -using remote targets."), - NULL, - serial_baud_show_cmd, - &setlist, &showlist); - cmd_name = "remotebaud"; - cmd = lookup_cmd (&cmd_name, setlist, "", -1, 1); - deprecate_cmd (cmd, "set serial baud"); - cmd_name - = "remotebaud"; /* needed because lookup_cmd updates the pointer */ - cmd = lookup_cmd (&cmd_name, showlist, "", -1, 1); - deprecate_cmd (cmd, "show serial baud"); - } - add_setshow_filename_cmd ("remotelogfile", no_class, &serial_logfile, _("\ Set filename for remote session recording."), _("\ Show filename for remote session recording."), _("\ diff --git a/gdb/testsuite/config/monitor.exp b/gdb/testsuite/config/monitor.exp index bddcdd5..a85aaee 100644 --- a/gdb/testsuite/config/monitor.exp +++ b/gdb/testsuite/config/monitor.exp @@ -86,7 +86,7 @@ proc gdb_target_monitor { exec_file } { return -1 } if [target_info exists baud] { - gdb_test "set remotebaud [target_info baud]" "" "" + gdb_test "set serial baud [target_info baud]" "" "" } if [target_info exists binarydownload] { gdb_test "set remotebinarydownload [target_info binarydownload]" "" ""