From patchwork Thu Apr 24 20:22:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 671 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A024F360631 for ; Thu, 24 Apr 2014 13:22:09 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14314964) id 4C40641378485; Thu, 24 Apr 2014 13:22:09 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 1EC784135DA02 for ; Thu, 24 Apr 2014 13:22:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=gxiZlcSfkkEq4Q2yon3W+/CWukWC4WxwxOmWuXJUIO0Q5FhwLAr84 BefnsnXx6sF5J4HGfIun3LB5Eyjxc9WKQ00xvDQVcq6aUt2ROhe6gIEnos+2lIe1 /aC5xdVBc0HiX4S4tHptxfaeEObYlSieD4KsBCP6SqrKUZq4qBqKyY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=vfpsqFaRwqvYFhfJGZ4r89ZDBzc=; b=Ig9bKmhlad7IEnUDXJ42ZgUVUH4v HQSYJtkJY0tDVYfKsaH9le1YH/oFK18HzLFXbzOIRDlCMlDRoioCdE3Y4F87ZLG4 g/6k6ANFOsA4KOBGKrAruz3mcvTOJjkUuss/rJ7RDSFJCVaOW7yqzGS0GxSiSdaO j5qK/GeGQIA5TVw= Received: (qmail 4272 invoked by alias); 24 Apr 2014 20:22:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 4259 invoked by uid 89); 24 Apr 2014 20:22:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 24 Apr 2014 20:22:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BBFE31161A9 for ; Thu, 24 Apr 2014 16:22:03 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id D8LWxydx80bc for ; Thu, 24 Apr 2014 16:22:03 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 899601160C9 for ; Thu, 24 Apr 2014 16:22:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E2C45E0B9F; Thu, 24 Apr 2014 13:22:04 -0700 (PDT) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [pushed] ada-lang.c: Expand standard_exc's introductory comment. Date: Thu, 24 Apr 2014 13:22:03 -0700 Message-Id: <1398370923-14071-1-git-send-email-brobecker@adacore.com> X-DH-Original-To: gdb@patchwork.siddhesh.in This patch expands standard_exc's introductory comment to explain why this table does not include Numeric_Error. gdb/ChangeLog: * ada-lang.c (standard_exc): Expand introductory comment. Pushed after rebuilding GDB. --- gdb/ChangeLog | 4 ++++ gdb/ada-lang.c | 14 +++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 06a3681..c0fda0a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-04-24 Joel Brobecker + + * ada-lang.c (standard_exc): Expand introductory comment. + 2014-04-24 Michael Sturm Walfred Tedeschi diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 279c20e..da304ab 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -11294,7 +11294,19 @@ ada_modulus (struct type *type) variants of the runtime, we use a sniffer that will determine the runtime variant used by the program being debugged. */ -/* Ada's standard exceptions. */ +/* Ada's standard exceptions. + + The Ada 83 standard also defined Numeric_Error. But there so many + situations where it was unclear from the Ada 83 Reference Manual + (RM) whether Constraint_Error or Numeric_Error should be raised, + that the ARG (Ada Rapporteur Group) eventually issued a Binding + Interpretation saying that anytime the RM says that Numeric_Error + should be raised, the implementation may raise Constraint_Error. + Ada 95 went one step further and pretty much removed Numeric_Error + from the list of standard exceptions (it made it a renaming of + Constraint_Error, to help preserve compatibility when compiling + an Ada83 compiler). As such, we do not include Numeric_Error from + this list of standard exceptions. */ static char *standard_exc[] = { "constraint_error",