From patchwork Thu Mar 20 14:23:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 190 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (caibbdcaaahb.dreamhost.com [208.113.200.71]) by wilcox.dreamhost.com (Postfix) with ESMTP id 511D5360089 for ; Thu, 20 Mar 2014 07:23:54 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id F182F2918322; Thu, 20 Mar 2014 07:23:53 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id B7E78281AC10 for ; Thu, 20 Mar 2014 07:23:53 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=nGyhKemrpahyYNE0UuCDPjk3OkN2fnxGASXzKV7dHpCI0W0BU7npe JLYQKyjx+CT6svSoZSTYcswvfFgsUkaoI2d9dmRSu0nKyGCK53jPE5/47Elw55uH bVDhVypk7GV8By2RYqpY8sY3rqxnSRyihXGmx5yfxAjbiZIiq487RM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=xR8rOkC79KO16U97S96DpMTwa3E=; b=xra6fp65bkSKe+sCYZI+gq2zYbqL qGEGi/wQxFu1cJejReqfEFxxSU+GhTzhr/VhMVBTiH+9UQtrRbpufjg6Kv1G9Ksr JL69fXvKA5eD5Oyn9V8RB4AXiPEHFbQ2w3diT8SpYZxJ3KBeBvAfXYT1VKPRQhOv EY9R/OFh+AXJdZs= Received: (qmail 12491 invoked by alias); 20 Mar 2014 14:23:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 12469 invoked by uid 89); 20 Mar 2014 14:23:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Mar 2014 14:23:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2KENjjZ012371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Mar 2014 10:23:45 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2KENiu7020406 for ; Thu, 20 Mar 2014 10:23:44 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PUSHED] Further cleanup of signal-while-stepping-over-bp-other-thread.c. Date: Thu, 20 Mar 2014 14:23:43 +0000 Message-Id: <1395325423-31261-1-git-send-email-palves@redhat.com> X-DH-Original-To: gdb@patchwork.siddhesh.in This test now uses pthread_kill instead of the host's kill command, so no longer need to block signals, or store the the inferior's PID. gdb/testsuite/ 2014-03-20 Pedro Alves * gdb.threads/signal-while-stepping-over-bp-other-thread.c (pid): Delete. (block_signals, unblock_signals): Delete. (child_function_2, main): Remove references to deleted variable and functions. --- gdb/testsuite/ChangeLog | 8 ++++++ .../signal-while-stepping-over-bp-other-thread.c | 29 ---------------------- 2 files changed, 8 insertions(+), 29 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index bc6d6df..31e0e5d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,13 @@ 2014-03-20 Pedro Alves + * gdb.threads/signal-while-stepping-over-bp-other-thread.c (pid): + Delete. + (block_signals, unblock_signals): Delete. + (child_function_2, main): Remove references to deleted variable + and functions. + +2014-03-20 Pedro Alves + * gdb.threads/signal-while-stepping-over-bp-other-thread.c (main): Use pthread_kill to signal thread 2. * gdb.threads/signal-while-stepping-over-bp-other-thread.exp: diff --git a/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.c b/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.c index 8839a6f..0f3d17a 100644 --- a/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.c +++ b/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.c @@ -22,7 +22,6 @@ unsigned int args[2]; -pid_t pid; pthread_barrier_t barrier; pthread_t child_thread_2, child_thread_3; @@ -38,24 +37,6 @@ callme (void) { } -void -block_signals (void) -{ - sigset_t mask; - - sigfillset (&mask); - sigprocmask (SIG_BLOCK, &mask, NULL); -} - -void -unblock_signals (void) -{ - sigset_t mask; - - sigfillset (&mask); - sigprocmask (SIG_UNBLOCK, &mask, NULL); -} - void * child_function_3 (void *arg) { @@ -79,8 +60,6 @@ child_function_2 (void *arg) int my_number = (long) arg; volatile int *myp = (int *) &args[my_number]; - unblock_signals (); - pthread_barrier_wait (&barrier); while (*myp > 0) @@ -106,10 +85,6 @@ main () int res; long i; - /* Block signals in all threads but one, so that we're sure which - thread gets the signal we send from the command line. */ - block_signals (); - signal (SIGUSR1, handler); /* Call these early so that PLTs for these are resolved soon, @@ -120,10 +95,6 @@ main () pthread_barrier_init (&barrier, NULL, 2); - /* The test uses this global to know where to send the signal - to. */ - pid = getpid (); - i = 0; args[i] = 1; res = pthread_create (&child_thread_2,