From patchwork Mon Mar 17 15:23:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 119 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (caibbdcaabij.dreamhost.com [208.113.200.189]) by wilcox.dreamhost.com (Postfix) with ESMTP id 7CD223600C9 for ; Mon, 17 Mar 2014 08:23:54 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14314964) id 3BDE6500026B; Mon, 17 Mar 2014 08:23:54 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id 1F6375000270 for ; Mon, 17 Mar 2014 08:23:54 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=ZaHTiq4EgwOl12NQnpUubUDUwsOcnfC sk1oqTAmxi9yDhjngi8H+Fvz2h5BFbVCeWaEts/Ah98MlDEZNLFIJTaHZW5YxT+g RKEx8RrHlH5U1n/4Gn9sC/s+aNFZg4eepfwFAOurRZpq3s7XjhGSsuA0BkRV103n nbR53AmKbj/M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=U5Dvtvivoa0cTbVpatprLwKn4Gw=; b=QklOB GJh/jMhkCzcAH6uegmnY2TVYnc40NWDeJITZzfrnpMBVPkjQi9qvX86tQxmdUw3m Tsnb6KJkyiAKdghh9MvbpgCxpz6ebVc61UFid9xY/szY343ZMm/Jfge3HRIAt1sF sRZOWfwYyOmqbSY5SyYU+Sdf1NjxZ/uAWI6p/c= Received: (qmail 5762 invoked by alias); 17 Mar 2014 15:23:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5678 invoked by uid 89); 17 Mar 2014 15:23:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Mar 2014 15:23:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2HFNEAn021811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Mar 2014 11:23:15 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2HFN5A3009032 for ; Mon, 17 Mar 2014 11:23:13 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 6/8] go32-nat.c: Don't override to_open. Date: Mon, 17 Mar 2014 15:23:02 +0000 Message-Id: <1395069784-7406-7-git-send-email-palves@redhat.com> In-Reply-To: <1395069784-7406-1-git-send-email-palves@redhat.com> References: <1395069784-7406-1-git-send-email-palves@redhat.com> X-DH-Original-To: gdb@patchwork.siddhesh.in Although the string says "Done.", nothing is pushing the target as is. Removing the method override let's us fall through to the the base to_open implemention in inf-child.c, which will push the target in reaction to "target native" in a follow up patch. gdb/ 2014-03-17 Pedro Alves * go32-nat.c (go32_open): Delete. (go32_target): Don't override the to_open method. --- gdb/go32-nat.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c index ef5278a..e17707a 100644 --- a/gdb/go32-nat.c +++ b/gdb/go32-nat.c @@ -339,12 +339,6 @@ static struct { }; static void -go32_open (char *name, int from_tty) -{ - printf_unfiltered ("Done. Use the \"run\" command to run the program.\n"); -} - -static void go32_attach (struct target_ops *ops, char *args, int from_tty) { error (_("\ @@ -960,7 +954,6 @@ go32_target (void) { struct target_ops *t = inf_child_target (); - t->to_open = go32_open; t->to_attach = go32_attach; t->to_resume = go32_resume; t->to_wait = go32_wait;