From patchwork Wed Apr 12 08:22:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19986 Received: (qmail 50766 invoked by alias); 12 Apr 2017 08:22:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50738 invoked by uid 89); 12 Apr 2017 08:22:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00053.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 08:22:04 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0103.eurprd08.prod.outlook.com (10.160.211.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Wed, 12 Apr 2017 08:22:02 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660%14]) with mapi id 15.01.1019.026; Wed, 12 Apr 2017 08:22:02 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 5/11] Add M32R_MAX_REGISTER_SIZE Date: Wed, 12 Apr 2017 08:22:02 +0000 Message-ID: <12D8FEDF-F829-4AF0-93B4-461213904B4B@arm.com> References: <15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com> <86inmbwc3v.fsf@gmail.com> In-Reply-To: <86inmbwc3v.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0103; 7:lSHLLec/e76aLwk4YkpdFfOotjBhHha7xkwyxeF0/whw2cKlLlcS7p/KAAHRtm96jUp0c/Hd3A56eYPxWlDIzKW1D0YJ65HEK+/PxcuxpWpVnrFy6NWumud/q1xbb2c6nEldkOGMUWsOr3fEJYZqf0G8GHZLzlFben6b4taPttGdAqDj/bD8aSIs0Cj89aE7FthHwdaz8JKywmrZW3GhvUAyrWjYrjEtGNVvHnXb7DSrjgVIwZMU8ZrOEKjDkMySJxD+NLwO2WMlfrehBbvRw92BH2vpAikHLnArNfb8TabWfM48B7NHwLdiafHlvQ7W0jmoLHO7pdU1O+zEliH+EA== x-ms-office365-filtering-correlation-id: 139cd544-c3da-43df-cf9e-08d4817cff5e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:AM3PR08MB0103; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:AM3PR08MB0103; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0103; x-forefront-prvs: 027578BB13 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39840400002)(39450400003)(39850400002)(39400400002)(24454002)(377424004)(6116002)(3846002)(102836003)(5250100002)(7736002)(82746002)(6916009)(305945005)(2950100002)(83716003)(36756003)(50986999)(54356999)(76176999)(2900100001)(33656002)(575784001)(86362001)(189998001)(66066001)(1411001)(6486002)(6506006)(99286003)(38730400002)(4326008)(110136004)(6436002)(54906002)(6512007)(229853002)(53936002)(5660300001)(39060400002)(3280700002)(3660700001)(25786009)(6246003)(53546009)(2906002)(8676002)(81166006)(8936002)(15760500002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0103; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <4BE9E268CB2BD14585C6D731F62F3376@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2017 08:22:02.4652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0103 > On 11 Apr 2017, at 10:02, Yao Qi wrote: > > Alan Hayward writes: > >> +/* Big enough to hold the size of the largest register in bytes. */ >> +#define M32R_MAX_REGISTER_SIZE 4 >> + >> #endif /* m32r-tdep.h */ >> diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c >> index 40f29d343b91f254cce2dd783553795c9c990eff..cb53a352b2d47068ad7cd5dacd3325d66bd77964 100644 >> --- a/gdb/m32r-tdep.c >> +++ b/gdb/m32r-tdep.c >> @@ -677,7 +677,7 @@ m32r_push_dummy_call (struct gdbarch *gdbarch, struct value *function, >> enum type_code typecode; >> CORE_ADDR regval; >> gdb_byte *val; >> - gdb_byte valbuf[MAX_REGISTER_SIZE]; >> + gdb_byte valbuf[M32R_MAX_REGISTER_SIZE]; > > valbuf is only used for argument registers, r0 - r3. Can you rename > M32R_MAX_REGISTER_SIZE with M32R_ARG_REGISTER_SIZE? and move its > definition into m32r-tdep.c. > > /* The size of argument registers (r0 - r3) in bytes. */ > #define M32R_ARG_REGISTER_SIZE 4 > > OK with the change. > > -- > Yao (齐尧) Ok, pushed the following patch: Alan. 2017-04-12 Alan Hayward * m32r-tdep.c M32R_ARG_REGISTER_SIZE: Added. (m32r_push_dummy_call): Use M32R_ARG_REGISTER_SIZE. diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c index 1d0d7ed..4701f7a 100644 --- a/gdb/m32r-tdep.c +++ b/gdb/m32r-tdep.c @@ -39,6 +39,9 @@ #include "m32r-tdep.h" #include +/* The size of the argument registers (r0 - r3) in bytes. */ +#define M32R_ARG_REGISTER_SIZE 4 + /* Local functions */ extern void _initialize_m32r_tdep (void); @@ -677,7 +680,7 @@ m32r_push_dummy_call (struct gdbarch *gdbarch, struct value *function, enum type_code typecode; CORE_ADDR regval; gdb_byte *val; - gdb_byte valbuf[MAX_REGISTER_SIZE]; + gdb_byte valbuf[M32R_ARG_REGISTER_SIZE]; int len; /* First force sp to a 4-byte alignment. */