| Message ID | 1063903693.5257056.1496148658168@mail.yahoo.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 70604 invoked by alias); 30 May 2017 12:50:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70584 invoked by uid 89); 30 May 2017 12:50:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.6 required=5.0 tests=AWL, BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=andrea, H*RU:sk:sonic31, Hx-spam-relays-external:sk:sonic31, Andrea X-HELO: sonic316-43.consmr.mail.ir2.yahoo.com Received: from sonic316-43.consmr.mail.ir2.yahoo.com (HELO sonic316-43.consmr.mail.ir2.yahoo.com) (87.248.110.155) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 May 2017 12:50:56 +0000 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ir2.yahoo.com with HTTP; Tue, 30 May 2017 12:50:58 +0000 Date: Tue, 30 May 2017 12:50:58 +0000 (UTC) From: "Andrea Corallo via gdb-patches" <gdb-patches@sourceware.org> Reply-To: Andrea Corallo <andrea_corallo@yahoo.it> Reply-To: Andrea Corallo <andrea_corallo@yahoo.it> To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> Message-ID: <1063903693.5257056.1496148658168@mail.yahoo.com> Subject: [PATCH] sim: microblaze: target endianess recognition fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit References: <1063903693.5257056.1496148658168.ref@mail.yahoo.com> X-IsSubscribed: yes |
Commit Message
Terekhov, Mikhail via Gdb-patches
May 30, 2017, 12:50 p.m. UTC
Hello, seams the microblaze simulator is missing endianness conversions running on small endian machine. This small patch does the job for me. I hope all is ok, is my first contribution so please forgive me in case I'm missing something. sim/microblaze/ChangeLog: 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it> * interp.c: (target_big_endian): target endianess recognition fix. --- sim/microblaze/interp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote: > Hello, > seams the microblaze simulator is missing endianness conversions running on small endian machine. > This small patch does the job for me. > I hope all is ok, is my first contribution so please forgive me in case I'm missing something. > > sim/microblaze/ChangeLog: > > 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it> > * interp.c: (target_big_endian): target endianess recognition fix. > --- > sim/microblaze/interp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c > index e619cf8..75fc98b 100644 > --- a/sim/microblaze/interp.c > +++ b/sim/microblaze/interp.c > @@ -31,7 +31,7 @@ > > #include "microblaze-dis.h" > > -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN) > +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > > static unsigned long > microblaze_extract_unsigned_integer (unsigned char *addr, int len) OK to apply. If you don't have write privileges, let me know.
I guess I don't. Thanks K. Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto: On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote: > Hello, > seams the microblaze simulator is missing endianness conversions running on small endian machine. > This small patch does the job for me. > I hope all is ok, is my first contribution so please forgive me in case I'm missing something. > > sim/microblaze/ChangeLog: > > 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it> > * interp.c: (target_big_endian): target endianess recognition fix. > --- > sim/microblaze/interp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c > index e619cf8..75fc98b 100644 > --- a/sim/microblaze/interp.c > +++ b/sim/microblaze/interp.c > @@ -31,7 +31,7 @@ > > #include "microblaze-dis.h" > > -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN) > +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > > static unsigned long > microblaze_extract_unsigned_integer (unsigned char *addr, int len) OK to apply. If you don't have write privileges, let me know.
Hi Micheal, re reading my last mail I've realized it was maybe not so clear. I don't have write privileges so could you apply the patch? Thanks Andrea Il Martedì 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches <gdb-patches@sourceware.org> ha scritto: I guess I don't. Thanks K. Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto: On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote: > Hello, > seams the microblaze simulator is missing endianness conversions running on small endian machine. > This small patch does the job for me. > I hope all is ok, is my first contribution so please forgive me in case I'm missing something. > > sim/microblaze/ChangeLog: > > 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it> > * interp.c: (target_big_endian): target endianess recognition fix. > --- > sim/microblaze/interp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c > index e619cf8..75fc98b 100644 > --- a/sim/microblaze/interp.c > +++ b/sim/microblaze/interp.c > @@ -31,7 +31,7 @@ > > #include "microblaze-dis.h" > > -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN) > +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > > static unsigned long > microblaze_extract_unsigned_integer (unsigned char *addr, int len) OK to apply. If you don't have write privileges, let me know.
On 06/02/2017 12:03 AM, Andrea Corallo via gdb-patches wrote: > Hi Micheal, > re reading my last mail I've realized it was maybe not so clear. > I don't have write privileges so could you apply the patch? > Thanks Andrea > > > Il Martedì 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches <gdb-patches@sourceware.org> ha scritto: > > > > I guess I don't. > > Thanks > > K. > > > > > Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto: > > > > On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote: > >> Hello, >> seams the microblaze simulator is missing endianness conversions running on small endian machine. >> This small patch does the job for me. >> I hope all is ok, is my first contribution so please forgive me in case I'm missing something. >> >> sim/microblaze/ChangeLog: >> >> 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it> >> * interp.c: (target_big_endian): target endianess recognition fix. >> --- >> sim/microblaze/interp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c >> index e619cf8..75fc98b 100644 >> --- a/sim/microblaze/interp.c >> +++ b/sim/microblaze/interp.c >> @@ -31,7 +31,7 @@ >> >> #include "microblaze-dis.h" >> >> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN) >> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) >> >> static unsigned long >> microblaze_extract_unsigned_integer (unsigned char *addr, int len) > > OK to apply. If you don't have write privileges, let me know. > Applied to GDB master. Commit e7cd268.
diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c index e619cf8..75fc98b 100644 --- a/sim/microblaze/interp.c +++ b/sim/microblaze/interp.c @@ -31,7 +31,7 @@ #include "microblaze-dis.h" -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN) +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) static unsigned long microblaze_extract_unsigned_integer (unsigned char *addr, int len)