From patchwork Wed Sep 27 17:27:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 76793 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FEE23875457 for ; Wed, 27 Sep 2023 17:29:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5FEE23875457 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695835748; bh=cVXJkOhgOE1IPgbkg7YemK/5JU48WvXKHmQxFUAD+Bs=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YVtgz1eV/FDs84EYg5IXKD6/a/l9QYcEmlDLKpJP+CUFOup2xgRVy6wbD9Vp1477o rV7XUbYHh6gGvXCzX+MkLJefVMjK2APSpTLlf/mQFWVF8WP8nWYDVVZYrPLWa4Gma0 2VDyg0Ykw1yF8y+nnj9mKQGsNfOltKvosfhDu+6U= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7A9DC38618FD for ; Wed, 27 Sep 2023 17:28:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A9DC38618FD Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-10hiKaefMZiaYfpUvOh9eQ-1; Wed, 27 Sep 2023 13:28:10 -0400 X-MC-Unique: 10hiKaefMZiaYfpUvOh9eQ-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7740cf4136aso2067032185a.2 for ; Wed, 27 Sep 2023 10:28:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695835690; x=1696440490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cVXJkOhgOE1IPgbkg7YemK/5JU48WvXKHmQxFUAD+Bs=; b=p9v0vRUu5a4t7NDR60mqGfLFJA59Tp/6aTL3FYzEZrcn/UviRr5xWujcqLWRap/1ws 6sDbC77yX+YCLOGb2RjMn4qBanXqhxcQ4WfbNVk6z4TENdZoVVyFzFCqjIOn4zKAEt4S ksQHThBDyQxiC8EN8IzCwF9mVg8UjGTC5bA1f5yMpy5ZAL8BPAskH3PFDzfO6QrU299L fUjICHXomcSuO3mA8fuCerNVMlIi2dtrR9aB5FA0ii6uCr2cy/CitsGvxssMRycpz1o8 +BwoQTTAQ4yAG4bokOoZDFGkedsgdmVYjp+Uwn7GKLC/uy1n55wmgv9zrJlSTDnPz93P GorA== X-Gm-Message-State: AOJu0Yypi2zpm6CindVihKssjcjgE6qO+RzwdVF+haJW83YOfLVvMa22 pPIi/vkRhRdDs80uZuGUxcB9b7+UzaJPHb9f8c4QW0pgaEiM+bwNsenTJ7NPSQ0VHr0az6ZJF5I S+t/kOK1pp3j9ndtsmNYG+1yiLOBmnHQvznQ00fyhANbpKkkQjd65305DOSf1nDb1RXBdy6SRqO lOcLxXWA== X-Received: by 2002:a05:620a:2494:b0:773:eb81:d043 with SMTP id i20-20020a05620a249400b00773eb81d043mr2790846qkn.52.1695835689891; Wed, 27 Sep 2023 10:28:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5dkkRoVry4lH6CrVc2HHz85v/zOcKCLiZgEgcWw6Equj8NZG+JECEN+qPKTQhM7tvjlCuRw== X-Received: by 2002:a05:620a:2494:b0:773:eb81:d043 with SMTP id i20-20020a05620a249400b00773eb81d043mr2790831qkn.52.1695835689542; Wed, 27 Sep 2023 10:28:09 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id e5-20020a0cb445000000b0063d5d173a51sm3650535qvf.50.2023.09.27.10.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 10:28:09 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess , Andreas Schwab Subject: [PATCHv2 4/5] gdbserver: cleanup in handle_v_run Date: Wed, 27 Sep 2023 18:27:57 +0100 Message-Id: <101de2688bc146244f0ae89477cfd4adf3606551.1695835626.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: <2b98ca58e47638b4760d86bd6e1fa9a9a79fa2ad.1695817255.git.aburgess@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" After the previous commit there is now a redundant string copy in handle_v_run, this commit cleans that up. There should be no functional change after this commit. --- gdbserver/server.cc | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 84b8712e668..e02cdb83b51 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -2989,33 +2989,19 @@ handle_v_run (char *own_buf) } else { + /* The length of the decoded argument. */ size_t len = (next_p - p) / 2; - /* ARG is the unquoted argument received via the RSP. */ + + /* Buffer to decode the argument into. */ char *arg = (char *) xmalloc (len + 1); - /* FULL_ARGS will contain the quoted version of ARG. */ - char *full_arg = (char *) xmalloc ((len + 1) * 2); - /* These are pointers used to navigate the strings above. */ - char *tmp_arg = arg; - char *tmp_full_arg = full_arg; hex2bin (p, (gdb_byte *) arg, len); arg[len] = '\0'; - while (*tmp_arg != '\0') - { - *tmp_full_arg = *tmp_arg; - ++tmp_full_arg; - ++tmp_arg; - } - - /* Finish FULL_ARG and push it into the vector containing - the argv. */ - *tmp_full_arg = '\0'; if (i == 0) - new_program_name = full_arg; + new_program_name = arg; else - new_argv.push_back (full_arg); - xfree (arg); + new_argv.push_back (arg); } if (*next_p == '\0') break;