From patchwork Wed May 17 12:53:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preud'homme X-Patchwork-Id: 20476 Received: (qmail 115752 invoked by alias); 17 May 2017 12:53:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 115677 invoked by uid 89); 17 May 2017 12:53:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=thomaspreudhommefossarmcom, thomas.preudhomme@foss.arm.com, Best, hits X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 May 2017 12:53:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 297981435; Wed, 17 May 2017 05:53:15 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A43583F3E1; Wed, 17 May 2017 05:53:14 -0700 (PDT) Subject: Re: [PATCH, GDB] Expect prompt after no FPU warning To: Yao Qi References: <861srnadl8.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Thomas Preudhomme Message-ID: <0e2b3698-2ee8-0b08-173d-ce60f0602677@foss.arm.com> Date: Wed, 17 May 2017 13:53:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-IsSubscribed: yes Hi, The expected output for info float when the target has no FPU does not include the GDB prompt. This occasionally cause a test failure in the following "finish" test when the prompt happens after the test has been marked as PASSed, since it does not match the expected output. This patch adds the GDB prompt to the expected output of the no FPU regular expression. ChangeLog entry is as follows: *** gdb/testsuite/ChangeLog *** 2017-04-27 Thomas Preud'homme * gdb.base/float.exp: Expect GDB prompt for targets without FPU. Testing: test PASSes with that patch on arm-none-eabi target. Is this ok for master branch and GDB 8 (after a 1 week period)? Best regards, Thomas On 17/05/17 13:20, Thomas Preudhomme wrote: > > > On 17/05/17 13:10, Yao Qi wrote: >> Thomas Preudhomme writes: >> >>> 2017-04-27 Thomas Preud'homme >>> >>> * gdb.base/float.exp (info float): Expect GDB prompt for ARM >> >> Remove " (info float)". >> >>> targets without FPU. >>> >> >> >>> @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then { >>> # if we have NEON. >>> pass "info float (VFP)" >>> } >>> - -re "No floating.point info available for this processor.*" { >>> + -re "No floating.point info available for this >>> processor.*$gdb_prompt $" { >> >> The fix is right but it can be applied to all archs which may not have >> FPU. If you search "N floating.point info", you can find multiple hits. >> $gdb_prompt is needed for all of them. > > Err yes sorry, I didn't add it because I only tested on ARM. I'll update the > patch. Thanks! > > Best regards, > > Thomas diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp index a4762c9742682391074f0707e56a6eae4cd70c6e..956bbf752b72e105f36cbfbda369c77a71979708 100644 --- a/gdb/testsuite/gdb.base/float.exp +++ b/gdb/testsuite/gdb.base/float.exp @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then { # if we have NEON. pass "info float (VFP)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -63,7 +63,7 @@ if { [is_aarch64_target] } then { -re "fp0.*fp1.*fp7.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -81,7 +81,7 @@ if { [is_aarch64_target] } then { -re "fd0.*fd3.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -90,7 +90,7 @@ if { [is_aarch64_target] } then { -re "f0.*f1.*f31.*fpscr.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -102,7 +102,7 @@ if { [is_aarch64_target] } then { -re "fpul.*fr0.*fr1.*fr15.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -111,7 +111,7 @@ if { [is_aarch64_target] } then { } elseif [istarget "sparc*-*-*"] then { gdb_test "info float" "f0.*f1.*f31.*d0.*d30.*" "info float" } else { - gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)" + gdb_test "info float" "No floating.point info available for this processor.*$gdb_prompt $" "info float (unknown target)" } gdb_test "step"