From patchwork Mon Feb 17 16:58:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tankut Baris Aktemur X-Patchwork-Id: 38168 Received: (qmail 122714 invoked by alias); 17 Feb 2020 17:01:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119485 invoked by uid 89); 17 Feb 2020 17:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 16:59:53 +0000 Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 08:59:32 -0800 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga008.jf.intel.com with ESMTP; 17 Feb 2020 08:59:31 -0800 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 01HGxUET028379; Mon, 17 Feb 2020 16:59:30 GMT Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 01HGxUR7027384; Mon, 17 Feb 2020 17:59:30 +0100 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 01HGxUmP027380; Mon, 17 Feb 2020 17:59:30 +0100 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: palves@redhat.com Subject: [PATCH v2 55/58] gdbserver: turn target op 'supports_catch_syscall' into a method Date: Mon, 17 Feb 2020 17:58:03 +0100 Message-Id: <0507cd0229d64d63dbee80dc1b8e8ed1e2bac6cd.1581956647.git.tankut.baris.aktemur@intel.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes gdbserver/ChangeLog: 2020-02-10 Tankut Baris Aktemur Turn process_stratum_target's supports_catch_syscall op into a method of process_target. * target.h (struct process_stratum_target): Remove the target op. (class process_target): Add the target op. (target_supports_catch_syscall): Update the macro. * target.cc (process_target::supports_catch_syscall): Define. Update the derived classes and callers below. * linux-low.cc (linux_target_ops): Update. (linux_supports_catch_syscall): Turn into ... (linux_process_target::supports_catch_syscall): ... this. * linux-low.h (class linux_process_target): Update. * lynx-low.cc (lynx_target_ops): Update. * nto-low.cc (nto_target_ops): Update. * win32-low.cc (win32_target_ops): Update. --- gdbserver/linux-low.cc | 5 ++--- gdbserver/linux-low.h | 2 ++ gdbserver/lynx-low.cc | 1 - gdbserver/nto-low.cc | 1 - gdbserver/target.cc | 6 ++++++ gdbserver/target.h | 10 ++++------ gdbserver/win32-low.cc | 1 - 7 files changed, 14 insertions(+), 12 deletions(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 19ab8fd1eab..559f7519a7d 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -6564,8 +6564,8 @@ linux_process_target::process_qsupported (char **features, int count) the_low_target.process_qsupported (features, count); } -static int -linux_supports_catch_syscall (void) +bool +linux_process_target::supports_catch_syscall () { return (the_low_target.get_syscall_trapinfo != NULL && linux_supports_tracesysgood ()); @@ -7520,7 +7520,6 @@ linux_get_hwcap2 (int wordsize) static linux_process_target the_linux_target; static process_stratum_target linux_target_ops = { - linux_supports_catch_syscall, linux_get_ipa_tdesc_idx, &the_linux_target, }; diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h index 1595926eae5..349f4b7e1eb 100644 --- a/gdbserver/linux-low.h +++ b/gdbserver/linux-low.h @@ -477,6 +477,8 @@ public: #endif bool supports_software_single_step () override; + + bool supports_catch_syscall () override; }; #define get_thread_lwp(thr) ((struct lwp_info *) (thread_target_data (thr))) diff --git a/gdbserver/lynx-low.cc b/gdbserver/lynx-low.cc index 399ccaefad7..76519692a3e 100644 --- a/gdbserver/lynx-low.cc +++ b/gdbserver/lynx-low.cc @@ -741,7 +741,6 @@ static lynx_process_target the_lynx_target; /* The LynxOS target_ops vector. */ static process_stratum_target lynx_target_ops = { - NULL, /* supports_catch_syscall */ NULL, /* get_ipa_tdesc_idx */ &the_lynx_target, }; diff --git a/gdbserver/nto-low.cc b/gdbserver/nto-low.cc index a50213583b2..2ee84420169 100644 --- a/gdbserver/nto-low.cc +++ b/gdbserver/nto-low.cc @@ -947,7 +947,6 @@ nto_process_target::sw_breakpoint_from_kind (int kind, int *size) static nto_process_target the_nto_target; static process_stratum_target nto_target_ops = { - NULL, /* supports_catch_syscall */ NULL, /* get_ipa_tdesc_idx */ &the_nto_target, }; diff --git a/gdbserver/target.cc b/gdbserver/target.cc index b1a28e68cc0..2ea8234be08 100644 --- a/gdbserver/target.cc +++ b/gdbserver/target.cc @@ -820,3 +820,9 @@ process_target::supports_software_single_step () { return false; } + +bool +process_target::supports_catch_syscall () +{ + return false; +} diff --git a/gdbserver/target.h b/gdbserver/target.h index 26ce137bf55..21b6bace681 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -70,10 +70,6 @@ class process_target; shared code. */ struct process_stratum_target { - /* Return 1 if the target supports catch syscall, 0 (or leave the - callback NULL) otherwise. */ - int (*supports_catch_syscall) (void); - /* Return tdesc index for IPA. */ int (*get_ipa_tdesc_idx) (void); @@ -505,6 +501,9 @@ public: /* Returns true if the target can software single step. */ virtual bool supports_software_single_step (); + + /* Return true if the target supports catch syscall. */ + virtual bool supports_catch_syscall (); }; extern process_stratum_target *the_target; @@ -559,8 +558,7 @@ int kill_inferior (process_info *proc); the_target->pt->process_qsupported (features, count) #define target_supports_catch_syscall() \ - (the_target->supports_catch_syscall ? \ - (*the_target->supports_catch_syscall) () : 0) + the_target->pt->supports_catch_syscall () #define target_get_ipa_tdesc_idx() \ (the_target->get_ipa_tdesc_idx \ diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index b218ff5f3fe..132d33441bf 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -1858,7 +1858,6 @@ win32_process_target::sw_breakpoint_from_kind (int kind, int *size) static win32_process_target the_win32_target; static process_stratum_target win32_target_ops = { - NULL, /* supports_catch_syscall */ NULL, /* get_ipa_tdesc_idx */ &the_win32_target, };