From patchwork Wed Sep 30 19:33:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 8895 Received: (qmail 15287 invoked by alias); 30 Sep 2015 19:33:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 12902 invoked by uid 89); 30 Sep 2015 19:33:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-pd0-f201.google.com Received: from mail-pd0-f201.google.com (HELO mail-pd0-f201.google.com) (209.85.192.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 30 Sep 2015 19:33:24 +0000 Received: by pdbou10 with SMTP id ou10so3769513pdb.0 for ; Wed, 30 Sep 2015 12:33:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to :content-type; bh=9biunvFie/BQTPDSQfNTM23iAKDpUPsckw8vhxFT6Vc=; b=af+/Q1/qpqqojxKxGi9H9nT2V2hE090cqQdaoW5g4xqZkNhPIf69DlSKnXC4R/2csx pxEqY5zY66x0nZyXQndVHKkDMAitl9BBlFDMM6IqtzqE7aPzLh6aZ2wPfVnpr9Sp4CI4 CcIp2HHwojx2caZjInnE/ugbMOb8orNUVay3SaXWgsyTYs+dpZ0rbdsvaBL84lcTrw11 EYKv8TS9JIAYBEjQwda86J527nOd0zUYYGvWj4PY5Az7ilK8pWrciPGa/Y42t9w9RQE2 VVsmRtfPl029/OHnUqb6xEyOipo7hsX+gjC5rLotoqeNDHaTVRlrsWFlSrvf/JPSXs9M h5SQ== X-Gm-Message-State: ALoCoQndd7MxnWT4VFpqxWkKXQQlGHZisBNycRnlyYIeCcWPgEbNRMaX/fi41SXBDMzWmjeQvtNTnz+cfmO9A1qhNup/jHfUyruh3elpBFyl2yjNjpqKjHbViuJvrRzAIdGIjcxB0Zb01g2ueLiaQaZwl+tKz21NJeZnULX+zxRI1cC6ohDcWrI= MIME-Version: 1.0 X-Received: by 10.66.246.198 with SMTP id xy6mr4634115pac.36.1443641603076; Wed, 30 Sep 2015 12:33:23 -0700 (PDT) Message-ID: <047d7b15acddef86f30520fc0075@google.com> Date: Wed, 30 Sep 2015 19:33:23 +0000 Subject: [COMMITTED PATCH] dwarf2read.c (setup_type_unit_groups): Add comment. From: Doug Evans To: gdb-patches@sourceware.org X-IsSubscribed: yes Hi. There are some things I'd like to clean up here, but a proper job requires more time than I have right now. This comment at least clears something up for me having not read the code in awhile. 2015-09-30 Doug Evans * dwarf2read.c (setup_type_unit_groups): Add comment. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 5b12342..ddd4a4c 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -9332,6 +9332,11 @@ setup_type_unit_groups (struct die_info *die, struct dwarf2_cu *cu) { struct compunit_symtab *cust = dwarf2_start_symtab (cu, "", NULL, 0); + /* Note: We don't assign tu_group->compunit_symtab yet because we're + still initializing it, and our caller (a few levels up) + process_full_type_unit still needs to know if this is the first + time. */ + tu_group->num_symtabs = lh->num_file_names; tu_group->symtabs = XNEWVEC (struct symtab *, lh->num_file_names);