diff mbox

[doc,RFA] stabs.texinfo: @include gdb-cfg.texi.

Message ID 001a11384590ece205051b1a23d1@google.com
State New
Headers show

Commit Message

Doug Evans July 17, 2015, 10:59 p.m. UTC
Doug Evans writes:
  > On Fri, Jul 17, 2015 at 3:30 PM, Steve Ellcey <sellcey@imgtec.com> wrote:
  > > On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote:
  > >
  > >> 2015-07-16  Doug Evans  <dje@google.com>
  > >>
  > >>       * stabs.texinfo: @include gdb-cfg.texi.
  > >>
  > >> diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo
  > >> index 15c4152..c4ea037 100644
  > >> --- a/gdb/doc/stabs.texinfo
  > >> +++ b/gdb/doc/stabs.texinfo
  > >> @@ -3,6 +3,10 @@
  > >>   @setchapternewpage odd
  > >>   @settitle STABS
  > >>
  > >> +@c man begin INCLUDE
  > >> +@include gdb-cfg.texi
  > >> +@c man end
  > >> +
  > >>   @c @finalout
  > >>
  > >>   @c This is a dir.info fragment to support semi-automated addition of
  > >
  > > This patch breaks my parallel gdb builds (though the bug may be a  
latent
  > > one that this change finally causes to trigger).  On my machine my
  > > parallel GDB build dies with:
  > >
  > > ./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory.
  > >
  > > And then later in the log I see:
  > >
  > > mv GDBvn.new GDBvn.texi
  > >
  > > I think there is a missing dependency in the doc/Makefile.in to say  
that
  > > GDBvn.texi needs to be built before gdb-cfg.texi.
  >
  > Bleah.
  > I think we just need to update STABS_DOC_BUILD_INCLUDES
  > to be like GDB_DOC_BUILD_INCLUDES.
  > I'll take care of it.
  >
  > Thanks for the report.

2015-07-17  Doug Evans  <dje@google.com>

	* Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.

Comments

Steve Ellcey July 20, 2015, 5:07 p.m. UTC | #1
On Fri, 2015-07-17 at 22:59 +0000, Doug Evans wrote:

> 2015-07-17  Doug Evans  <dje@google.com>
> 
> 	* Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.
> 
> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
> index bd30a81..85ed95b 100644
> --- a/gdb/doc/Makefile.in
> +++ b/gdb/doc/Makefile.in
> @@ -143,7 +143,9 @@ GDB_DOC_FILES = \
>   # Stabs manual: All files
>   STABS_DOC_SOURCE_INCLUDES = \
>   	$(srcdir)/fdl.texi
> -STABS_DOC_BUILD_INCLUDES =
> +STABS_DOC_BUILD_INCLUDES = \
> +	gdb-cfg.texi \
> +	GDBvn.texi
>   STABS_DOC_FILES = \
>   	$(srcdir)/stabs.texinfo \
>   	$(STABS_DOC_SOURCE_INCLUDES) \

Doug, are you waiting for an OK from someone before checking this in?  I
tested the patch locally and it fixed my build problem but it doesn't
look like it has been checked in yet.

Steve Ellcey
sellcey@imgtec.com
Doug Evans July 20, 2015, 5:08 p.m. UTC | #2
On Mon, Jul 20, 2015 at 10:07 AM, Steve Ellcey <sellcey@imgtec.com> wrote:
> On Fri, 2015-07-17 at 22:59 +0000, Doug Evans wrote:
>
>> 2015-07-17  Doug Evans  <dje@google.com>
>>
>>       * Makefile.in (STABS_DOC_BUILD_INCLUDES): Add gdb-cfg.texi, GDBvn.texi.
>>
>> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
>> index bd30a81..85ed95b 100644
>> --- a/gdb/doc/Makefile.in
>> +++ b/gdb/doc/Makefile.in
>> @@ -143,7 +143,9 @@ GDB_DOC_FILES = \
>>   # Stabs manual: All files
>>   STABS_DOC_SOURCE_INCLUDES = \
>>       $(srcdir)/fdl.texi
>> -STABS_DOC_BUILD_INCLUDES =
>> +STABS_DOC_BUILD_INCLUDES = \
>> +     gdb-cfg.texi \
>> +     GDBvn.texi
>>   STABS_DOC_FILES = \
>>       $(srcdir)/stabs.texinfo \
>>       $(STABS_DOC_SOURCE_INCLUDES) \
>
> Doug, are you waiting for an OK from someone before checking this in?  I
> tested the patch locally and it fixed my build problem but it doesn't
> look like it has been checked in yet.

Hi.

I checked it in this morning (to trunk and branch).
Steve Ellcey July 20, 2015, 5:17 p.m. UTC | #3
On Mon, 2015-07-20 at 10:08 -0700, Doug Evans wrote:

> Hi.
> 
> I checked it in this morning (to trunk and branch).


Thanks, I must have checked just before you checked it in.

Steve Ellcey
sellcey@imgtec.com
diff mbox

Patch

diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
index bd30a81..85ed95b 100644
--- a/gdb/doc/Makefile.in
+++ b/gdb/doc/Makefile.in
@@ -143,7 +143,9 @@  GDB_DOC_FILES = \
  # Stabs manual: All files
  STABS_DOC_SOURCE_INCLUDES = \
  	$(srcdir)/fdl.texi
-STABS_DOC_BUILD_INCLUDES =
+STABS_DOC_BUILD_INCLUDES = \
+	gdb-cfg.texi \
+	GDBvn.texi
  STABS_DOC_FILES = \
  	$(srcdir)/stabs.texinfo \
  	$(STABS_DOC_SOURCE_INCLUDES) \