From patchwork Sun Dec 17 19:50:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 56523 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2ABAE3858002 for ; Sun, 17 Dec 2023 19:50:56 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 8D7033858C35 for ; Sun, 17 Dec 2023 19:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D7033858C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D7033858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842632; cv=none; b=cHM1ai48emE7VQfoxCN7960CkDrqRF+lxugJhUXskBy4gd6toRvQhjqg9d1XCa/p3NaFubaJOy4pN9kn1AQDpRtevwMCQ9gOBz3vevAS9yAGmcxdwPBU4f2IaSH00xLtj/Y6pzRYu6fl/z6VKS4sbreLkGpJTXhVQV7UsnipBjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702842632; c=relaxed/simple; bh=Ktno7+U25bmNMQg/mR94xlHtqUQ0kdzebjrNQ5t1Cig=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=rsUZ8D2KhH4/xalDMdqNv0UkBBWm3IVkeuBjxp8EAr6VRdR1vWY1/fowE28WeO/7jQzNuhxuO88/8+1caUYLc9y041aF+PwEnTxj+LMoZdOB3KJcL+jHFzE9f3LPVJNMEBI12peE+6usgfEzgyna7XE7C/dfZuPCSzLG7PxbvuY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id EfkFrv54rVly7Ex9hrVgXd; Sun, 17 Dec 2023 19:50:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Ex9grM2Zv1b9NEx9grRfKG; Sun, 17 Dec 2023 19:50:29 +0000 X-Authority-Analysis: v=2.4 cv=FLYIesks c=1 sm=1 tr=0 ts=657f5105 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=FuC6xlOohXcDXnzjUzsA:9 a=QEXdDO2ut3YA:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aUleB8j/g8j/mvN8mpd0cqUvEvaMHZiqYPFck4oKWS8=; b=MCtOTq62YshNbsg4XdV2bq5r5f 3Oe3GUnZcMXzd80iVXBpOeDKKvMv9QHdVcBOckbHZBH4qh4tGzXbux1OaQGYQiLPeDXdrVkbb3zVW xvoAfLQ47Jam5eHhmYvEWhiFn; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:40716 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rEx9g-004MyY-0h for gdb-patches@sourceware.org; Sun, 17 Dec 2023 12:50:28 -0700 From: Tom Tromey Subject: [PATCH 00/14] Cleanups for the TUi register window Date: Sun, 17 Dec 2023 12:50:25 -0700 Message-Id: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAAFRf2UC/x3MQQqDQAxA0atI1g04M2hrr1K6iGPUQJ1KokUQ7 +7Y5Vv8v4OxChs8ix2Uf2LyTRnuVkAcKQ2M0mWDL31w3t1xWQWVB8P4YUrrjKHuHn1oSqorgpz Nyr1s/+Xrnd2SMbZKKY7XaCJbWOE4Tm7wC4t7AAAA To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rEx9g-004MyY-0h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net ([192.168.0.21]) [71.211.161.25]:40716 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCeC9HNBAId+pMb9GF+CXa0I/4P+csS/MUgBq3WN+oYJFSk4QM02dbDLwBxPVwD9MBM7Fmyts5pSSQuOinfuQcfQI8x//TJYvvdg4D7nf0+pmEK2pzA2 4rd71xDnR8EexZnElW7kB1n/a78/T2Oe3S592L0EwPniMXxDSARFwV1a3SGMGPEAOw/mFNoY8TfqXebuu7wblCebnA9ZvlA6I1s= X-Spam-Status: No, score=-3016.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This series is a grab-bag of cleanups to the TUI register window. I've tried to untangle the code somewhat, with the goal being removing the extra rerender overload. This series also fixes the 'exit' bug and removes the hacky and unnecessary recursion flag from tui-hooks.c. More cleanups here are possible -- the register window is pretty old code and pretty ugly. In particular: * the layout code is still pretty bad * it doesn't really make sense for check_register_values to accept a frame, because the window can only really ever use the selected frame anyway * there's no horizontal scrolling, but for vector registers this might be nice (there's a bug about this) Tested-By: Tom de Vries Reviewed-By: Andrew Burgess --- Tom Tromey (14): Use pop_back in tui_register_format Minor C++ cleanups in tui-regs.c Simplify tui_data_window::show_register_group Rename tui_data_item_window -> tui_register_info Remove tui_register_info::visible Move scrollok call in register window Simplify update_register_data Remove the TUI register window rerender overload Simplify tui_data_win::erase_data_content Remove tui_refreshing_registers Remove redundant check from tui_refresh_frame_and_register_information Return void from tui_show_frame_info Rename show_registers -> set_register_group Update TUI register window when the inferior exits gdb/testsuite/gdb.tui/regs.exp | 8 ++ gdb/tui/tui-hooks.c | 36 +++---- gdb/tui/tui-regs.c | 220 +++++++++++++++-------------------------- gdb/tui/tui-regs.h | 47 +++++---- gdb/tui/tui-stack.c | 16 ++- gdb/tui/tui-stack.h | 2 +- 6 files changed, 137 insertions(+), 192 deletions(-) --- base-commit: 2757c1c65fd6ba10c55ba5cf38d600814cf9dc1b change-id: 20231217-tui-regs-cleanup-36d8f390a65a Best regards,