From patchwork Fri Dec 1 16:27:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 56445 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10AC5385C6EE for ; Fri, 1 Dec 2023 16:28:08 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 842B83858C2C for ; Fri, 1 Dec 2023 16:27:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 842B83858C2C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 842B83858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701448076; cv=none; b=A0xd64DSpQX+q3knXxpoDQHn/HmOIwKPz3cWcjU0S4FehosNYBncaiXn9QSZTOco6RD5XlEqboZmVtw+njII227jS0cIgkbyiRFUNEWmsmCd8O8rVYC5HpaHqVomg0AjYR1DFIGFvwzdso852Dg7UtPZ9pbu4AOHeTHoe0Uz0wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701448076; c=relaxed/simple; bh=pto24ihnqjgl27Wgiq1lHV4MjND/D+NxZ3BhWQJkjKA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=GsaYd4LF+wqw9UxkDqhw82bH/6y4/QdwemmKFZ0kkyFke5DNTx8jtKqd0gAwyzZMU10d18QwhLCRfRNWxldHvWmlxyB06pzsPCShd27bfEEHMQm+ZAUGywpafjbgKEv1dQdwLp1BBWGI44dG/SNvpPR8T4gEvS17gzWu+VwvzDU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id ADAF11E091; Fri, 1 Dec 2023 11:27:52 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Luis Machado , John Baldwin , "Aktemur, Tankut Baris" , Simon Marchi Subject: [PATCH 00/24] Fix reading and writing pseudo registers in non-current frames Date: Fri, 1 Dec 2023 11:27:13 -0500 Message-ID: <20231201162751.741751-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3490.7 required=5.0 tests=BAYES_00, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Hi, This is version 3 of: https://inbox.sourceware.org/gdb-patches/20231124212656.96801-1-simon.marchi@efficios.com/ There are two functional changes in this version: - fixed the raw_compare behavior in patch 5 ("gdb: change regcache interface to use array_view"), added a selftest that would have caught my mistake - changed a LONGEST for ULONGEST in patch 3 ("gdb: make store_integer take an array_view") The rest of the changes should all be cosmetic. Simon Marchi (24): gdb: don't handle i386 k registers as pseudo registers gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h gdb: make store_integer take an array_view gdb: simplify conditions in regcache::{read,write,raw_collect,raw_supply}_part gdb: change regcache interface to use array_view gdb: fix bugs in {get,put}_frame_register_bytes gdb: make put_frame_register take an array_view gdb: change value_of_register and value_of_register_lazy to take the next frame gdb: remove frame_register gdb: make put_frame_register take the next frame gdb: make put_frame_register_bytes take the next frame gdb: make get_frame_register_bytes take the next frame gdb: add value::allocate_register gdb: read pseudo register through frame gdb: change parameter name in frame_unwind_register_unsigned declaration gdb: rename gdbarch_pseudo_register_write to gdbarch_deprecated_pseudo_register_write gdb: add gdbarch_pseudo_register_write that takes a frame gdb: migrate i386 and amd64 to the new gdbarch_pseudo_register_write gdb: make aarch64_za_offsets_from_regnum return za_offsets gdb: add missing raw register read in aarch64_sme_pseudo_register_write gdb: migrate aarch64 to new gdbarch_pseudo_register_write gdb: migrate arm to gdbarch_pseudo_register_read_value gdb: migrate arm to new gdbarch_pseudo_register_write gdb/testsuite: add tests for unwinding of pseudo registers gdb/aarch64-tdep.c | 293 +++++---- gdb/alpha-tdep.c | 11 +- gdb/amd64-tdep.c | 82 +-- gdb/arch/arm-get-next-pcs.c | 8 +- gdb/arch/arm-get-next-pcs.h | 5 +- gdb/arch/arm.c | 2 +- gdb/arch/arm.h | 4 +- gdb/arm-linux-tdep.c | 11 +- gdb/arm-tdep.c | 145 +++-- gdb/avr-tdep.c | 3 +- gdb/bfin-tdep.c | 3 +- gdb/csky-tdep.c | 4 +- gdb/defs.h | 39 +- gdb/dwarf2/expr.c | 22 +- gdb/dwarf2/frame.c | 5 +- gdb/eval.c | 3 +- gdb/findvar.c | 50 +- gdb/frame-unwind.c | 3 +- gdb/frame.c | 174 +++--- gdb/frame.h | 28 +- gdb/frv-tdep.c | 3 +- gdb/gdbarch-gen.h | 28 +- gdb/gdbarch.c | 40 +- gdb/gdbarch_components.py | 29 +- gdb/guile/scm-frame.c | 3 +- gdb/h8300-tdep.c | 3 +- gdb/i386-tdep.c | 380 ++++-------- gdb/i386-tdep.h | 15 +- gdb/i387-tdep.c | 16 +- gdb/ia64-tdep.c | 18 +- gdb/infcmd.c | 6 +- gdb/loongarch-tdep.c | 3 +- gdb/m32c-tdep.c | 3 +- gdb/m68hc11-tdep.c | 3 +- gdb/m68k-tdep.c | 17 +- gdb/mep-tdep.c | 3 +- gdb/mi/mi-main.c | 3 +- gdb/mips-tdep.c | 29 +- gdb/msp430-tdep.c | 3 +- gdb/nat/aarch64-hw-point.c | 3 +- gdb/nat/aarch64-scalable-linux-ptrace.c | 20 +- gdb/nat/linux-btrace.c | 3 +- gdb/nds32-tdep.c | 8 +- gdb/python/py-frame.c | 3 +- gdb/python/py-unwind.c | 4 +- gdb/regcache.c | 563 +++++++++++------- gdb/regcache.h | 110 +++- gdb/riscv-tdep.c | 13 +- gdb/rl78-tdep.c | 3 +- gdb/rs6000-tdep.c | 21 +- gdb/s12z-tdep.c | 2 +- gdb/s390-tdep.c | 3 +- gdb/sh-tdep.c | 9 +- gdb/sparc-tdep.c | 3 +- gdb/sparc64-tdep.c | 3 +- gdb/std-regs.c | 11 +- .../gdb.arch/aarch64-pseudo-unwind-asm.S | 82 +++ .../gdb.arch/aarch64-pseudo-unwind.c | 33 + .../gdb.arch/aarch64-pseudo-unwind.exp | 88 +++ .../gdb.arch/amd64-pseudo-unwind-asm.S | 66 ++ gdb/testsuite/gdb.arch/amd64-pseudo-unwind.c | 33 + .../gdb.arch/amd64-pseudo-unwind.exp | 91 +++ .../gdb.arch/arm-pseudo-unwind-asm.S | 79 +++ .../gdb.arch/arm-pseudo-unwind-legacy-asm.S | 84 +++ .../gdb.arch/arm-pseudo-unwind-legacy.c | 33 + .../gdb.arch/arm-pseudo-unwind-legacy.exp | 86 +++ gdb/testsuite/gdb.arch/arm-pseudo-unwind.c | 33 + gdb/testsuite/gdb.arch/arm-pseudo-unwind.exp | 88 +++ gdb/valops.c | 31 +- gdb/value.c | 153 +++++ gdb/value.h | 64 +- gdb/xtensa-tdep.c | 3 +- gdbserver/linux-arm-low.cc | 4 +- gdbserver/regcache.cc | 66 +- gdbserver/regcache.h | 4 +- gdbsupport/common-regcache.cc | 2 +- gdbsupport/common-regcache.h | 55 +- gdbsupport/rsp-low.cc | 8 + gdbsupport/rsp-low.h | 2 + 79 files changed, 2329 insertions(+), 1141 deletions(-) create mode 100644 gdb/testsuite/gdb.arch/aarch64-pseudo-unwind-asm.S create mode 100644 gdb/testsuite/gdb.arch/aarch64-pseudo-unwind.c create mode 100644 gdb/testsuite/gdb.arch/aarch64-pseudo-unwind.exp create mode 100644 gdb/testsuite/gdb.arch/amd64-pseudo-unwind-asm.S create mode 100644 gdb/testsuite/gdb.arch/amd64-pseudo-unwind.c create mode 100644 gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp create mode 100644 gdb/testsuite/gdb.arch/arm-pseudo-unwind-asm.S create mode 100644 gdb/testsuite/gdb.arch/arm-pseudo-unwind-legacy-asm.S create mode 100644 gdb/testsuite/gdb.arch/arm-pseudo-unwind-legacy.c create mode 100644 gdb/testsuite/gdb.arch/arm-pseudo-unwind-legacy.exp create mode 100644 gdb/testsuite/gdb.arch/arm-pseudo-unwind.c create mode 100644 gdb/testsuite/gdb.arch/arm-pseudo-unwind.exp base-commit: 9d8fc40eb0e611162844eb7b89f1c76875153fbe