From patchwork Thu Oct  8 05:09:53 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Paul Pluzhnikov <ppluzhnikov@google.com>
X-Patchwork-Id: 8994
Received: (qmail 52353 invoked by alias); 8 Oct 2015 05:10:27 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 52267 invoked by uid 89); 8 Oct 2015 05:10:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00,
	RCVD_IN_DNSWL_LOW, SPF_PASS,
	T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-wi0-f174.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc:content-type;
	bh=tAhUG05vxazjm2m2Qw1+FJU5meHi8KlbEHXShxY1L4I=;
	b=m355XlrdDSaz+Lx0nooLdzR0f2N3B6BkIpgFSANfwQE2TUnEXjkXWTyC8L27wkgmaE
	UE+jwQ4YaVIiiKdjzWEJjH7LA58myYLkNoR9Xp6F0lpcsOt9vSa6FZ/o90bhaA70eyb/
	YY3JiGezOESGHJaJdwwZtfKFj12qMTd/8ACHGFWzjEj8MKFeLZSBA6/s7Ci5kW7DE9fe
	oNzovdiC8Sm0fxHwfwBuA1U0vvNfeB3JVQdZqkXpuc6C8BeaEShc3GP4p5bxCdo1jWLy
	YF8rWxAB2lA35UwXq/PB3yHCN1x0iI/qVVO/9J4OdaQz1e81gftfa2ibKLn0SkcYsr6x
	zjtw==
X-Gm-Message-State: 
 ALoCoQn71TTA2FRkMgr19KI7am8WhZzBE4fNDvpqcL/KO16nmRIyZPfYanGOBI9aVleEQMSh+Iwy
X-Received: by 10.180.221.193 with SMTP id qg1mr1393839wic.87.1444281023000;
	Wed, 07 Oct 2015 22:10:23 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: 
 <CALoOobOCxqzsG7H5_M4Cc6gCPzRGH-aDs7F_avYy=gvgZ47pqw@mail.gmail.com>
References: 
 <CALoOobN6U4bEXMB3UdW7=6OuH0mJW+iA7+xE8+AiZtVGg3knAw@mail.gmail.com>
	<5614CEDB.5040709@redhat.com>
	<CALoOobMEvHOLK2LQ+UtKch2PZ52anx7=QS9QNC9sZU1iDCD-NA@mail.gmail.com>
	<CALoOobMH9RNcUe913EtBnCKuEN=-OoQXYr27VctH2qPdmvYCLQ@mail.gmail.com>
	<CALoOobOCxqzsG7H5_M4Cc6gCPzRGH-aDs7F_avYy=gvgZ47pqw@mail.gmail.com>
From: Paul Pluzhnikov <ppluzhnikov@google.com>
Date: Wed, 7 Oct 2015 22:09:53 -0700
Message-ID: 
 <CALoOobMEO3sxuxZWtcou-=Dz14RJq-=yPE66ORAqPMzhBT9shw@mail.gmail.com>
Subject: Re: [patch] Fix build error for tst-printf-bz18872 on arm/aarch64
	and s390
To: Florian Weimer <fweimer@redhat.com>
Cc: GLIBC Devel <libc-alpha@sourceware.org>

On Wed, Oct 7, 2015 at 10:06 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Wed, Oct 7, 2015 at 8:13 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>
> The attribute nicely works around the aarch64 break.
>
> Thanks!
>
> 2015-10-07  Paul Pluzhnikov  <ppluzhnikov@google.com>
>
>         * stdio-common/tst-printf-bz18872.sh: Use attribute optimize instead of
>         #pragma optimize.

And again with space-before-paren.

Thanks,

diff --git a/stdio-common/tst-printf-bz18872.sh b/stdio-common/tst-printf-bz18872.sh
index 0127e73..84076c0 100644
--- a/stdio-common/tst-printf-bz18872.sh
+++ b/stdio-common/tst-printf-bz18872.sh
@@ -30,9 +30,8 @@ cat <<'EOF'
 /*
   Compile do_test without optimization: GCC 4.9/5.0/6.0 takes a long time
   to build this source. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67396  */
-#pragma GCC push_options
-#pragma GCC optimize ("-O0")
 
+__attribute__ ((optimize("-O0")))
 int do_test (void)
 {
     mtrace ();
@@ -62,7 +61,6 @@ cat <<'EOF'
 
   return 0;
 }
-#pragma GCC pop_options
 
 #define TEST_FUNCTION do_test ()
 #include "../test-skeleton.c"