diff mbox

gdb/18947: [aarch64]Step into shared library is very slow.

Message ID 1441876920-32009-1-git-send-email-mihail.nistor@freescale.com
State New, archived
Headers

Commit Message

Mihail-Marian Nistor Sept. 10, 2015, 9:22 a.m. UTC 
  Install gdbarch_skip_solib_resolver on aarch64 GNU/Linux

gdb/ChangeLog:
2015-09-10  Mihail-Marian Nistor  <mihail.nistor@freescale.com>

	PR gdb/18947
	* aarch64-linux-tdep.c: (aarch64_linux_init_abi): Install
	glibc_skip_solib_resolver as gdbarch_skip_solib_resolver callback.

Signed-off-by: Mihail-Marian Nistor <mihail.nistor@freescale.com>
---
 gdb/aarch64-linux-tdep.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Yao Qi Sept. 10, 2015, 11:45 a.m. UTC | #1 
Mihail-Marian Nistor <mihail.nistor@freescale.com> writes:

Hi Mihail-Marian,

> Install gdbarch_skip_solib_resolver on aarch64 GNU/Linux
>
> gdb/ChangeLog:
> 2015-09-10  Mihail-Marian Nistor  <mihail.nistor@freescale.com>
>
> 	PR gdb/18947
> 	* aarch64-linux-tdep.c: (aarch64_linux_init_abi): Install
> 	glibc_skip_solib_resolver as gdbarch_skip_solib_resolver callback.

The patch is OK if you run GDB testsuite for aarch64-linux, and no
regressions.  If you don't have an env set up for running GDB testsuite,
I can test it for you.
Mihail-Marian Nistor Sept. 10, 2015, 12:11 p.m. UTC | #2 
Hi Yao,

I have run GDB testsuite for aarch64 and I don't see any regression. 

Best regards,
Mihai

-----Original Message-----
From: Yao Qi [mailto:qiyaoltc@gmail.com] 

Sent: Thursday, September 10, 2015 2:46 PM
To: Nistor Mihail-MNISTOR1 <mihail.nistor@freescale.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow.

Mihail-Marian Nistor <mihail.nistor@freescale.com> writes:

Hi Mihail-Marian,

> Install gdbarch_skip_solib_resolver on aarch64 GNU/Linux

>

> gdb/ChangeLog:

> 2015-09-10  Mihail-Marian Nistor  <mihail.nistor@freescale.com>

>

> 	PR gdb/18947

> 	* aarch64-linux-tdep.c: (aarch64_linux_init_abi): Install

> 	glibc_skip_solib_resolver as gdbarch_skip_solib_resolver callback.


The patch is OK if you run GDB testsuite for aarch64-linux, and no regressions.  If you don't have an env set up for running GDB testsuite, I can test it for you.

--
Yao (齐尧)
Yao Qi Sept. 10, 2015, 1:56 p.m. UTC | #3 
Nistor Mihail <mihail.nistor@freescale.com> writes:

> I have run GDB testsuite for aarch64 and I don't see any regression. 

Great, please push your commit in then.
Mihail-Marian Nistor Sept. 10, 2015, 2:09 p.m. UTC | #4 
Hi Yao,

I don't have the write access on git. Could you please put this patch on git.

Best regards,
Mihai
-----Original Message-----
From: Yao Qi [mailto:qiyaoltc@gmail.com] 

Sent: Thursday, September 10, 2015 4:56 PM
To: Nistor Mihail-MNISTOR1 <mihail.nistor@freescale.com>
Cc: Yao Qi <qiyaoltc@gmail.com>; gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow.

Nistor Mihail <mihail.nistor@freescale.com> writes:

> I have run GDB testsuite for aarch64 and I don't see any regression. 


Great, please push your commit in then.

-- 
Yao (齐尧)
Yao Qi Sept. 11, 2015, 2:26 p.m. UTC | #5 
Nistor Mihail <mihail.nistor@freescale.com> writes:

> I don't have the write access on git. Could you please put this patch on git.

Sure, patch is pushed into mainline.  I plan to push it in to 7.10
branch too.  Mihail-Marian, thanks for your contribution!

For the record, I checked that freescale has the copyright assignment,
so we can push it in.
Mihail-Marian Nistor Sept. 14, 2015, 9:06 a.m. UTC | #6 
Hi Yao,

Thank you very much for your support.

Best regards,
Mihai

-----Original Message-----
From: Yao Qi [mailto:qiyaoltc@gmail.com] 

Sent: Friday, September 11, 2015 5:27 PM
To: Nistor Mihail-MNISTOR1 <mihail.nistor@freescale.com>
Cc: Yao Qi <qiyaoltc@gmail.com>; gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow.

Nistor Mihail <mihail.nistor@freescale.com> writes:

> I don't have the write access on git. Could you please put this patch on git.


Sure, patch is pushed into mainline.  I plan to push it in to 7.10 branch too.  Mihail-Marian, thanks for your contribution!

For the record, I checked that freescale has the copyright assignment, so we can push it in.

--
Yao (齐尧)
diff mbox

Patch

diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index f8cf43e..07ee1ea 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -961,6 +961,7 @@  aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
   /* Shared library handling.  */
   set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
+  set_gdbarch_skip_solib_resolver (gdbarch, glibc_skip_solib_resolver);
 
   tramp_frame_prepend_unwinder (gdbarch, &aarch64_linux_rt_sigframe);