diff mbox

Move strace -m/explicit location test to strace.exp

Message ID 1439503872-21912-1-git-send-email-keiths@redhat.com
State New, archived
Headers

Commit Message

Keith Seitz Aug. 13, 2015, 10:11 p.m. UTC 
  One of the build slaves shows this error running explicit.exp:

(gdb) strace -m gdbfoobarbaz
Remote failure reply: E.In-process agent library not loaded in process.
Fast and static tracepoints unavailable.
(gdb) FAIL: gdb.linespec/explicit.exp: strace -m gdbfoobarbaz

There are two big problems with this test:
1) The expected output is actually not what the test is meant to test for.
2) This test should really only run where it is supported.

This is most easily fixed by moving the test to gdb.trace/strace.exp.

gdb/testsuite/ChangeLog

	* gdb.linespec/explicit.exp: Move strace test from here ...
	* gdb.trace/strace.exp: ... to here.

Comments

Pedro Alves Aug. 17, 2015, 5:17 p.m. UTC | #1 
On 08/13/2015 11:11 PM, Keith Seitz wrote:
> One of the build slaves shows this error running explicit.exp:
> 
> (gdb) strace -m gdbfoobarbaz
> Remote failure reply: E.In-process agent library not loaded in process.
> Fast and static tracepoints unavailable.
> (gdb) FAIL: gdb.linespec/explicit.exp: strace -m gdbfoobarbaz
> 
> There are two big problems with this test:
> 1) The expected output is actually not what the test is meant to test for.
> 2) This test should really only run where it is supported.
> 
> This is most easily fixed by moving the test to gdb.trace/strace.exp.
> 
> gdb/testsuite/ChangeLog
> 
> 	* gdb.linespec/explicit.exp: Move strace test from here ...
> 	* gdb.trace/strace.exp: ... to here.

OK.

Thanks,
Pedro Alves
Keith Seitz Aug. 17, 2015, 7:13 p.m. UTC | #2 
On 08/17/2015 10:17 AM, Pedro Alves wrote:
>> gdb/testsuite/ChangeLog
>>
>> 	* gdb.linespec/explicit.exp: Move strace test from here ...
>> 	* gdb.trace/strace.exp: ... to here.
> 
> OK.

Pushed. Thank you, Pedro.

Keith
diff mbox

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e4cf56c..ac2e5cd 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@ 
+2015-08-13  Keith Seitz  <keiths@redhat.com>
+
+	* gdb.linespec/explicit.exp: Move strace test from here ...
+	* gdb.trace/strace.exp: ... to here.
+
 2015-08-13  Pierre-Marie de Rodat  <derodat@adacore.com>
 
 	* gdb.ada/fun_renaming.exp: New testcase.
diff --git a/gdb/testsuite/gdb.linespec/explicit.exp b/gdb/testsuite/gdb.linespec/explicit.exp
index 344f1b0..a0851cd 100644
--- a/gdb/testsuite/gdb.linespec/explicit.exp
+++ b/gdb/testsuite/gdb.linespec/explicit.exp
@@ -86,10 +86,6 @@  namespace eval $testfile {
     add linespecs "-function myfunction -label top -line 3" $location(top)
     add linespecs "-line 3" $location(normal)
 
-    # Test that static tracepoints on marker ID are not interpreted
-    # as an erroneous explicit option.
-    gdb_test "strace -m gdbfoobarbaz" "You can't do that.*"
-
     # Fire up gdb.
     if {![runto_main]} {
 	return -1
diff --git a/gdb/testsuite/gdb.trace/strace.exp b/gdb/testsuite/gdb.trace/strace.exp
index 8610fdf..e0a4082 100644
--- a/gdb/testsuite/gdb.trace/strace.exp
+++ b/gdb/testsuite/gdb.trace/strace.exp
@@ -390,6 +390,11 @@  if { ![gdb_target_supports_trace] } then {
     return -1
 }
 
+# Double-check that marker ID ("-m") is not mistaken for an explicit location
+# flag.
+gdb_test "strace -m gdbfoobarbaz" \
+    "No known static tracepoint marker named gdbfoobarbaz"
+
 strace_probe_marker
 
 strace_trace_on_same_addr "trace"