diff mbox

Remove required field in agent's symbols

Message ID 1438858101-35923-1-git-send-email-pierre.langlois@arm.com
State New, archived
Headers

Commit Message

Pierre Langlois Aug. 6, 2015, 10:48 a.m. UTC 
  Hi all,

While looking at the in-process agent I noticed shared symbols between
GDBserver and the IPA could be marked as <required>.  This field was never
set nor used so this patch removes it.

Thanks,
Pierre

gdb/ChangeLog:

	* common/agent.c (symbol_list) <required>: Remove.

gdb/gdbserver/ChangeLog:

	* tracepoint.c (symbol_list) <required>: Remove.
---
 gdb/common/agent.c         | 1 -
 gdb/gdbserver/tracepoint.c | 1 -
 2 files changed, 2 deletions(-)

Comments

Pedro Alves Aug. 6, 2015, 11:02 a.m. UTC | #1 
On 08/06/2015 11:48 AM, Pierre Langlois wrote:
> Hi all,
> 
> While looking at the in-process agent I noticed shared symbols between
> GDBserver and the IPA could be marked as <required>.  This field was never
> set nor used so this patch removes it.

OK.

Yeah, IIRC, that was meant for providing backwards compatibility when new
symbols are added.  But we never did that.  Given the tight coupling
between gdbserver and ipa, adding the field back if we ever need it is such
a minor detail...

Thanks,
Pedro Alves
Pierre Langlois Aug. 6, 2015, 11:30 a.m. UTC | #2 
On 06/08/15 12:02, Pedro Alves wrote:
> On 08/06/2015 11:48 AM, Pierre Langlois wrote:
>> Hi all,
>>
>> While looking at the in-process agent I noticed shared symbols between
>> GDBserver and the IPA could be marked as <required>.  This field was never
>> set nor used so this patch removes it.
> 
> OK.

Thanks Pedro, I've pushed this in.

Pierre

> 
> Yeah, IIRC, that was meant for providing backwards compatibility when new
> symbols are added.  But we never did that.  Given the tight coupling
> between gdbserver and ipa, adding the field back if we ever need it is such
> a minor detail...
> 
> Thanks,
> Pedro Alves
>
diff mbox

Patch

diff --git a/gdb/common/agent.c b/gdb/common/agent.c
index 999a3de..5bb18641 100644
--- a/gdb/common/agent.c
+++ b/gdb/common/agent.c
@@ -63,7 +63,6 @@  static struct
 {
   const char *name;
   int offset;
-  int required;
 } symbol_list[] = {
   IPA_SYM(helper_thread_id),
   IPA_SYM(cmd_buf),
diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index b5f252a..e1c4a45 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -177,7 +177,6 @@  static struct
 {
   const char *name;
   int offset;
-  int required;
 } symbol_list[] = {
   IPA_SYM(gdb_tp_heap_buffer),
   IPA_SYM(gdb_jump_pad_buffer),