PR record/18691: Fix fails in solib-precsave.exp

  We see the following regressions in testing on x86_64-linux,

 reverse-step^M
 Cannot access memory at address 0x2aaaaaed26c0^M
 (gdb) FAIL: gdb.reverse/solib-precsave.exp: reverse-step into solib function one

when GDB reverse step into a function, GDB wants to skip prologue so
it requests TARGET_OBJECT_CODE_MEMORY to read some code memory in
memory_xfer_partial_1.  However in dcache_read_memory_partial, the object
becomes TARGET_OBJECT_MEMORY

      return ops->to_xfer_partial (ops, TARGET_OBJECT_MEMORY, NULL,
                                   myaddr, NULL, memaddr, len,
                                   xfered_len);

in reverse debugging, ops->to_xfer_partial is record_full_core_xfer_partial
and it will return TARGET_XFER_E_IO because it can't find any records.
The test fails.

At this moment, the delegate relationship is like

  dcache -> record-core -> core -> exec

and we want to GDB read memory across targets, which means if the
requested memory isn't found in record-core, GDB can read memory from
core, and exec even further if needed.  I find raw_memory_xfer_partial
is exactly what I want.

Regression tested on x86_64-linux both native and gdbserver.

gdb:

2015-07-29  Yao Qi  <yao.qi@linaro.org>

	PR record/18691
	* dcache.c (dcache_read_memory_partial): Call
	raw_memory_xfer_partial.
	* target.c (raw_memory_xfer_partial): Make it non-static.
	* target.h (raw_memory_xfer_partial): Declare.
---
 gdb/dcache.c | 5 ++---
 gdb/target.c | 2 +-
 gdb/target.h | 5 +++++
 3 files changed, 8 insertions(+), 4 deletions(-)
  

On 07/29/2015 08:17 AM, Yao Qi wrote:

> and we want to GDB read memory across targets, which means if the
> requested memory isn't found in record-core, GDB can read memory from
> core, and exec even further if needed.  I find raw_memory_xfer_partial
> is exactly what I want.

LGTM.

> diff --git a/gdb/target.h b/gdb/target.h
> index 32234f7..75b830d 100644
> --- a/gdb/target.h
> +++ b/gdb/target.h
> @@ -265,6 +265,11 @@ typedef enum target_xfer_status
>  			     ULONGEST len,
>  			     ULONGEST *xfered_len);
>  
> +enum target_xfer_status
> +raw_memory_xfer_partial (struct target_ops *ops, gdb_byte *readbuf,
> +			 const gdb_byte *writebuf, ULONGEST memaddr, LONGEST len,
> +			 ULONGEST *xfered_len);

Being a declaration, the function name shouldn't be on column 0, but
on column 2 instead.

Thanks,
Pedro Alves