[8/8] Remove proc->priv->new_inferior

Message ID 1437392126-29503-9-git-send-email-yao.qi@linaro.org
State New, archived
Headers

Commit Message

Yao Qi July 20, 2015, 11:35 a.m. UTC
  As the result of the previous patch, new_inferior is no longer used.
This patch is to remove it.

gdb/gdbserver:

2015-07-16  Yao Qi  <yao.qi@linaro.org>

	* linux-low.c (linux_create_inferior): Remove setting to
	proc->priv->new_inferior.
	(linux_attach): Likewise.
	(linux_low_filter_event): Likewise.
	* linux-low.h (struct process_info_private) <new_inferior>: Remove.
---
 gdb/gdbserver/linux-low.c | 12 ++----------
 gdb/gdbserver/linux-low.h |  5 -----
 2 files changed, 2 insertions(+), 15 deletions(-)
  

Comments

Pedro Alves July 23, 2015, 11:27 p.m. UTC | #1
On 07/20/2015 12:35 PM, Yao Qi wrote:
> As the result of the previous patch, new_inferior is no longer used.
> This patch is to remove it.
> 
> gdb/gdbserver:
> 
> 2015-07-16  Yao Qi  <yao.qi@linaro.org>
> 
> 	* linux-low.c (linux_create_inferior): Remove setting to
> 	proc->priv->new_inferior.
> 	(linux_attach): Likewise.
> 	(linux_low_filter_event): Likewise.
> 	* linux-low.h (struct process_info_private) <new_inferior>: Remove.

LGTM.

Thanks,
Pedro Alves
  

Patch

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 10942c8..3275576 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -763,7 +763,6 @@  linux_create_inferior (char *program, char **allargs)
   ptid_t ptid;
   struct cleanup *restore_personality
     = maybe_disable_address_space_randomization (disable_randomization);
-  struct process_info *proc;
 
 #if defined(__UCLIBC__) && defined(HAS_NOMMU)
   pid = vfork ();
@@ -811,9 +810,7 @@  linux_create_inferior (char *program, char **allargs)
 
   do_cleanups (restore_personality);
 
-  proc = linux_add_process (pid, 0);
-  /* Set the arch when the first LWP stops.  */
-  proc->priv->new_inferior = 1;
+  linux_add_process (pid, 0);
 
   ptid = ptid_build (pid, pid, 0);
   new_lwp = add_lwp (ptid);
@@ -967,7 +964,6 @@  linux_attach (unsigned long pid)
 {
   ptid_t ptid = ptid_build (pid, pid, 0);
   int err;
-  struct process_info *proc;
 
   /* Attach to PID.  We will check for other threads
      soon.  */
@@ -976,9 +972,7 @@  linux_attach (unsigned long pid)
     error ("Cannot attach to process %ld: %s",
 	   pid, linux_ptrace_attach_fail_reason_string (ptid, err));
 
-  proc = linux_add_process (pid, 1);
-  /* Set the arch when the first LWP stops.  */
-  proc->priv->new_inferior = 1;
+  linux_add_process (pid, 1);
 
   if (!non_stop)
     {
@@ -2130,8 +2124,6 @@  linux_low_filter_event (int lwpid, int wstat)
 	      the_low_target.arch_setup ();
 
 	      current_thread = saved_thread;
-
-	      proc->priv->new_inferior = 0;
 	    }
 	  else
 	    {
diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h
index 3300da9..5a3697b 100644
--- a/gdb/gdbserver/linux-low.h
+++ b/gdb/gdbserver/linux-low.h
@@ -115,11 +115,6 @@  struct process_info_private
 
   /* &_r_debug.  0 if not yet determined.  -1 if no PT_DYNAMIC in Phdrs.  */
   CORE_ADDR r_debug;
-
-  /* This flag is true iff we've just created or attached to the first
-     LWP of this process but it has not stopped yet.  As soon as it
-     does, we need to call the low target's arch_setup callback.  */
-  int new_inferior;
 };
 
 struct lwp_info;