Delete program spaces directly when removing inferiors

From: Simon Marchi <simon.marchi@ericsson.com>

  On 15-07-08 08:05 AM, Pedro Alves wrote:
> On 09/29/2014 09:33 PM, Simon Marchi wrote:
> 
>> -void
>> -delete_inferior (int pid)
>> -{
>> -  struct inferior *inf = find_inferior_pid (pid);
>> -
>> -  delete_inferior_1 (inf, 0);
>> -
>> -  if (print_inferior_events)
>> -    printf_unfiltered (_("[Inferior %d exited]\n"), pid);
>> -}
>> +  /* If this program space is rendered useless, remove it. */
>> +  if (program_space_empty_p (inf->pspace))
>> +      delete_program_space (inf->pspace);
> 
> I think there's something odd with indentation here.

Ok.

>> -  struct program_space *ss, **ss_link;
>> -  struct program_space *current = current_program_space;
>> +  gdb_assert(pspace != NULL);
>> +  gdb_assert(pspace != current_program_space);
>>  
>> -  ss = program_spaces;
>> -  ss_link = &program_spaces;
>> -  while (ss)
>> +  if (pspace == program_spaces)
>> +    program_spaces = pspace->next;
>> +  else
>>      {
>> -      if (ss == current || !pspace_empty_p (ss))
>> +      struct program_space *i = program_spaces;
>> +
>> +      for (i = program_spaces; i != NULL; i = i->next)
>>  	{
>> -	  ss_link = &ss->next;
>> -	  ss = *ss_link;
>> -	  continue;
>> +	  if (i->next == pspace)
>> +	    {
>> +	      i->next = i->next->next;
>> +	      break;
>> +	    }
>>  	}
>> -
>> -      *ss_link = ss->next;
>> -      release_program_space (ss);
>> -      ss = *ss_link;
>>      }
> 
> I don't find this conversion from while to if+else+for an
> improvement.  You can instead write:
> 
>   ss = program_spaces;
>   ss_link = &program_spaces;
>   while (ss != NULL)
>     {
>       if (ss == pspace)
>         {
>          *ss_link = ss->next;
>           break;
>         }
> 
>       ss_link = &ss->next;
>       ss = *ss_link;
>     }
>   release_program_space (pspace);
> 
> We use this _link pattern in several places.
> 
> OK with that change.

Ok, pushed with those changes:

From 0560c645c02eba2828a053039dcfdf676cdd1d00 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 29 Sep 2014 16:33:10 -0400
Subject: [PATCH] Delete program spaces directly when removing inferiors

When deleting an inferior, delete the associated program space as well
if it becomes unused. This replaces the "pruning" approach, with which
you could forget to call prune_program_spaces (as seen, with the
-remove-inferior command, see [1]).

This allows to remove the prune_program_spaces function. At the same
time, I was able to clean up the delete_inferior* family.
delete_inferior_silent and delete_inferior were unused, which allowed
renaming delete_inferior_1 to delete_inferior. Also, since all calls to
it were with silent=1, I removed that parameter completely.

I renamed pspace_empty_p to program_space_empty_p. I prefer if the
"exported" functions have a more explicit and standard name.

Tested on Ubuntu 14.10.

This obsoletes my previous patch "Add call to prune_program_spaces in
mi_cmd_remove_inferior" [1].

[1] https://sourceware.org/ml/gdb-patches/2014-09/msg00717.html

gdb/Changelog:

	* inferior.c (delete_inferior_1): Rename to ...
	(delete_inferior): ..., remove 'silent' parameter, delete
	program space when unused and remove call to prune_program_spaces.
	Remove the old, unused, delete_inferior.
	(delete_inferior_silent): Remove.
	(prune_inferiors): Change call from delete_inferior_1 to
	delete_inferior and remove 'silent' parameter. Remove call to
	prune_program_spaces.
	(remove_inferior_command): Idem.
	* inferior.h (delete_inferior_1): Rename to...
	(delete_inferior): ..., remove 'silent' parameter and remove the
	original delete_inferior.
	(delete_inferior_silent): Remove.
	* mi/mi-main.c (mi_cmd_remove_inferior): Change call from
	delete_inferior_1 to delete_inferior and remove 'silent'
	parameter.
	* progspace.c (prune_program_spaces): Remove.
	(pspace_empty_p): Rename to...
	(program_space_empty_p): ... and make non-static.
	(delete_program_space): New.
	* progspace.h (prune_program_spaces): Remove declaration.
	(program_space_empty_p): New declaration.
	(delete_program_space): New declaration.
---
 gdb/ChangeLog    | 26 ++++++++++++++++++++++++++
 gdb/inferior.c   | 39 ++++++++-------------------------------
 gdb/inferior.h   |  9 +--------
 gdb/mi/mi-main.c |  2 +-
 gdb/progspace.c  | 27 ++++++++++++++-------------
 gdb/progspace.h  | 11 +++++++----
 6 files changed, 57 insertions(+), 57 deletions(-)

Delete program spaces directly when removing inferiors

Commit Message

Comments

Patch