[08/11] New proc is_aarch64_target
Commit Message
Some tests expect the the target is aarch64, but checking target
triplet is not accurate, because target triplet can be aarch64 but
the program is in arm (or aarch32) state.
This patch addes a new proc is_aarch64_target which returns true
if the target is on aarch64 state.
gdb/testsuite:
2015-06-19 Yao Qi <yao.qi@linaro.org>
* gdb.arch/aarch64-atomic-inst.exp: Check is_aarch64_target
instead of istarget "aarch64*-*-*".
* gdb.arch/aarch64-fp.exp: Likewise.
* gdb.base/float.exp: Likewise.
* gdb.reverse/aarch64.exp: Likewise.
* lib/gdb.exp (is_aarch64_target): New proc.
---
gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp | 2 +-
gdb/testsuite/gdb.arch/aarch64-fp.exp | 2 +-
gdb/testsuite/gdb.base/float.exp | 2 +-
gdb/testsuite/gdb.reverse/aarch64.exp | 2 +-
gdb/testsuite/lib/gdb.exp | 10 ++++++++++
5 files changed, 14 insertions(+), 4 deletions(-)
Comments
Yao Qi <qiyaoltc@gmail.com> writes:
> + return [expr ![is_aarch32_target]]
[expr] is redundant.
Andreas.
On 01/07/15 15:10, Andreas Schwab wrote:
>> + return [expr ![is_aarch32_target]]
> [expr] is redundant.
If I write "return ![is_aarch32_target]", I'll get a tcl error,
ERROR: tcl error sourcing
../../../binutils-gdb/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp.
ERROR: expected boolean value but got "!1"
while executing
"if {![is_aarch64_target]} {
verbose "Skipping ${gdb_test_file_name}."
return
}"
Yao Qi <qiyaoltc@gmail.com> writes:
> On 01/07/15 15:10, Andreas Schwab wrote:
>>> + return [expr ![is_aarch32_target]]
>> [expr] is redundant.
>
> If I write "return ![is_aarch32_target]", I'll get a tcl error,
Sorry, you are right of course, I've missed the !.
Andreas.
@@ -19,7 +19,7 @@
# Test single stepping through atomic sequences beginning with
# a ldxr instruction and ending with a stxr instruction.
-if {![istarget "aarch64*"]} {
+if {![is_aarch64_target]} {
verbose "Skipping ${gdb_test_file_name}."
return
}
@@ -19,7 +19,7 @@
# PR server/17457
# Test aarch64 floating point registers q0, q1, v0, v1, fpsr, fpcr
-if {![istarget "aarch64*"]} {
+if {![is_aarch64_target]} {
verbose "Skipping ${gdb_test_file_name}."
return
}
@@ -36,7 +36,7 @@ if ![runto_main] then {
# Test "info float".
-if { [istarget "aarch64*-*-*"] } then {
+if { [is_aarch64_target] } then {
gdb_test "info float" "d0.*d1.*d31.*s0.*s1.*s31.*" "info float"
} elseif { [istarget "alpha*-*-*"] } then {
gdb_test "info float" "f0.*" "info float"
@@ -19,7 +19,7 @@ if ![supports_reverse] {
# Test aarch64 instruction recording.
-if {![istarget "aarch64*-*-*"]} then {
+if {![is_aarch64_target]} then {
verbose "Skipping aarch64 instruction recording tests."
return
}
@@ -2308,6 +2308,16 @@ gdb_caching_proc is_aarch32_target {
return 1
}
+# Return 1 if this target is an aarch64, either lp64 or ilp32.
+
+proc is_aarch64_target {} {
+ if { ![istarget "aarch64*-*-*"] } {
+ return 0
+ }
+
+ return [expr ![is_aarch32_target]]
+}
+
# Return 1 if displaced stepping is supported on target, otherwise, return 0.
proc support_displaced_stepping {} {