diff mbox

[24/24] Don't set gdb,noinferiorio on gdbserver boards

Message ID 1429639711-16459-25-git-send-email-palves@redhat.com
State New, archived
Headers

Commit Message

Pedro Alves April 21, 2015, 6:08 p.m. UTC 
  As all tests that check gdb,noinferiorio have been adjusted to expect
inferior output with "-i $inferior_spawn_id", we can remove this now,
and thus enable those tests against gdbserver.

gdb/testsuite/ChangeLog:
2015-04-21  Pedro Alves  <palves@redhat.com>

	* boards/gdbserver-base.exp: Don't set gdb,noinferiorio.
---
 gdb/testsuite/boards/gdbserver-base.exp | 3 ---
 1 file changed, 3 deletions(-)

Comments

Yao Qi April 23, 2015, 3:08 p.m. UTC | #1 
Pedro Alves <palves@redhat.com> writes:

> As all tests that check gdb,noinferiorio have been adjusted to expect
> inferior output with "-i $inferior_spawn_id", we can remove this now,
> and thus enable those tests against gdbserver.

We can also remove noinferiorio from testsuite/README.
Pedro Alves April 23, 2015, 3:24 p.m. UTC | #2 
On 04/23/2015 04:08 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> As all tests that check gdb,noinferiorio have been adjusted to expect
>> inferior output with "-i $inferior_spawn_id", we can remove this now,
>> and thus enable those tests against gdbserver.
> 
> We can also remove noinferiorio from testsuite/README.

That actually should stay.  The checks for noinferiorio in the testsuite
will still exist and we must continue to make sure that new tests that rely
on inferior i/o are skipped if noinferiorio is set, and avoid relying on
inferior i/o if not really necessary.  There are non-gdbserver setups that
neither forward inferior i/o through gdb, nor through ssh (that is, through
a separate $inferior_spawn_id channel), e.g., boards that test embedded stubs
that don't do semihosting.

Thanks,
Pedro Alves
Yao Qi April 24, 2015, 9:19 a.m. UTC | #3 
Pedro Alves <palves@redhat.com> writes:

> That actually should stay.  The checks for noinferiorio in the testsuite
> will still exist and we must continue to make sure that new tests that rely
> on inferior i/o are skipped if noinferiorio is set, and avoid relying on
> inferior i/o if not really necessary.  There are non-gdbserver setups that
> neither forward inferior i/o through gdb, nor through ssh (that is, through
> a separate $inferior_spawn_id channel), e.g., boards that test embedded stubs
> that don't do semihosting.

Ah, you are right.  My brain was in a mess yesterday afternoon, sorry
about that.
diff mbox

Patch

diff --git a/gdb/testsuite/boards/gdbserver-base.exp b/gdb/testsuite/boards/gdbserver-base.exp
index c77dc6e..ec24d5a 100644
--- a/gdb/testsuite/boards/gdbserver-base.exp
+++ b/gdb/testsuite/boards/gdbserver-base.exp
@@ -24,9 +24,6 @@  set_board_info compiler "[find_gcc]"
 # Test the copy of gdbserver in the build directory.
 set_board_info gdb_server_prog "../gdbserver/gdbserver"
 
-# Can't do input (or output) in the current gdbserver.
-set_board_info gdb,noinferiorio 1
-
 # gdbserver does not intercept target file operations and perform them
 # on the host.
 set_board_info gdb,nofileio 1