[03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver

  Currently, against gdbserver, interrupt.exp occasionaly fails like
this:

 ERROR: Process no longer exists
 UNRESOLVED: gdb.base/interrupt.exp: send end of file

The problem is that we see gdbserver exiting before we match gdb's
output:

 expect: does "\r\n\r\nChild exited with status 0\r\nGDBserver exiting\r\n" (spawn_id exp8) match regular expression "end of file"? Gate "end of file"? gate=no
 expect: read eof
 expect: set expect_out(spawn_id) "exp8"
 expect: set expect_out(buffer) "\r\n\r\nChild exited with status 0\r\nGDBserver exiting\r\n"

Fix this by removing $inferior_spawn_id from the set of spawn ids
expect is watching as soon as we see the "end of file" string out of
the inferior spawn id, using an indirect spawn id list.

Tested on x86-64 Fedora 20, native and gdbserver (both target remote
and extended-remote).

gdb/testsuite/ChangeLog:
2015-04-21  Pedro Alves  <palves@redhat.com>

	* gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file.  Use
	an indirect spawn id list holding $inferior_spawn_id instead of
	$inferior_spawn_id directly.  On "of of file", remove
	$inferior_spawn_id from the indirect list.
---
 gdb/testsuite/gdb.base/interrupt.exp | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
  

Pedro Alves <palves@redhat.com> writes:

> Fix this by removing $inferior_spawn_id from the set of spawn ids
> expect is watching as soon as we see the "end of file" string out of
> the inferior spawn id, using an indirect spawn id list.
>

Yeah, it is clever to use indirect spawn ids here...

> Tested on x86-64 Fedora 20, native and gdbserver (both target remote
> and extended-remote).
>
> gdb/testsuite/ChangeLog:
> 2015-04-21  Pedro Alves  <palves@redhat.com>
>
> 	* gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file.  Use

The first sentence can be removed, it is in 02/24.

> 	an indirect spawn id list holding $inferior_spawn_id instead of
> 	$inferior_spawn_id directly.  On "of of file", remove

On "end of file".

> 	$inferior_spawn_id from the indirect list.

Patch is good to me.
  

On 04/23/2015 03:28 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> Fix this by removing $inferior_spawn_id from the set of spawn ids
>> expect is watching as soon as we see the "end of file" string out of
>> the inferior spawn id, using an indirect spawn id list.
>>
> 
> Yeah, it is clever to use indirect spawn ids here...
> 
>> Tested on x86-64 Fedora 20, native and gdbserver (both target remote
>> and extended-remote).
>>
>> gdb/testsuite/ChangeLog:
>> 2015-04-21  Pedro Alves  <palves@redhat.com>
>>
>> 	* gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file.  Use
> 
> The first sentence can be removed, it is in 02/24.
> 
>> 	an indirect spawn id list holding $inferior_spawn_id instead of
>> 	$inferior_spawn_id directly.  On "of of file", remove
> 
> On "end of file".
> 
>> 	$inferior_spawn_id from the indirect list.
> 
> Patch is good to me.

Thanks Yao, I fixed ChangeLog and went ahead and pushed in
patches 1-3, in order to plug the race in the buildbots.

Thanks,
Pedro Alves