Patchwork [OB] Remove duplicated xmalloc in update_dprintf_command_list

login
register
mail settings
Submitter Gabriel Krisman Bertazi
Date April 19, 2015, 11:11 p.m.
Message ID <1429485106-10583-1-git-send-email-gabriel@krisman.be>
Download mbox | patch
Permalink /patch/6325/
State New
Headers show

Comments

Gabriel Krisman Bertazi - April 19, 2015, 11:11 p.m.
Hello,

Just pushed this under the obvious rule.

Code in update_dprintf_command_list performed a duplicated memory
allocation which caused an obvious memory leak.  This removes the
duplication.

gdb/
2015-04-19  Gabriel Krisman Bertazi  <gabriel@krisman.be>

	* breakpoint.c (update_dprintf_command_list): Remove duplicated
	xmalloc.
---
 gdb/ChangeLog    | 5 +++++
 gdb/breakpoint.c | 1 -
 2 files changed, 5 insertions(+), 1 deletion(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4bca7d6..f878a1a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2015-04-19  Gabriel Krisman Bertazi  <gabriel@krisman.be>
+
+	* breakpoint.c (update_dprintf_command_list): Remove duplicated
+	xmalloc.
+
 2015-04-20  Thomas Schwinge  <thomas@codesourcery.com>
 
 	* reply_mig_hack.awk: Robustify parsing.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 31869f1..a3531a0 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -9057,7 +9057,6 @@  update_dprintf_command_list (struct breakpoint *b)
     struct command_line *printf_cmd_line
       = xmalloc (sizeof (struct command_line));
 
-    printf_cmd_line = xmalloc (sizeof (struct command_line));
     printf_cmd_line->control_type = simple_control;
     printf_cmd_line->body_count = 0;
     printf_cmd_line->body_list = NULL;