Patchwork [v2] gdbserver: fix uClibc build whithout MMU.

login
register
mail settings
Submitter Romain Naour
Date April 14, 2015, 9:07 p.m.
Message ID <1429045654-6479-1-git-send-email-romain.naour@openwide.fr>
Download mbox | patch
Permalink /patch/6219/
State New
Headers show

Comments

Romain Naour - April 14, 2015, 9:07 p.m.
Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
must be retrieved from current_thread.

The change has not been made in the function linux_read_offsets().

Fixes:
http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v2: add a ChangleLog entry
    fix commit subject
    rebase on master
---
 gdb/gdbserver/ChangeLog   | 4 ++++
 gdb/gdbserver/linux-low.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
Yao Qi - April 15, 2015, 2:47 p.m.
Romain Naour <romain.naour@openwide.fr> writes:

> Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
> must be retrieved from current_thread.
>
> The change has not been made in the function linux_read_offsets().
>
> Fixes:
> http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Hi Romain,
Thanks for updating the patch.

Before I push your commit in, a question to GDB maintainers, looks
Romain Naour doesn't have FSF copy right assignment, but this patch is
very simple, so IIUC, we can push it in without Romain's copy right
assignment record.
Joel Brobecker - April 15, 2015, 3:21 p.m.
> Hi Romain,
> Thanks for updating the patch.
> 
> Before I push your commit in, a question to GDB maintainers, looks
> Romain Naour doesn't have FSF copy right assignment, but this patch is
> very simple, so IIUC, we can push it in without Romain's copy right
> assignment record.

That's correct. You can push it using the "tiny patch" annotation
in the ChangeLog. See:
http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant
Yao Qi - April 15, 2015, 4:02 p.m.
Joel Brobecker <brobecker@adacore.com> writes:

> That's correct. You can push it using the "tiny patch" annotation
> in the ChangeLog. See:
> http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant

Hi Joel,
Thanks for the explanation.  Patch is pushed in with "tiny patch" annotation.

Patch

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 332a516..cf3b998 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@ 
+2015-04-14  Romain Naour <romain.naour@openwide.fr>
+
+	* linux-low.c (linux_read_offsets): Remove get_thread_lwp.
+
 2015-04-09  Gary Benson <gbenson@redhat.com>
 
 	* hostio-errno.c (errno_to_fileio_error): Remove function.
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 6dd9224..a7f8446 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -5209,7 +5209,7 @@  static int
 linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
 {
   unsigned long text, text_end, data;
-  int pid = lwpid_of (get_thread_lwp (current_thread));
+  int pid = lwpid_of (current_thread);
 
   errno = 0;