From patchwork Tue Apr 7 09:51:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 6038 Received: (qmail 4569 invoked by alias); 7 Apr 2015 09:51:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 4557 invoked by uid 89); 7 Apr 2015 09:51:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Apr 2015 09:51:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t379pqoC006307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Apr 2015 05:51:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t379poNs019562; Tue, 7 Apr 2015 05:51:51 -0400 Message-ID: <5523A8B6.9060602@redhat.com> Date: Tue, 07 Apr 2015 10:51:50 +0100 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 12/17] Implement all-stop on top of a target running non-stop mode References: <1427926454-16431-1-git-send-email-palves@redhat.com> <1427926454-16431-13-git-send-email-palves@redhat.com> <83fv8ir302.fsf@gnu.org> In-Reply-To: <83fv8ir302.fsf@gnu.org> On 04/02/2015 03:58 PM, Eli Zaretskii wrote: >> From: Pedro Alves >> Date: Wed, 1 Apr 2015 23:14:09 +0100 >> >> +@kindex maint set target-non-stop @var{mode} [on|off|auto] >> +@kindex maint show target-non-stop >> +@item maint set target-non-stop >> +@itemx maint show target-non-stop >> +This controls whether @value{GDBN} targets always operate in non-mode > ^^^^^^^^ > "non-stop mode", I guess. Whoops. Yes, fixed. > >> +even if @code{set non-stop} is @code{off} (@pxref{Non-Stop Mode}). >> +This default is @code{auto}, meaning this is enabled if available; but > ^^^^ > "The" Fixed. > >> +this can be changed to more easily debug problems. > > I find the last part (after the semi-colon) confusing and not really > adding any important information. Perhaps consider dropping it. Dropped. > > What about NEWS? How about this? gdb/ChangeLog: 2015-04-07 Pedro Alves * NEWS: Mention "maint set/show target-non-stop". (...) gdb/doc/ChangeLog: 2015-04-07 Pedro Alves * gdb.texinfo (Maintenance Commands): Document "maint set/show target-non-stop". diff --git c/gdb/NEWS w/gdb/NEWS index cd7c2b3..1526528 100644 --- c/gdb/NEWS +++ w/gdb/NEWS @@ -41,6 +41,12 @@ maint print symbol-cache-statistics maint flush-symbol-cache Flush the contents of the symbol cache. +maint set target-non-stop (on|off|auto) +maint show target-non-stop + Control whether GDB targets always operate in non-stop mode even if + "set non-stop" is "off". The default is "auto", meaning this is + enabled if supported by the target. + record btrace bts record bts Start branch trace recording using Branch Trace Store (BTS) format. diff --git c/gdb/doc/gdb.texinfo w/gdb/doc/gdb.texinfo index c6e9b9b..6b7ba98 100644 --- c/gdb/doc/gdb.texinfo +++ w/gdb/doc/gdb.texinfo @@ -34103,6 +34103,29 @@ asynchronous mode (@pxref{Background Execution}). Normally the default is asynchronous, if it is available; but this can be changed to more easily debug problems occurring only in synchronous mode. +@kindex maint set target-non-stop @var{mode} [on|off|auto] +@kindex maint show target-non-stop +@item maint set target-non-stop +@itemx maint show target-non-stop +This controls whether @value{GDBN} targets always operate in non-stop +mode even if @code{set non-stop} is @code{off} (@pxref{Non-Stop +Mode}). The default is @code{auto}, meaning this is enabled if +supported by the target. + +@table @code +@item maint set target-non-stop auto +This is the default mode. @value{GDBN} controls the target in +non-stop mode if the target supports it. + +@item maint set target-non-stop on +@value{GDBN} controls the target in non-stop mode even if the target +does not indicate support. + +@item maint set target-non-stop off +@value{GDBN} does not control the target in non-stop mode even if the +target supports it. +@end table + @kindex maint set per-command @kindex maint show per-command @item maint set per-command