Patchwork [v2,3/9] Fix excess parentheses in Guile extension examples.

login
register
mail settings
Submitter Andy Wingo
Date April 17, 2014, 10:46 a.m.
Message ID <1397731588-23750-4-git-send-email-wingo@igalia.com>
Download mbox | patch
Permalink /patch/598/
State New
Headers show

Comments

Andy Wingo - April 17, 2014, 10:46 a.m.
gdb/doc/ChangeLog:
	* guile.texi (Writing a Guile Pretty-Printer)
	(Guile Types Module): Fix excess parentheses in use-modules
	forms.
---
 gdb/doc/ChangeLog  |  6 ++++++
 gdb/doc/guile.texi | 10 +++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)
Doug Evans - April 26, 2014, 11:44 p.m.
Andy Wingo <wingo@igalia.com> writes:

> gdb/doc/ChangeLog:
> 	* guile.texi (Writing a Guile Pretty-Printer)
> 	(Guile Types Module): Fix excess parentheses in use-modules
> 	forms.

LGTM
Doug Evans - May 27, 2014, 7:35 a.m.
Doug Evans <xdje42@gmail.com> writes:

> Andy Wingo <wingo@igalia.com> writes:
>
>> gdb/doc/ChangeLog:
>> 	* guile.texi (Writing a Guile Pretty-Printer)
>> 	(Guile Types Module): Fix excess parentheses in use-modules
>> 	forms.
>
> LGTM

Committed.

Patch

diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 4b36f2c..87f4e06 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,9 @@ 
+2014-04-17  Andy Wingo  <wingo@igalia.com>
+
+	* guile.texi (Writing a Guile Pretty-Printer)
+	(Guile Types Module): Fix excess parentheses in use-modules
+	forms.
+
 2014-03-31  Doug Evans  <dje@google.com>
 
 	* gdb.texinfo (Symbols): Document set/show print symbol-loading.
diff --git a/gdb/doc/guile.texi b/gdb/doc/guile.texi
index 56d817e..7d4d098 100644
--- a/gdb/doc/guile.texi
+++ b/gdb/doc/guile.texi
@@ -1600,7 +1600,7 @@  To continue the @code{my::string} example,
 this code might appear in @code{(my-project my-library v1)}:
 
 @smallexample
-(use-modules ((gdb)))
+(use-modules (gdb))
 (define (register-printers objfile)
   (append-objfile-pretty-printer!
    (make-pretty-printer "my-string" str-lookup-function)))
@@ -1610,7 +1610,7 @@  this code might appear in @code{(my-project my-library v1)}:
 And then the corresponding contents of the auto-load file would be:
 
 @smallexample
-(use-modules ((gdb) (my-project my-library v1)))
+(use-modules (gdb) (my-project my-library v1))
 (register-printers (current-objfile))
 @end smallexample
 
@@ -1661,7 +1661,7 @@  This example doesn't need a lookup function, that is handled by the
 the object that handles the lookup.
 
 @smallexample
-(use-modules ((gdb printing)))
+(use-modules (gdb printing))
 
 (define (build-pretty-printer)
   (let ((pp (make-pretty-printer-collection "my-library")))
@@ -1673,7 +1673,7 @@  the object that handles the lookup.
 And here is the autoload support:
 
 @smallexample
-(use-modules ((gdb) (my-library)))
+(use-modules (gdb) (my-library))
 (append-objfile-pretty-printer! (current-objfile) (build-pretty-printer))
 @end smallexample
 
@@ -3264,7 +3264,7 @@  Then in gdb:
 
 @smallexample
 (gdb) start
-(gdb) guile (use-modules ((gdb) (gdb types)))
+(gdb) guile (use-modules (gdb) (gdb types))
 (gdb) guile (define foo-ref (parse-and-eval "foo_ref"))
 (gdb) guile (get-basic-type (value-type foo-ref))
 int