Patchwork [v2,1/9] Allow GDB to build against unreleased Guile 2.2

login
register
mail settings
Submitter Andy Wingo
Date April 17, 2014, 10:46 a.m.
Message ID <1397731588-23750-2-git-send-email-wingo@igalia.com>
Download mbox | patch
Permalink /patch/596/
State New
Headers show

Comments

Andy Wingo - April 17, 2014, 10:46 a.m.
gdb/ChangeLog:
	* configure.ac (try_guile_versions): Allow building with Guile
	2.2.
	* configure: Regenerate.
---
 gdb/ChangeLog    | 6 ++++++
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)
Doug Evans - April 26, 2014, 11:30 p.m.
Andy Wingo <wingo@igalia.com> writes:

> gdb/ChangeLog:
> 	* configure.ac (try_guile_versions): Allow building with Guile
> 	2.2.
> 	* configure: Regenerate.

LGTM
Doug Evans - May 10, 2014, 6:19 p.m.
On Sat, Apr 26, 2014 at 4:30 PM, Doug Evans <xdje42@gmail.com> wrote:
> Andy Wingo <wingo@igalia.com> writes:
>
>> gdb/ChangeLog:
>>       * configure.ac (try_guile_versions): Allow building with Guile
>>       2.2.
>>       * configure: Regenerate.
>
> LGTM

Hi.  I'm hoping we can get this patch series checked in this week (7.8
will be branched in a few weeks and I want to make sure this is in).

Let me know if you want me to check these in for you.
I'm going to go over the patches again, and make sure you're not
waiting on me for anything.

Thanks!
Doug Evans - May 27, 2014, 7:32 a.m.
Doug Evans <xdje42@gmail.com> writes:

> On Sat, Apr 26, 2014 at 4:30 PM, Doug Evans <xdje42@gmail.com> wrote:
>> Andy Wingo <wingo@igalia.com> writes:
>>
>>> gdb/ChangeLog:
>>>       * configure.ac (try_guile_versions): Allow building with Guile
>>>       2.2.
>>>       * configure: Regenerate.
>>
>> LGTM
>
> Hi.  I'm hoping we can get this patch series checked in this week (7.8
> will be branched in a few weeks and I want to make sure this is in).
>
> Let me know if you want me to check these in for you.
> I'm going to go over the patches again, and make sure you're not
> waiting on me for anything.
>
> Thanks!

Hi.
I went ahead and checked in most of the series.
More details with each patch.

This patch, the configure changes, is committed.

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e8cdd14..ec8f7b2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@ 
+2014-04-17  Andy Wingo  <wingo@igalia.com>
+
+	* configure.ac (try_guile_versions): Allow building with Guile
+	2.2.
+	* configure: Regenerate.
+
 2014-04-17  Yao Qi  <yao@codesourcery.com>
 
 	* gdbtypes.h: Update comments to link to types and macros'
diff --git a/gdb/configure b/gdb/configure
index fd61bb5..d7e5cef 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -8750,7 +8750,7 @@  fi
 
 
 
-try_guile_versions="guile-2.0"
+try_guile_versions="guile-2.2 guile-2.0"
 have_libguile=no
 case "${with_guile}" in
 no)
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 494d711..ff84a2e 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1154,7 +1154,7 @@  AC_MSG_RESULT([$with_guile])
 dnl We check guile with pkg-config.
 AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing)
 
-try_guile_versions="guile-2.0"
+try_guile_versions="guile-2.2 guile-2.0"
 have_libguile=no
 case "${with_guile}" in
 no)