From patchwork Mon Feb 9 23:20:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 5008 Received: (qmail 31322 invoked by alias); 9 Feb 2015 23:45:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31291 invoked by uid 89); 9 Feb 2015 23:45:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Feb 2015 23:45:26 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19NKubH017083 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 18:20:56 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t19NKkuV026307 for ; Mon, 9 Feb 2015 18:20:55 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 06/36] record-btrace.c: Remove redefinitions Date: Mon, 9 Feb 2015 23:20:16 +0000 Message-Id: <1423524046-20605-7-git-send-email-palves@redhat.com> In-Reply-To: <1423524046-20605-1-git-send-email-palves@redhat.com> References: <1423524046-20605-1-git-send-email-palves@redhat.com> MIME-Version: 1.0 The set_record_btrace_cmdlist and show_record_btrace_cmdlist objects are declared twice in the file, seemingly a simply copy/paste oversight. In C, the first time counts as forward declaration, but in C++, they are all definitions. That results in: src/gdb/record-btrace.c:80:33: error: redefinition of ‘cmd_list_element* set_record_btrace_cmdlist’ src/gdb/record-btrace.c:61:33: error: ‘cmd_list_element* set_record_btrace_cmdlist’ previously declared here src/gdb/record-btrace.c:81:33: error: redefinition of ‘cmd_list_element* show_record_btrace_cmdlist’ src/gdb/record-btrace.c:62:33: error: ‘cmd_list_element* show_record_btrace_cmdlist’ previously declared here gdb/ChangeLog: 2015-02-09 Pedro Alves * record-btrace.c (set_record_btrace_cmdlist) (show_record_btrace_cmdlist): Remove redefinitions. --- gdb/record-btrace.c | 4 ---- 1 file changed, 4 deletions(-) --- gdb/record-btrace.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 102e0eb..35c775a 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -76,10 +76,6 @@ static struct btrace_config record_btrace_conf; /* Command list for "record btrace". */ static struct cmd_list_element *record_btrace_cmdlist; -/* Command lists for "set/show record btrace". */ -static struct cmd_list_element *set_record_btrace_cmdlist; -static struct cmd_list_element *show_record_btrace_cmdlist; - /* Command lists for "set/show record btrace bts". */ static struct cmd_list_element *set_record_btrace_bts_cmdlist; static struct cmd_list_element *show_record_btrace_bts_cmdlist;