Patchwork two agent expression nits (one line each)

login
register
mail settings
Submitter David Taylor
Date Feb. 3, 2015, 9:57 p.m.
Message ID <18513.1423000644@usendtaylorx2l>
Download mbox | patch
Permalink /patch/4905/
State New
Headers show

Comments

David Taylor - Feb. 3, 2015, 9:57 p.m.
Joel Brobecker <brobecker@adacore.com> wrote:

> Hi David,

[...]

> Since you understand what should be done, would you mind sending
> a patch in for Stan to review?
> 
> -- 
> Joel

Joel,

Sorry for the delay.  Here's the patch.  Also, I haven't forgotten that
I owe you an updated patch for bad structure offsets.  And I have some
others in the queue to finish up and post, as well.

Stan,

Here's the ChangeLog entries:

gdb:

2015-02-03  David Taylor  <dtaylor@emc.com>

	* common/ax.def (setv): Fix consumed entry in setv DEFOP.

gdb/doc:

2015-02-03  David Taylor  <dtaylor@emc.com>

	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.


and patch, as requested by Joel:
Joel Brobecker - Feb. 11, 2015, 7:48 a.m.
Hi Stan,

Would you mind reviewing this patch for us, please? If we are going
to change a spec, we might as well do it earlier than later and so
this could be a good candidate for the 7.9 branch.

Thanks!

On Tue, Feb 03, 2015 at 04:57:24PM -0500, David Taylor wrote:
> Joel Brobecker <brobecker@adacore.com> wrote:
> 
> > Hi David,
> 
> [...]
> 
> > Since you understand what should be done, would you mind sending
> > a patch in for Stan to review?
> > 
> > -- 
> > Joel
> 
> Joel,
> 
> Sorry for the delay.  Here's the patch.  Also, I haven't forgotten that
> I owe you an updated patch for bad structure offsets.  And I have some
> others in the queue to finish up and post, as well.
> 
> Stan,
> 
> Here's the ChangeLog entries:
> 
> gdb:
> 
> 2015-02-03  David Taylor  <dtaylor@emc.com>
> 
> 	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> 
> gdb/doc:
> 
> 2015-02-03  David Taylor  <dtaylor@emc.com>
> 
> 	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
> 
> 
> and patch, as requested by Joel:
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 351ccdd..0118d7d 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-02-03  David Taylor  <dtaylor@emc.com>
> +
> +	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> +
>  2015-02-02  Joel Brobecker  <brobecker@adacore.com>
>  
>  	* dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker.
> diff --git a/gdb/common/ax.def b/gdb/common/ax.def
> index 8b27725..27c97cc 100644
> --- a/gdb/common/ax.def
> +++ b/gdb/common/ax.def
> @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29)
>  DEFOP (zero_ext, 1, 0, 1, 1, 0x2a)
>  DEFOP (swap, 0, 0, 2, 2, 0x2b)
>  DEFOP (getv, 2, 0, 0, 1, 0x2c)
> -DEFOP (setv, 2, 0, 0, 1, 0x2d)
> +DEFOP (setv, 2, 0, 1, 1, 0x2d)
>  DEFOP (tracev, 2, 0, 0, 1, 0x2e)
>  DEFOP (tracenz, 0, 0, 2, 0, 0x2f)
>  DEFOP (trace16, 2, 0, 1, 1, 0x30)
> diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
> index 9c12d9a..34fee48 100644
> --- a/gdb/doc/ChangeLog
> +++ b/gdb/doc/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-02-03  David Taylor  <dtaylor@emc.com>
> +
> +	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
> +
>  2015-01-31  Gary Benson <gbenson@redhat.com>
>  	    Doug Evans  <dje@google.com>
>  
> diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi
> index 788de1c..297cd5e 100644
> --- a/gdb/doc/agentexpr.texi
> +++ b/gdb/doc/agentexpr.texi
> @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a
>  16-bit on an unaligned address raises an exception, you should fetch the
>  register number one byte at a time.
>  
> -@item @code{setv} (0x2d) @var{n}: @result{} @var{v}
> +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v}
>  Set trace state variable number @var{n} to the value found on the top
>  of the stack.  The stack is unchanged, so that the value is readily
>  available if the assignment is part of a larger expression.  The
Stan Shebs - Feb. 11, 2015, 5:28 p.m.
On 2/3/15 1:57 PM, David Taylor wrote:
> Joel Brobecker <brobecker@adacore.com> wrote:
> 
>> Hi David,
> 
> [...]
> 
>> Since you understand what should be done, would you mind sending
>> a patch in for Stan to review?
>>
>> -- 
>> Joel
> 
> Joel,
> 
> Sorry for the delay.  Here's the patch.  Also, I haven't forgotten that
> I owe you an updated patch for bad structure offsets.  And I have some
> others in the queue to finish up and post, as well.

These changes are both fine as posted, thanks!

And I agree that they would be good candidates for 7.9 branch as well.

Stan

> 
> Stan,
> 
> Here's the ChangeLog entries:
> 
> gdb:
> 
> 2015-02-03  David Taylor  <dtaylor@emc.com>
> 
> 	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> 
> gdb/doc:
> 
> 2015-02-03  David Taylor  <dtaylor@emc.com>
> 
> 	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
> 
> 
> and patch, as requested by Joel:
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 351ccdd..0118d7d 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-02-03  David Taylor  <dtaylor@emc.com>
> +
> +	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> +
>  2015-02-02  Joel Brobecker  <brobecker@adacore.com>
>  
>  	* dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker.
> diff --git a/gdb/common/ax.def b/gdb/common/ax.def
> index 8b27725..27c97cc 100644
> --- a/gdb/common/ax.def
> +++ b/gdb/common/ax.def
> @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29)
>  DEFOP (zero_ext, 1, 0, 1, 1, 0x2a)
>  DEFOP (swap, 0, 0, 2, 2, 0x2b)
>  DEFOP (getv, 2, 0, 0, 1, 0x2c)
> -DEFOP (setv, 2, 0, 0, 1, 0x2d)
> +DEFOP (setv, 2, 0, 1, 1, 0x2d)
>  DEFOP (tracev, 2, 0, 0, 1, 0x2e)
>  DEFOP (tracenz, 0, 0, 2, 0, 0x2f)
>  DEFOP (trace16, 2, 0, 1, 1, 0x30)
> diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
> index 9c12d9a..34fee48 100644
> --- a/gdb/doc/ChangeLog
> +++ b/gdb/doc/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-02-03  David Taylor  <dtaylor@emc.com>
> +
> +	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
> +
>  2015-01-31  Gary Benson <gbenson@redhat.com>
>  	    Doug Evans  <dje@google.com>
>  
> diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi
> index 788de1c..297cd5e 100644
> --- a/gdb/doc/agentexpr.texi
> +++ b/gdb/doc/agentexpr.texi
> @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a
>  16-bit on an unaligned address raises an exception, you should fetch the
>  register number one byte at a time.
>  
> -@item @code{setv} (0x2d) @var{n}: @result{} @var{v}
> +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v}
>  Set trace state variable number @var{n} to the value found on the top
>  of the stack.  The stack is unchanged, so that the value is readily
>  available if the assignment is part of a larger expression.  The
>
David Taylor - Feb. 13, 2015, 7:13 p.m.
Stan Shebs <stanshebs@earthlink.net> wrote:

> On 2/3/15 1:57 PM, David Taylor wrote:
> > Joel Brobecker <brobecker@adacore.com> wrote:
> > 
> >> Hi David,
> > 
> > [...]
> > 
> >> Since you understand what should be done, would you mind sending
> >> a patch in for Stan to review?
> >>
> >> -- 
> >> Joel
> > 
> > Joel,
> > 
> > Sorry for the delay.  Here's the patch.  Also, I haven't forgotten that
> > I owe you an updated patch for bad structure offsets.  And I have some
> > others in the queue to finish up and post, as well.
> 
> These changes are both fine as posted, thanks!
> 
> And I agree that they would be good candidates for 7.9 branch as well.
> 
> Stan

Will someone please commit these for me (as I do not have commit privs)?

Thanks.

> > 
> > Stan,
> > 
> > Here's the ChangeLog entries:
> > 
> > gdb:
> > 
> > 2015-02-03  David Taylor  <dtaylor@emc.com>
> > 
> > 	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> > 
> > gdb/doc:
> > 
> > 2015-02-03  David Taylor  <dtaylor@emc.com>
> > 
> > 	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
> > 
> > 
> > and patch, as requested by Joel:
> > 
> > diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> > index 351ccdd..0118d7d 100644
> > --- a/gdb/ChangeLog
> > +++ b/gdb/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2015-02-03  David Taylor  <dtaylor@emc.com>
> > +
> > +	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> > +
> >  2015-02-02  Joel Brobecker  <brobecker@adacore.com>
> >  
> >  	* dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker.
> > diff --git a/gdb/common/ax.def b/gdb/common/ax.def
> > index 8b27725..27c97cc 100644
> > --- a/gdb/common/ax.def
> > +++ b/gdb/common/ax.def
> > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29)
> >  DEFOP (zero_ext, 1, 0, 1, 1, 0x2a)
> >  DEFOP (swap, 0, 0, 2, 2, 0x2b)
> >  DEFOP (getv, 2, 0, 0, 1, 0x2c)
> > -DEFOP (setv, 2, 0, 0, 1, 0x2d)
> > +DEFOP (setv, 2, 0, 1, 1, 0x2d)
> >  DEFOP (tracev, 2, 0, 0, 1, 0x2e)
> >  DEFOP (tracenz, 0, 0, 2, 0, 0x2f)
> >  DEFOP (trace16, 2, 0, 1, 1, 0x30)
> > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
> > index 9c12d9a..34fee48 100644
> > --- a/gdb/doc/ChangeLog
> > +++ b/gdb/doc/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2015-02-03  David Taylor  <dtaylor@emc.com>
> > +
> > +	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
> > +
> >  2015-01-31  Gary Benson <gbenson@redhat.com>
> >  	    Doug Evans  <dje@google.com>
> >  
> > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi
> > index 788de1c..297cd5e 100644
> > --- a/gdb/doc/agentexpr.texi
> > +++ b/gdb/doc/agentexpr.texi
> > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a
> >  16-bit on an unaligned address raises an exception, you should fetch the
> >  register number one byte at a time.
> >  
> > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v}
> > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v}
> >  Set trace state variable number @var{n} to the value found on the top
> >  of the stack.  The stack is unchanged, so that the value is readily
> >  available if the assignment is part of a larger expression.  The
> > 
>
Joel Brobecker - Feb. 20, 2015, 3:05 a.m.
> > These changes are both fine as posted, thanks!
> > 
> > And I agree that they would be good candidates for 7.9 branch as well.
> 
> Will someone please commit these for me (as I do not have commit privs)?

I have now pushed them to both master and gdb-7.9-branch, after having
re-tested them on both branches.

For the future, it would be helpful if you sent the whole commit,
rather than just a ChangeLog, because I had to write the commit's
revision log, which wasn't completely obvious since I didn't grasp
everything. Fortunately, I was able to cook something up from your
initial message (which I had to fish back) and your discussions
with Stan.

Thank you nonetheless for the fixes, and for your patience!

> > > 2015-02-03  David Taylor  <dtaylor@emc.com>
> > > 
> > > 	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
> > > 
> > > gdb/doc:
> > > 
> > > 2015-02-03  David Taylor  <dtaylor@emc.com>
> > > 
> > > 	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 351ccdd..0118d7d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2015-02-03  David Taylor  <dtaylor@emc.com>
+
+	* common/ax.def (setv): Fix consumed entry in setv DEFOP.
+
 2015-02-02  Joel Brobecker  <brobecker@adacore.com>
 
 	* dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker.
diff --git a/gdb/common/ax.def b/gdb/common/ax.def
index 8b27725..27c97cc 100644
--- a/gdb/common/ax.def
+++ b/gdb/common/ax.def
@@ -83,7 +83,7 @@  DEFOP (pop, 0, 0, 1, 0, 0x29)
 DEFOP (zero_ext, 1, 0, 1, 1, 0x2a)
 DEFOP (swap, 0, 0, 2, 2, 0x2b)
 DEFOP (getv, 2, 0, 0, 1, 0x2c)
-DEFOP (setv, 2, 0, 0, 1, 0x2d)
+DEFOP (setv, 2, 0, 1, 1, 0x2d)
 DEFOP (tracev, 2, 0, 0, 1, 0x2e)
 DEFOP (tracenz, 0, 0, 2, 0, 0x2f)
 DEFOP (trace16, 2, 0, 1, 1, 0x30)
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 9c12d9a..34fee48 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,7 @@ 
+2015-02-03  David Taylor  <dtaylor@emc.com>
+
+	* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
+
 2015-01-31  Gary Benson <gbenson@redhat.com>
 	    Doug Evans  <dje@google.com>
 
diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi
index 788de1c..297cd5e 100644
--- a/gdb/doc/agentexpr.texi
+++ b/gdb/doc/agentexpr.texi
@@ -461,7 +461,7 @@  alignment within the bytecode stream; thus, on machines where fetching a
 16-bit on an unaligned address raises an exception, you should fetch the
 register number one byte at a time.
 
-@item @code{setv} (0x2d) @var{n}: @result{} @var{v}
+@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v}
 Set trace state variable number @var{n} to the value found on the top
 of the stack.  The stack is unchanged, so that the value is readily
 available if the assignment is part of a larger expression.  The