Message ID | 1397060028-18158-2-git-send-email-wingo@igalia.com |
---|---|
State | Changes Requested, archived |
Headers |
Return-Path: <x14314964@homiemail-mx21.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id 02ACC36005B for <siddhesh@wilcox.dreamhost.com>; Wed, 9 Apr 2014 09:14:13 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id B3BBE10CD549; Wed, 9 Apr 2014 09:14:12 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 8D35210969B4 for <gdb@patchwork.siddhesh.in>; Wed, 9 Apr 2014 09:14:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=TOtqwuhFchSvVx9tpT53iB+nmnCnkK/ PpT7RRcp/o52ZiMW2tOCGkwINOHBwYkAZPPwKfhdtFSiwdrDxr08rlgvrX+/Yfch jSh8h7cEDvjKxP1nVHs8XnvFvbYZeXpLEOyLrjG/N65sqjtuN1CUqiXYwl3VMU1+ /Sc/RfylXAPk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; s=default; bh=whkhGrxmm9e+4fk3cFhc78l2LQ0=; b=L+nBI n5I1APVB1Bw0iUOszGG6B61IfR4rWMGrj0CUiZNyEhO8Qf4EREqVq42g3/hue9fn Nx4A8cttgohJls98WuZPlY3jrR/riJbwfUCGgulMQLhjzcOmOUOwsu/386Uz51ZI aACQ7KUbQMrNSN5W6CTmWAbpIvfHfa9TK5rL5A= Received: (qmail 5179 invoked by alias); 9 Apr 2014 16:14:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-gdb=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5114 invoked by uid 89); 9 Apr 2014 16:14:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL, BAYES_40, RCVD_IN_DNSWL_NONE, SPF_NEUTRAL autolearn=no version=3.3.2 X-HELO: sasl.smtp.pobox.com Received: from a-pb-sasl-quonix.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Apr 2014 16:14:05 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id E352B11049; Wed, 9 Apr 2014 12:14:03 -0400 (EDT) Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id DC32D11048; Wed, 9 Apr 2014 12:14:03 -0400 (EDT) Received: from localhost.localdomain (unknown [88.160.190.192]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 58F1511046; Wed, 9 Apr 2014 12:14:01 -0400 (EDT) From: Andy Wingo <wingo@igalia.com> To: gdb-patches@sourceware.org Cc: Andy Wingo <wingo@igalia.com> Subject: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2 Date: Wed, 9 Apr 2014 18:13:40 +0200 Message-Id: <1397060028-18158-2-git-send-email-wingo@igalia.com> In-Reply-To: <1397060028-18158-1-git-send-email-wingo@igalia.com> References: <1397060028-18158-1-git-send-email-wingo@igalia.com> X-Pobox-Relay-ID: F732336A-C001-11E3-966B-873F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-DH-Original-To: gdb@patchwork.siddhesh.in |
Commit Message
Andy Wingo
April 9, 2014, 4:13 p.m. UTC
* gdb/configure: * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. --- gdb/configure | 5 +++-- gdb/configure.ac | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)
Comments
Andy Wingo <wingo@igalia.com> writes: > * gdb/configure: > * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. > --- > gdb/configure | 5 +++-- > gdb/configure.ac | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/configure b/gdb/configure > index fd61bb5..307c6c9 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -3,7 +3,7 @@ > # Generated by GNU Autoconf 2.64. > # > # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001, > -# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software > +# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2014 Free Software > # Foundation, Inc. > # > # This configure script is free software; the Free Software Foundation > @@ -8750,7 +8750,8 @@ fi > > > > -try_guile_versions="guile-2.0" > + > +try_guile_versions="guile-2.2 guile-2.0" > have_libguile=no > case "${with_guile}" in > no) > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 494d711..ff84a2e 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -1154,7 +1154,7 @@ AC_MSG_RESULT([$with_guile]) > dnl We check guile with pkg-config. > AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing) > > -try_guile_versions="guile-2.0" > +try_guile_versions="guile-2.2 guile-2.0" > have_libguile=no > case "${with_guile}" in > no) Hi. This is ok with two nits: 1) ChangeLog entries are included in the email as they appear in the file itself (but not as a patch). E.g., for future reference, replace * gdb/configure: * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. with 2014-04-09 Andy Wingo <wingo@igalia.com> * gdb/configure: * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. I realize it can be cumbersome, but it's the convention we have. 2) The change to configure is small, so it's not a big a deal, but, for reference sake, the convention here is to not include changes to machine generated files in patches submitted to the list. Plus I wouldn't expect a change to the Copyright year in configure. --- As I say these are just nits, but they are community rules so I'm obligated to forward them on. btw, this patch is small enough to not require one, and while I wouldn't doubt that you have a copyright assignment for Guile changes :-), do you have one for gdb? I can imagine having a blanket assignment for everything, just checking.
On Sat, Apr 12, 2014 at 9:40 AM, Doug Evans <xdje42@gmail.com> wrote: > This is ok with two nits: > > 1) ChangeLog entries are included in the email as they appear in the file > itself (but not as a patch). E.g., for future reference, replace > > * gdb/configure: > * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. > > with > > 2014-04-09 Andy Wingo <wingo@igalia.com> > > * gdb/configure: > * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. Oops. Make that 2014-04-09 Andy Wingo <wingo@igalia.com> * configure: Regenerate. * configure.ac (try_guile_versions): Allow building with guile 2.2. Paths in ChangeLog files are relative to the location of the ChangeLog file. And convention is to write "Regenerate" for machine generated files. Plus, instead of "replace" I should have probably said "in addition to". Feel free to include whatever git spits out of course, but current community rules require the ChangeLog entry included in the emailed patch as shown above. [There is debate on how to improve this, but I don't think the community has agreed to anything yet.]
Hi, Thanks for the review. I'll post a new patchset shortly incorporating feedback. Sorry for the gaffe with the changelogs. On Sat 12 Apr 2014 18:40, Doug Evans <xdje42@gmail.com> writes: > 2) The change to configure is small, so it's not a big a deal, > but, for reference sake, the convention here is to not include changes > to machine generated files in patches submitted to the list. > Plus I wouldn't expect a change to the Copyright year in configure. I edited the file manually as I don't have autoconf2.64 on my system, hence the copyright year update. I removed the copyright update from the updated patchset, but kept the change to the generated configure file as it's so trivial that I can only imagine autoconf producing exactly those changes. I can repost that patch without that change if you like. > btw, this patch is small enough to not require one, and while I wouldn't > doubt that you have a copyright assignment for Guile changes :-), do you > have one for gdb? I can imagine having a blanket assignment for > everything, just checking. I was agnozing over having to do that when I found to my pleasant surprise that Igalia already has a corporate assignment for GDB, made when Sanjoy Das was doing the custom debug info JIT interface stuff a couple years ago. Hopefully that suffices. Cheers, Andy
diff --git a/gdb/configure b/gdb/configure index fd61bb5..307c6c9 100755 --- a/gdb/configure +++ b/gdb/configure @@ -3,7 +3,7 @@ # Generated by GNU Autoconf 2.64. # # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001, -# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software +# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2014 Free Software # Foundation, Inc. # # This configure script is free software; the Free Software Foundation @@ -8750,7 +8750,8 @@ fi -try_guile_versions="guile-2.0" + +try_guile_versions="guile-2.2 guile-2.0" have_libguile=no case "${with_guile}" in no) diff --git a/gdb/configure.ac b/gdb/configure.ac index 494d711..ff84a2e 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1154,7 +1154,7 @@ AC_MSG_RESULT([$with_guile]) dnl We check guile with pkg-config. AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing) -try_guile_versions="guile-2.0" +try_guile_versions="guile-2.2 guile-2.0" have_libguile=no case "${with_guile}" in no)