From patchwork Thu Feb 13 10:57:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 38025 Received: (qmail 73339 invoked by alias); 13 Feb 2020 10:58:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 73322 invoked by uid 89); 13 Feb 2020 10:58:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=gdbsum, UD:sum, gdb.sum, UD:gdb.sum X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 10:57:59 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9FE38AC92 for ; Thu, 13 Feb 2020 10:57:57 +0000 (UTC) Date: Thu, 13 Feb 2020 11:57:56 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp Message-ID: <20200213105754.GA22520@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, After de-installing gnatmake, I get: ... Running src/gdb/testsuite/gdb.base/gdb-caching-proc.exp ... FAIL: gdb-caching-proc.exp: failed to compile gnat-debug-info test binary ... FAIL: gdb-caching-proc.exp: failed to compile gnat-debug-info test binary ... In gdb.sum, we see these FAILs (each paired with an UNSUPPORTED as well) followed by: ... PASS: gdb-caching-proc.exp: gnat_runtime_has_debug_info consistency ... Fix this by ignoring PASS/FAIL/UNSUPPORTED during testing, such that we have just the consistency PASS/FAIL. Tested on x86_64-linux, with gnatmake installed and de-installed. OK for trunk? Thanks, - Tom [gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp gdb/testsuite/ChangeLog: 2020-02-13 Tom de Vries * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail) (ignore_unsupported): New proc. (test_proc): Temporarily rename pass/fail/ignore to ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages from the tested procs. --- gdb/testsuite/gdb.base/gdb-caching-proc.exp | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gdb/testsuite/gdb.base/gdb-caching-proc.exp b/gdb/testsuite/gdb.base/gdb-caching-proc.exp index b2d71a5e7d..536d7e89c1 100644 --- a/gdb/testsuite/gdb.base/gdb-caching-proc.exp +++ b/gdb/testsuite/gdb.base/gdb-caching-proc.exp @@ -22,12 +22,29 @@ # number of reruns is constant-bounded, and the increase in runtime is bound to # this test-case, and could be disabled on slow targets. +proc ignore_pass { args } { + +} +proc ignore_fail { args } { + +} +proc ignore_unsupported { args } { + +} + # Test gdb_caching_proc NAME proc test_proc { name } { set real_name gdb_real__$name set resultlist [list] + rename pass save_pass + rename fail save_fail + rename unsupported save_unsupported + rename ignore_pass pass + rename ignore_fail fail + rename ignore_unsupported unsupported + set first [$real_name] lappend resultlist $first @@ -44,6 +61,13 @@ proc test_proc { name } { } } + rename pass ignore_pass + rename fail ignore_fail + rename unsupported ignore_unsupported + rename save_pass pass + rename save_fail fail + rename save_unsupported unsupported + if { $racy == 0 } { pass "$name consistency" } else {