Patchwork [pushed,2/2] gdbserver: make aarch64_write_goto_address static

login
register
mail settings
Submitter Simon Marchi
Date Jan. 12, 2020, 4:07 p.m.
Message ID <20200112160754.290232-2-simon.marchi@polymtl.ca>
Download mbox | patch
Permalink /patch/37333/
State New
Headers show

Comments

Simon Marchi - Jan. 12, 2020, 4:07 p.m.
This function is only used in this file, so make it static.  It fixes
this error, when building with -Wmissing-declarations:

  CXX    linux-aarch64-low.o
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-low.c:2642:1: error: no previous declaration for 'void aarch64_write_goto_address(CORE_ADDR, CORE_ADDR, int)' [-Werror=missing-declarations]
 aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~

gdb/gdbserver/ChangeLog:

	* linux-aarch64-low.c (aarch64_write_goto_address): Make static.
---
 gdb/gdbserver/ChangeLog           | 4 ++++
 gdb/gdbserver/linux-aarch64-low.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Patch

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 40a765a3eded..83be63c393e8 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@ 
+2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* linux-aarch64-low.c (aarch64_write_goto_address): Make static.
+
 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h.
diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index c58347d80ce6..961fd5b3cc41 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -2638,7 +2638,7 @@  aarch64_emit_goto (int *offset_p, int *size_p)
 
 /* Implementation of emit_ops method "write_goto_address".  */
 
-void
+static void
 aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size)
 {
   uint32_t insn;