From patchwork Tue Jan 7 11:52:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 37234 Received: (qmail 22261 invoked by alias); 7 Jan 2020 11:52:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 22164 invoked by uid 89); 7 Jan 2020 11:52:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=Screen, H*m:andrew, screen X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2020 11:52:27 +0000 Received: by mail-wm1-f68.google.com with SMTP id d139so14039974wmd.0 for ; Tue, 07 Jan 2020 03:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=CWrGQMEZpbBqHuBS7KdT3KRy9PC4oUN3aweZ/dVP36w=; b=JqhnoUT4yBrEOgtCNxoipqxvVC6smGeqCEEMMfB5Z5AhmIfsodIs4meA83S6TfBL3K e081TSnC9TP0q8zJLuHZYqJ+8MW+DWhL2+yH+EeXoKt+NOfAxKo7fogLY3vsK6jxm/UA HxeKTknb5Rn0mKl67YG7T4N34PlgMs3+SmI+LLPieZVLk8ayP7YT3a1KRYaQsleDK7zM zb6MdbBEhoDfXkqdn061Z2ZrcZB0Kzp4kKgHxFvtd1KBwIoCUv50VU1cl9owfyz23d8p vguRpJbVvuGM7rVPXv58Au9/vpNclooiEhEdJanxUCh0TxXpzT/vGmhqvCAbi6qFIA1g u7bg== Return-Path: Received: from localhost (host86-186-80-236.range86-186.btcentralplus.com. [86.186.80.236]) by smtp.gmail.com with ESMTPSA id i10sm76934060wru.16.2020.01.07.03.52.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Jan 2020 03:52:24 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Tom Tromey , Hannes Domani , Andrew Burgess Subject: [PATCH 1/6] gdb/testsuite/tui: Always dump_screen when asked Date: Tue, 7 Jan 2020 11:52:14 +0000 Message-Id: <46c21f67261de4d1129918af411b068512c0ab16.1578397591.git.andrew.burgess@embecosm.com> In-Reply-To: References: In-Reply-To: References: <874kxrc3ha.fsf@tromey.com> X-IsSubscribed: yes The Term::dump_screen routine currently dumps the screen using calls to 'verbose', this means it will only dump the screen when the testsuite is running in verbose mode. However, the Term::dump_screen is most often called when a test fails, in this case I think it is useful to have the screen dumped even when we're not in verbose mode. This commit changes the calls to 'verbose' to be 'verbose -log' so we always get the screen dump. gdb/testsuite/ChangeLog: * lib/tuiterm.exp (Term::dump_screen): Always dump the screen when called. Change-Id: I5f0a7f5ac2ece04d6fe6e9c5a28ea2a0dda38955 --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/lib/tuiterm.exp | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp index 6f3d41f1ccb..36e034a3639 100644 --- a/gdb/testsuite/lib/tuiterm.exp +++ b/gdb/testsuite/lib/tuiterm.exp @@ -595,10 +595,10 @@ namespace eval Term { proc dump_screen {} { variable _rows variable _cols - verbose "Screen Dump ($_cols x $_rows):" + verbose -log "Screen Dump ($_cols x $_rows):" for {set y 0} {$y < $_rows} {incr y} { set fmt [format %5d $y] - verbose "$fmt [get_line $y]" + verbose -log "$fmt [get_line $y]" } }