From patchwork Sat Jan 4 20:20:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Norbert Lange X-Patchwork-Id: 37198 Received: (qmail 63062 invoked by alias); 4 Jan 2020 20:20:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 63053 invoked by uid 89); 4 Jan 2020 20:20:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Jan 2020 20:20:44 +0000 Received: by mail-wr1-f66.google.com with SMTP id b6so45551502wrq.0 for ; Sat, 04 Jan 2020 12:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xTdZZqlAQUWTQsqNUocJ6xIX2PgLhRx4NdnkfYS10pI=; b=XAuSIEU4sljIVrzp/BErfT4eRq3O3BTvp5Jbkboa3kE4sN26vErn9GwE0PPiegPUTh PmQ690sUgD9ro2qxwgMS3pg5MpnpmGX0tyWNzc6rsob4zOWxo+/hnKN0LzfOMXdsTCbz gYrzCWc3+0ogthtA05V0C7gEEiF1xKZTzxblYyDuJ0M8IZGMwSXNZptt4G4BdZDHKyKQ K8I61NebDyLmqA1AFaMxgUZANed4mW1szKNJKP+7VBcmJtpsAtvphiZmolgocLw1A058 Fi+pEeyBZq7fKbR/6REahCswhwwbm7LFKVU6cD4e62H/87RIiOh+pvZJwz+MZL/iSZca qK2A== Return-Path: Received: from localhost.localdomain (84-114-45-16.cable.dynamic.surfer.at. [84.114.45.16]) by smtp.gmail.com with ESMTPSA id x26sm16652386wmc.30.2020.01.04.12.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2020 12:20:41 -0800 (PST) From: Norbert Lange To: gdb-patches@sourceware.org Cc: Norbert Lange Subject: [PATCH] always export the symbols for the proc_service interface Date: Sat, 4 Jan 2020 21:20:04 +0100 Message-Id: <20200104202004.83439-2-nolange79@gmail.com> In-Reply-To: <20200104202004.83439-1-nolange79@gmail.com> References: <20200104202004.83439-1-nolange79@gmail.com> MIME-Version: 1.0 Compiling GDB with '-fvisibility=hidden' will remove the symbols that should be exported. This patch explicitly marks them as visible. gdb/ChangeLog PR build/24805 * gdbsupport/gdb_proc_service.h: push/pop visibility attribute for exported functions. --- gdb/gdbsupport/gdb_proc_service.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gdb/gdbsupport/gdb_proc_service.h b/gdb/gdbsupport/gdb_proc_service.h index 8565da3286..72abb5c1c0 100644 --- a/gdb/gdbsupport/gdb_proc_service.h +++ b/gdb/gdbsupport/gdb_proc_service.h @@ -23,6 +23,11 @@ #ifdef HAVE_PROC_SERVICE_H +/* ensure the symbols are public, even if the default is hidden */ +#if __GNUC__ >= 4 +#pragma GCC visibility push(default) +#endif + /* glibc's proc_service.h doesn't wrap itself with extern "C". Need to do it ourselves. */ EXTERN_C_PUSH @@ -31,6 +36,10 @@ EXTERN_C_PUSH EXTERN_C_POP +#if __GNUC__ >= 4 +#pragma GCC visibility pop +#endif + #else /* HAVE_PROC_SERVICE_H */ /* The following fallback definitions have been imported and adjusted @@ -69,6 +78,10 @@ EXTERN_C_POP # endif #endif +#if __GNUC__ >= 4 +#pragma GCC visibility push(default) +#endif + EXTERN_C_PUSH /* Functions in this interface return one of these status codes. */ @@ -168,6 +181,10 @@ extern void ps_plog (const char *fmt, ...); EXTERN_C_POP +#if __GNUC__ >= 4 +#pragma GCC visibility pop +#endif + #endif /* HAVE_PROC_SERVICE_H */ #endif /* COMMON_GDB_PROC_SERVICE_H */