From patchwork Mon Dec 30 16:12:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 37124 Received: (qmail 107742 invoked by alias); 30 Dec 2019 16:13:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 107639 invoked by uid 89); 30 Dec 2019 16:13:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-HELO:sk:gateway, H*RU:sk:gateway, determined, controlled X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Dec 2019 16:13:01 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 6C5DFC88525 for ; Mon, 30 Dec 2019 10:13:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lxfAiascdqNtvlxfAiFovN; Mon, 30 Dec 2019 10:13:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UiCA/CHIH+rrvDuVCNidkGAn2i8FlTJ03brIhD4QCD8=; b=lpyje1fzdf/+LRde62XtTpmdnM ekqNqfC5CUoxJggwtjWF0MFrM4qZMv84Vr+gmiFgaQT5vS0vcCjnN2dDikX3K0yHHbfZUUaFfaCud PpscswWu4rh6WJ8oa891w/2Vi; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:42510 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ilxfA-000I08-1X; Mon, 30 Dec 2019 09:13:00 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI 2/2] Make some TUI globals "static" Date: Mon, 30 Dec 2019 09:12:58 -0700 Message-Id: <20191230161258.20044-3-tom@tromey.com> In-Reply-To: <20191230161258.20044-1-tom@tromey.com> References: <20191230161258.20044-1-tom@tromey.com> This changes a few TUI globals to be "static". Tested by rebuilding. gdb/ChangeLog 2019-12-30 Tom Tromey * tui/tui-win.c (tui_border_mode_translate) (tui_border_kind_translate_vline, tui_border_kind_translate_hline) (tui_border_kind_translate_ulcorner) (tui_border_kind_translate_urcorner) (tui_border_kind_translate_llcorner) (tui_border_kind_translate_lrcorner, tui_active_border_mode) (tui_border_mode, tui_border_kind): Now static. Change-Id: Ibb49a0df195dfe780a5ba1f90e9125ab5f6b7ce1 --- gdb/ChangeLog | 10 ++++++++++ gdb/tui/tui-win.c | 20 ++++++++++---------- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index 959b0cdd76f..48df5354bf9 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -119,7 +119,7 @@ struct tui_translate /* Translation table for border-mode variables. The list of values must be terminated by a NULL. After the NULL value, an entry defines the default. */ -struct tui_translate tui_border_mode_translate[] = { +static struct tui_translate tui_border_mode_translate[] = { { "normal", A_NORMAL }, { "standout", A_STANDOUT }, { "reverse", A_REVERSE }, @@ -135,7 +135,7 @@ struct tui_translate tui_border_mode_translate[] = { character (see wborder, border curses operations). -1 is used to indicate the ACS because ACS characters are determined at run time by curses (depends on terminal). */ -struct tui_translate tui_border_kind_translate_vline[] = { +static struct tui_translate tui_border_kind_translate_vline[] = { { "space", ' ' }, { "ascii", '|' }, { "acs", -1 }, @@ -143,7 +143,7 @@ struct tui_translate tui_border_kind_translate_vline[] = { { "ascii", '|' } }; -struct tui_translate tui_border_kind_translate_hline[] = { +static struct tui_translate tui_border_kind_translate_hline[] = { { "space", ' ' }, { "ascii", '-' }, { "acs", -1 }, @@ -151,7 +151,7 @@ struct tui_translate tui_border_kind_translate_hline[] = { { "ascii", '-' } }; -struct tui_translate tui_border_kind_translate_ulcorner[] = { +static struct tui_translate tui_border_kind_translate_ulcorner[] = { { "space", ' ' }, { "ascii", '+' }, { "acs", -1 }, @@ -159,7 +159,7 @@ struct tui_translate tui_border_kind_translate_ulcorner[] = { { "ascii", '+' } }; -struct tui_translate tui_border_kind_translate_urcorner[] = { +static struct tui_translate tui_border_kind_translate_urcorner[] = { { "space", ' ' }, { "ascii", '+' }, { "acs", -1 }, @@ -167,7 +167,7 @@ struct tui_translate tui_border_kind_translate_urcorner[] = { { "ascii", '+' } }; -struct tui_translate tui_border_kind_translate_llcorner[] = { +static struct tui_translate tui_border_kind_translate_llcorner[] = { { "space", ' ' }, { "ascii", '+' }, { "acs", -1 }, @@ -175,7 +175,7 @@ struct tui_translate tui_border_kind_translate_llcorner[] = { { "ascii", '+' } }; -struct tui_translate tui_border_kind_translate_lrcorner[] = { +static struct tui_translate tui_border_kind_translate_lrcorner[] = { { "space", ' ' }, { "ascii", '+' }, { "acs", -1 }, @@ -185,7 +185,7 @@ struct tui_translate tui_border_kind_translate_lrcorner[] = { /* Tui configuration variables controlled with set/show command. */ -const char *tui_active_border_mode = "bold-standout"; +static const char *tui_active_border_mode = "bold-standout"; static void show_tui_active_border_mode (struct ui_file *file, int from_tty, @@ -197,7 +197,7 @@ The attribute mode to use for the active TUI window border is \"%s\".\n"), value); } -const char *tui_border_mode = "normal"; +static const char *tui_border_mode = "normal"; static void show_tui_border_mode (struct ui_file *file, int from_tty, @@ -209,7 +209,7 @@ The attribute mode to use for the TUI window borders is \"%s\".\n"), value); } -const char *tui_border_kind = "acs"; +static const char *tui_border_kind = "acs"; static void show_tui_border_kind (struct ui_file *file, int from_tty,