From patchwork Fri Dec 20 16:20:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 37000 Received: (qmail 65257 invoked by alias); 20 Dec 2019 16:20:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 63148 invoked by uid 89); 20 Dec 2019 16:20:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=1127 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2019 16:20:36 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 70D4920A7C; Fri, 20 Dec 2019 11:20:33 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id BB71920D22; Fri, 20 Dec 2019 11:20:15 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E4A8F281E3; Fri, 20 Dec 2019 11:20:13 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 20 Dec 2019 11:20:13 -0500 From: "Sourceware to Gerrit sync (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: merged Subject: [pushed] Use bool in tui_before_prompt X-Gerrit-Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a X-Gerrit-Change-Number: 648 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2dfd3df48dc7edb551718b3944eca6b35a7058a5 In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191220162013.E4A8F281E3@gnutoolchain-gerrit.osci.io> Sourceware to Gerrit sync has submitted this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/648 ...................................................................... Use bool in tui_before_prompt This changes tui_before_prompt to take a bool rather than an int. gdb/ChangeLog 2019-12-20 Tom Tromey * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool. (tui_before_prompt, tui_normal_stop): Update. Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a --- M gdb/ChangeLog M gdb/tui/tui-hooks.c 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2bdfba7..f910703 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-12-20 Tom Tromey + * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool. + (tui_before_prompt, tui_normal_stop): Update. + +2019-12-20 Tom Tromey + * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is): Don't call set_current_source_symtab_and_line. diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index bb96f4d..35a9259 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -112,7 +112,7 @@ if frame information hasn't changed. */ static void -tui_refresh_frame_and_register_information (int registers_too_p) +tui_refresh_frame_and_register_information (bool registers_too_p) { struct frame_info *fi; CORE_ADDR pc; @@ -188,7 +188,7 @@ refresh registers here unless the frame actually changed by one of these commands. Registers will otherwise be refreshed after a normal stop or by our tui_register_changed_hook. */ - tui_refresh_frame_and_register_information (/*registers_too_p=*/0); + tui_refresh_frame_and_register_information (/*registers_too_p=*/false); } /* Observer for the normal_stop notification. */ @@ -198,7 +198,7 @@ { /* This refresh is intended to catch changes to the selected frame and to registers following a normal stop. */ - tui_refresh_frame_and_register_information (/*registers_too_p=*/1); + tui_refresh_frame_and_register_information (/*registers_too_p=*/true); } /* Token associated with observers registered while TUI hooks are