From patchwork Sun Dec 15 11:30:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 36886 Received: (qmail 94847 invoked by alias); 15 Dec 2019 11:30:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94782 invoked by uid 89); 15 Dec 2019 11:30:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:AM0PR08, H*i:sk:AM0PR08, berndedlingerhotmailde, bernd.edlinger@hotmail.de X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-oln040092065027.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.92.65.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2019 11:30:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D29W0n5i8epWzNBqc4lSHXNylptuEdHZtFD7AIgrxuVUIObXACfcCgjiI+X7VNenn6tA63Aulj3YGYhTZR4z23scvbDEcLWGTWR5T7FYiSJmIRYq+vDZ61Py8KW26zp/4NOS7Q4zkC05eBCTf95ouF15a+7NTserkRAj7PyWd629llZekqOfpQzJQsppHMCkFHyBXLV4hnFva7nrb7B/HbZROXDQ6CsU+0vMjAIwMDlzJBwuj3wDn869sYdH7yTGWX+z2+0Y/KVaz5o4BuuaKF8O/RXE4IPaoIo+UoOKBBPFHgGBwwOMaOsZ8CbZCKuVOIBLNSjWugnp60zfeaYGmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D3ZSi3T/UNPR/0e9dq9E3v1VjsC0KuNiHeWWtZuM4Rc=; b=Gqtp05q5Ka8u0E5LEYCwq/x6HqZETaOBp87/R7iiSRTOlJEfdcUAfFXPBD49oiYNOzYTlAwFyiz8XbbU6iiZrxFQBeyw3n0HqYM9TGPOyLq4dOzJJxOOPziY8zCyBR1WoElkzc3p7UkgvQ1wi/vNTKNGp2nqM/+7LypWr6xpYAh+J6tci4X2xaW0jUNxdfQObfN3CSA60YqMU0dGsiJ01YOKlJg4rW+1xgMDWRweTTIFkqNTIwZeBr1lP8qEdjmhwTygiWs3s9/2XHqJNcaYYOrg9eT4TzLbzFx+SRseB4XklhDyhaSx24XYlye22jn92hE/8WPO4o+F7EzWrL9TtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB5EUR01FT063.eop-EUR01.prod.protection.outlook.com (10.152.4.59) by DB5EUR01HT011.eop-EUR01.prod.protection.outlook.com (10.152.4.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Sun, 15 Dec 2019 11:30:02 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com (10.152.4.53) by DB5EUR01FT063.mail.protection.outlook.com (10.152.5.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14 via Frontend Transport; Sun, 15 Dec 2019 11:30:02 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769]) by AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769%7]) with mapi id 15.20.2538.019; Sun, 15 Dec 2019 11:30:02 +0000 From: Bernd Edlinger To: "gdb-patches@sourceware.org" , Simon Marchi Subject: [PATCH] Fix skip.exp test failure observed with gcc-9.2.0 Date: Sun, 15 Dec 2019 11:30:01 +0000 Message-ID: References: In-Reply-To: x-forwarded-message-id: x-microsoft-original-message-id: <289afc96-4479-436e-5356-6b5fa906c72b@hotmail.de> x-ms-exchange-transport-forked: True MIME-Version: 1.0 Hi, this is the split out patch on skip.exp which fixes a pre-existing compatibilty issue with that test case and gcc-9.2.0 (and gcc-10 from trunk of a few weeks ago at least, likely other versions too). Is it OK for trunk? Thanks Bernd. gdb/testsuite: 2019-12-15 Bernd Edlinger * gdb.base/skip.exp: Fix test failure observed with gcc-9.2.0. From b15964b769373f25f276430914c5efa84d411032 Mon Sep 17 00:00:00 2001 From: Bernd Edlinger Date: Sun, 15 Dec 2019 11:05:47 +0100 Subject: [PATCH] Fix skip.exp test failure observed with gcc-9.2.0 Need to step a second time because with this gcc version the first step jumps back to main before entering foo. --- gdb/testsuite/gdb.base/skip.exp | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.base/skip.exp b/gdb/testsuite/gdb.base/skip.exp index d763194..15dec42 100644 --- a/gdb/testsuite/gdb.base/skip.exp +++ b/gdb/testsuite/gdb.base/skip.exp @@ -21,8 +21,8 @@ load_lib completion-support.exp standard_testfile if { [prepare_for_testing "failed to prepare" "skip" \ - {skip.c skip1.c } \ - {debug nowarnings}] } { + {skip.c skip1.c } \ + {debug nowarnings}] } { return -1 } @@ -142,7 +142,9 @@ with_test_prefix "step after disabling 3" { gdb_test "step" "bar \\(\\) at.*" "step 1" gdb_test "step" ".*" "step 2"; # Return from foo() - gdb_test "step" "foo \\(\\) at.*" "step 3" + # With gcc 9.2.0 we jump once back to main before entering foo here. + # If that happens try to step a second time. + gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at .*" "step" gdb_test "step" ".*" "step 4"; # Return from bar() gdb_test "step" "main \\(\\) at.*" "step 5" } @@ -261,7 +263,9 @@ with_test_prefix "step using -fu for baz" { gdb_test_no_output "skip enable 7" gdb_test "step" "bar \\(\\) at.*" "step 1" gdb_test "step" ".*" "step 2"; # Return from bar() - gdb_test "step" "foo \\(\\) at.*" "step 3" + # With gcc 9.2.0 we jump once back to main before entering foo here. + # If that happens try to step a second time. + gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at.*" "step" gdb_test "step" ".*" "step 4"; # Return from foo() gdb_test "step" "main \\(\\) at.*" "step 5" } @@ -276,7 +280,9 @@ with_test_prefix "step using -rfu for baz" { gdb_test_no_output "skip enable 8" gdb_test "step" "bar \\(\\) at.*" "step 1" gdb_test "step" ".*" "step 2"; # Return from bar() - gdb_test "step" "foo \\(\\) at.*" "step 3" + # With gcc 9.2.0 we jump once back to main before entering foo here. + # If that happens try to step a second time. + gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at.*" "step" gdb_test "step" ".*" "step 4"; # Return from foo() gdb_test "step" "main \\(\\) at.*" "step 5" } -- 1.9.1