From patchwork Sat Dec 14 23:29:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Biesinger X-Patchwork-Id: 36877 Received: (qmail 63018 invoked by alias); 14 Dec 2019 23:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 62810 invoked by uid 89); 14 Dec 2019 23:30:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=sk:set_lin, HContent-Transfer-Encoding:8bit X-HELO: mail-qv1-f68.google.com Received: from mail-qv1-f68.google.com (HELO mail-qv1-f68.google.com) (209.85.219.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Dec 2019 23:30:14 +0000 Received: by mail-qv1-f68.google.com with SMTP id n8so1224393qvg.11 for ; Sat, 14 Dec 2019 15:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mNlEIknu/LJC1MPlmssXXWUAMw26fqP960gHROzTAPM=; b=i8SWYP8/OTB2iX4NAvMear1wF+BRCqGCUcirEQkZ0iPXnbm3n/H7sEj5xD3w7sYOSx tjoRDgZ3yCV1CLw2Mp8Wu8gzMLf4LN3kK40Vg7KInYDiFZubASksHyVcfT91qdESwzj+ jhnHJaMoAOvbYfnsgaPVxSIm8PkfXU8Y0utio= Return-Path: Received: from cbiesinger.united_club.ewr.united.com ([65.119.211.164]) by smtp.googlemail.com with ESMTPSA id x6sm4386956qkh.20.2019.12.14.15.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2019 15:30:03 -0800 (PST) From: cbiesinger@chromium.org To: gdb-patches@sourceware.org Cc: Christian Biesinger Subject: [PATCH 1/3] Use symbol_set_language to set a symbol's language Date: Sat, 14 Dec 2019 18:29:57 -0500 Message-Id: <20191214232959.3973-2-cbiesinger@chromium.org> In-Reply-To: <20191214232959.3973-1-cbiesinger@chromium.org> References: <20191214232959.3973-1-cbiesinger@chromium.org> MIME-Version: 1.0 From: Christian Biesinger Instead of using SYMBOL_LANGUAGE (sym) = foo. Having only a single way to set a symbol's language is clearer and this is also a requirement for making set_language a member function. gdb/ChangeLog: 2019-12-14 Christian Biesinger * ada-exp.y (write_ambiguous_var): Call symbol_set_language to set the language of sym. * language.c (language_alloc_type_symbol): Likewise. Change-Id: I85338ea2e4121155f2da222fe0aa6b7d3ffe26f7 --- gdb/ada-exp.y | 2 +- gdb/language.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y index 00020cd067..6b1bdfa139 100644 --- a/gdb/ada-exp.y +++ b/gdb/ada-exp.y @@ -1106,7 +1106,7 @@ write_ambiguous_var (struct parser_state *par_state, SYMBOL_DOMAIN (sym) = UNDEF_DOMAIN; sym->set_linkage_name (obstack_strndup (&temp_parse_space, name, len)); - SYMBOL_LANGUAGE (sym) = language_ada; + symbol_set_language (sym, language_ada, nullptr); write_exp_elt_opcode (par_state, OP_VAR_VALUE); write_exp_elt_block (par_state, block); diff --git a/gdb/language.c b/gdb/language.c index 6ab0ca323d..da6f7a860a 100644 --- a/gdb/language.c +++ b/gdb/language.c @@ -1051,7 +1051,7 @@ language_alloc_type_symbol (enum language lang, struct type *type) symbol = new (gdbarch_obstack (gdbarch)) struct symbol (); symbol->name = TYPE_NAME (type); - symbol->language = lang; + symbol->set_language (language, lang, nullptr); symbol->owner.arch = gdbarch; SYMBOL_OBJFILE_OWNED (symbol) = 0; SYMBOL_TYPE (symbol) = type;