From patchwork Fri Dec 13 22:24:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gabriel F. T. Gomes" X-Patchwork-Id: 36861 Received: (qmail 92750 invoked by alias); 13 Dec 2019 22:24:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 92657 invoked by uid 89); 13 Dec 2019 22:24:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=1878, 1721 X-HELO: smtpout1.mo803.mail-out.ovh.net From: "Gabriel F. T. Gomes" To: Subject: [PATCH v4 2/9] Refactor *cvt functions implementation (2/2) Date: Fri, 13 Dec 2019 19:24:20 -0300 Message-ID: <20191213222427.14278-3-gabriel@inconstante.net.br> In-Reply-To: <20191213222427.14278-1-gabriel@inconstante.net.br> References: <20191213222427.14278-1-gabriel@inconstante.net.br> MIME-Version: 1.0 X-Ovh-Tracer-Id: 1129277609826045635 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudelledgudeitdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkffojghfggfgtghisehtkeertdertddtnecuhfhrohhmpedfifgrsghrihgvlhcuhfdrucfvrdcuifhomhgvshdfuceoghgrsghrihgvlhesihhntghonhhsthgrnhhtvgdrnhgvthdrsghrqeenucffohhmrghinhepghhnuhdrohhrghenucfkpheptddrtddrtddrtddpudejledrudekvddrudehuddrkeeknecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopefgigegrdgvmhhprdhlohgtrghlpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrggsrhhivghlsehinhgtohhnshhtrghnthgvrdgvthhirdgsrhdprhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd From: "Gabriel F. T. Gomes" Changes since v3: - Converted into a standalone patch not to be squashed with the preceding patch (1/2). - Updated commit message. - Tested that installed stripped binaries for powerpc64le and x86_64 remain identical before and after this patch. Changes since v2: - Moved the removal of unused macros to a previous patch Changes since v1: - Adapted after patch v1 19/31 (remove hidden_* uses) was dropped. - Fixed unintended removal of cvt* symbols on alpha and s390x (now tested with build-many-glibcs.py). -- 8< -- This patch refactors the *cvt functions implementation in a way that makes it easier to re-use them for implementing the IEEE long double on powerpc64le. By removing the macros that generate the function names (APPEND combined with FUNC_PREFIX), the new code makes it easier to define new function names, such as __qecvtieee128. Tested that installed stripped binaries for powerpc64le and x86_64 remain identical before and after this patch. Also tested for powerpc64le, x86_64, as well as with the following build-many-glibcs targets: alpha-linux-gnu, mips-linux-gnu, powerpc-linux-gnu-soft, s390x-linux-gnu, and sparc64-linux-gnu. Reviewed-by: Paul E. Murphy --- misc/efgcvt-template.c | 19 ++++++------------- misc/efgcvt.c | 25 ++++++++++++++++--------- misc/efgcvt_r-template.c | 14 ++++++-------- misc/efgcvt_r.c | 19 ++++++++++--------- misc/qefgcvt.c | 25 +++++++++++++++---------- misc/qefgcvt_r.c | 19 +++++++++---------- 6 files changed, 62 insertions(+), 59 deletions(-) diff --git a/misc/efgcvt-template.c b/misc/efgcvt-template.c index aeb4e1ea01..7fabdf264d 100644 --- a/misc/efgcvt-template.c +++ b/misc/efgcvt-template.c @@ -25,8 +25,6 @@ #define APPEND(a, b) APPEND2 (a, b) #define APPEND2(a, b) a##b -#define __APPEND(a, b) __APPEND2 (a, b) -#define __APPEND2(a, b) __##a##b #define FCVT_BUFFER APPEND (FUNC_PREFIX, fcvt_buffer) @@ -39,13 +37,11 @@ static char ECVT_BUFFER[MAXDIG]; libc_freeres_ptr (static char *FCVT_BUFPTR); char * -__APPEND (FUNC_PREFIX, fcvt) (FLOAT_TYPE value, int ndigit, int *decpt, - int *sign) +__FCVT (FLOAT_TYPE value, int ndigit, int *decpt, int *sign) { if (FCVT_BUFPTR == NULL) { - if (__APPEND (FUNC_PREFIX, fcvt_r) (value, ndigit, decpt, sign, - FCVT_BUFFER, MAXDIG) != -1) + if (__FCVT_R (value, ndigit, decpt, sign, FCVT_BUFFER, MAXDIG) != -1) return FCVT_BUFFER; FCVT_BUFPTR = (char *) malloc (FCVT_MAXDIG); @@ -53,25 +49,22 @@ __APPEND (FUNC_PREFIX, fcvt) (FLOAT_TYPE value, int ndigit, int *decpt, return FCVT_BUFFER; } - (void) __APPEND (FUNC_PREFIX, fcvt_r) (value, ndigit, decpt, sign, - FCVT_BUFPTR, FCVT_MAXDIG); + (void) __FCVT_R (value, ndigit, decpt, sign, FCVT_BUFPTR, FCVT_MAXDIG); return FCVT_BUFPTR; } char * -__APPEND (FUNC_PREFIX, ecvt) (FLOAT_TYPE value, int ndigit, int *decpt, - int *sign) +__ECVT (FLOAT_TYPE value, int ndigit, int *decpt, int *sign) { - (void) __APPEND (FUNC_PREFIX, ecvt_r) (value, ndigit, decpt, sign, - ECVT_BUFFER, MAXDIG); + (void) __ECVT_R (value, ndigit, decpt, sign, ECVT_BUFFER, MAXDIG); return ECVT_BUFFER; } char * -__APPEND (FUNC_PREFIX, gcvt) (FLOAT_TYPE value, int ndigit, char *buf) +__GCVT (FLOAT_TYPE value, int ndigit, char *buf) { sprintf (buf, "%.*" FLOAT_FMT_FLAG "g", MIN (ndigit, NDIGIT_MAX), value); return buf; diff --git a/misc/efgcvt.c b/misc/efgcvt.c index 9021b03bca..ddf306941a 100644 --- a/misc/efgcvt.c +++ b/misc/efgcvt.c @@ -16,20 +16,27 @@ License along with the GNU C Library; if not, see . */ +#define ECVT ecvt +#define FCVT fcvt +#define GCVT gcvt +#define __ECVT __ecvt +#define __FCVT __fcvt +#define __GCVT __gcvt +#define __ECVT_R __ecvt_r +#define __FCVT_R __fcvt_r #include #include #if LONG_DOUBLE_COMPAT (libc, GLIBC_2_0) -# define cvt_symbol(symbol) \ - cvt_symbol_1 (libc, __APPEND (FUNC_PREFIX, symbol), \ - APPEND (q, symbol), GLIBC_2_0); \ - strong_alias (__APPEND (FUNC_PREFIX, symbol), APPEND (FUNC_PREFIX, symbol)) +# define cvt_symbol(local, symbol) \ + cvt_symbol_1 (libc, local, APPEND (q, symbol), GLIBC_2_0); \ + strong_alias (local, symbol) # define cvt_symbol_1(lib, local, symbol, version) \ compat_symbol (lib, local, symbol, version) #else -# define cvt_symbol(symbol) \ - strong_alias (__APPEND (FUNC_PREFIX, symbol), APPEND (FUNC_PREFIX, symbol)) +# define cvt_symbol(local, symbol) \ + strong_alias (local, symbol) #endif -cvt_symbol(fcvt); -cvt_symbol(ecvt); -cvt_symbol(gcvt); +cvt_symbol (__fcvt, fcvt); +cvt_symbol (__ecvt, ecvt); +cvt_symbol (__gcvt, gcvt); diff --git a/misc/efgcvt_r-template.c b/misc/efgcvt_r-template.c index 1cd335afe7..977750118c 100644 --- a/misc/efgcvt_r-template.c +++ b/misc/efgcvt_r-template.c @@ -28,12 +28,10 @@ #define APPEND(a, b) APPEND2 (a, b) #define APPEND2(a, b) a##b -#define __APPEND(a, b) __APPEND2 (a, b) -#define __APPEND2(a, b) __##a##b int -__APPEND (FUNC_PREFIX, fcvt_r) (FLOAT_TYPE value, int ndigit, int *decpt, - int *sign, char *buf, size_t len) +__FCVT_R (FLOAT_TYPE value, int ndigit, int *decpt, int *sign, + char *buf, size_t len) { ssize_t n; ssize_t i; @@ -127,8 +125,8 @@ __APPEND (FUNC_PREFIX, fcvt_r) (FLOAT_TYPE value, int ndigit, int *decpt, } int -__APPEND (FUNC_PREFIX, ecvt_r) (FLOAT_TYPE value, int ndigit, int *decpt, - int *sign, char *buf, size_t len) +__ECVT_R (FLOAT_TYPE value, int ndigit, int *decpt, int *sign, + char *buf, size_t len) { int exponent = 0; @@ -187,8 +185,8 @@ __APPEND (FUNC_PREFIX, ecvt_r) (FLOAT_TYPE value, int ndigit, int *decpt, *sign = isfinite (value) ? signbit (value) != 0 : 0; } else - if (__APPEND (FUNC_PREFIX, fcvt_r) (value, MIN (ndigit, NDIGIT_MAX) - 1, - decpt, sign, buf, len)) + if (__FCVT_R (value, MIN (ndigit, NDIGIT_MAX) - 1, + decpt, sign, buf, len)) return -1; *decpt += exponent; diff --git a/misc/efgcvt_r.c b/misc/efgcvt_r.c index ad78f153ba..5dabcad3c7 100644 --- a/misc/efgcvt_r.c +++ b/misc/efgcvt_r.c @@ -16,23 +16,24 @@ License along with the GNU C Library; if not, see . */ +#define ECVT_R ecvt_r +#define FCVT_R fcvt_r +#define __ECVT_R __ecvt_r +#define __FCVT_R __fcvt_r #include #include #if LONG_DOUBLE_COMPAT (libc, GLIBC_2_0) -# define cvt_symbol(symbol) \ - cvt_symbol_1 (libc, __APPEND (FUNC_PREFIX, symbol), \ - APPEND (q, symbol), GLIBC_2_0); \ - weak_alias (__APPEND (FUNC_PREFIX, symbol), APPEND (FUNC_PREFIX, symbol)) +# define cvt_symbol(local, symbol) \ + cvt_symbol_1 (libc, local, APPEND (q, symbol), GLIBC_2_0); \ + weak_alias (local, symbol) # define cvt_symbol_1(lib, local, symbol, version) \ libc_hidden_def (local) \ compat_symbol (lib, local, symbol, version) #else -# define cvt_symbol(symbol) \ - cvt_symbol_1 (__APPEND (FUNC_PREFIX, symbol), APPEND (FUNC_PREFIX, symbol)) -# define cvt_symbol_1(local, symbol) \ +# define cvt_symbol(local, symbol) \ libc_hidden_def (local) \ weak_alias (local, symbol) #endif -cvt_symbol(fcvt_r); -cvt_symbol(ecvt_r); +cvt_symbol (__fcvt_r, fcvt_r); +cvt_symbol (__ecvt_r, ecvt_r); diff --git a/misc/qefgcvt.c b/misc/qefgcvt.c index 8f1582a50e..903bf93aa4 100644 --- a/misc/qefgcvt.c +++ b/misc/qefgcvt.c @@ -16,19 +16,24 @@ License along with the GNU C Library; if not, see . */ +#define ECVT qecvt +#define FCVT qfcvt +#define GCVT qgcvt +#define __ECVT __qecvt +#define __FCVT __qfcvt +#define __GCVT __qgcvt +#define __ECVT_R __qecvt_r +#define __FCVT_R __qfcvt_r #include #include #if LONG_DOUBLE_COMPAT (libc, GLIBC_2_0) -# define cvt_symbol(symbol) \ - cvt_symbol_1 (libc, __APPEND (FUNC_PREFIX, symbol), \ - APPEND (FUNC_PREFIX, symbol), GLIBC_2_4) -# define cvt_symbol_1(lib, local, symbol, version) \ - versioned_symbol (lib, local, symbol, version) +# define cvt_symbol(local, symbol) \ + versioned_symbol (libc, local, symbol, GLIBC_2_4) #else -# define cvt_symbol(symbol) \ - strong_alias (__APPEND (FUNC_PREFIX, symbol), APPEND (FUNC_PREFIX, symbol)) +# define cvt_symbol(local, symbol) \ + strong_alias (local, symbol) #endif -cvt_symbol(fcvt); -cvt_symbol(ecvt); -cvt_symbol(gcvt); +cvt_symbol (__qfcvt, qfcvt); +cvt_symbol (__qecvt, qecvt); +cvt_symbol (__qgcvt, qgcvt); diff --git a/misc/qefgcvt_r.c b/misc/qefgcvt_r.c index 4240f1da2b..b790bf7837 100644 --- a/misc/qefgcvt_r.c +++ b/misc/qefgcvt_r.c @@ -17,22 +17,21 @@ License along with the GNU C Library; if not, see . */ +#define ECVT_R qecvt_r +#define FCVT_R qfcvt_r +#define __ECVT_R __qecvt_r +#define __FCVT_R __qfcvt_r #include #include #if LONG_DOUBLE_COMPAT (libc, GLIBC_2_0) -# define cvt_symbol(symbol) \ - cvt_symbol_1 (libc, __APPEND (FUNC_PREFIX, symbol), \ - APPEND (FUNC_PREFIX, symbol), GLIBC_2_4) -# define cvt_symbol_1(lib, local, symbol, version) \ +# define cvt_symbol(local, symbol) \ libc_hidden_def (local) \ - versioned_symbol (lib, local, symbol, version) + versioned_symbol (libc, local, symbol, GLIBC_2_4) #else -# define cvt_symbol(symbol) \ - cvt_symbol_1 (__APPEND (FUNC_PREFIX, symbol), APPEND (FUNC_PREFIX, symbol)) -# define cvt_symbol_1(local, symbol) \ +# define cvt_symbol(local, symbol) \ libc_hidden_def (local) \ weak_alias (local, symbol) #endif -cvt_symbol(fcvt_r); -cvt_symbol(ecvt_r); +cvt_symbol (__qfcvt_r, qfcvt_r); +cvt_symbol (__qecvt_r, qecvt_r);