From patchwork Thu Dec 12 02:35:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36764 Received: (qmail 2192 invoked by alias); 12 Dec 2019 02:35:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 1496 invoked by uid 89); 12 Dec 2019 02:35:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:3595 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 02:35:19 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D1C5520300; Wed, 11 Dec 2019 21:35:16 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 72F4820C17 for ; Wed, 11 Dec 2019 21:35:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5568D25BB4 for ; Wed, 11 Dec 2019 21:35:06 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 11 Dec 2019 21:35:02 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Change tui_show_frame_info to return bool X-Gerrit-Change-Id: Id1374f04f919c30a9f50c1beeb70cbc10b9a8f3b X-Gerrit-Change-Number: 651 X-Gerrit-ChangeURL: X-Gerrit-Commit: ea015fe6c98fd6f7cc09b93e6f08f23325e88e17 In-Reply-To: References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191212023506.5568D25BB4@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/651 ...................................................................... Change tui_show_frame_info to return bool This changes tui_show_frame_info to return bool. 2019-12-11 Tom Tromey * tui/tui-stack.h (tui_show_frame_info): Return bool. * tui/tui-stack.c (tui_show_frame_info): Return bool. * tui/tui-hooks.c (tui_refresh_frame_and_register_information): Update. Change-Id: Id1374f04f919c30a9f50c1beeb70cbc10b9a8f3b --- M gdb/ChangeLog M gdb/tui/tui-hooks.c M gdb/tui/tui-stack.c M gdb/tui/tui-stack.h 4 files changed, 16 insertions(+), 11 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c9e416a..8292ea7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2019-12-11 Tom Tromey + * tui/tui-stack.h (tui_show_frame_info): Return bool. + * tui/tui-stack.c (tui_show_frame_info): Return bool. + * tui/tui-hooks.c (tui_refresh_frame_and_register_information): + Update. + +2019-12-11 Tom Tromey + PR tui/18932: * tui/tui-hooks.c (tui_refresh_frame_and_register_information): Rename parameters. Handle the not-from-stack-frame case. diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index deb10b0..8576bb8 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -133,7 +133,7 @@ /* Display the frame position (even if there is no symbols or the PC is not known). */ - int frame_info_changed_p = tui_show_frame_info (fi); + bool frame_info_changed_p = tui_show_frame_info (fi); /* Refresh the register window if it's visible. */ if (tui_is_window_visible (DATA_WIN) diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c index d244343..3f606cb 100644 --- a/gdb/tui/tui-stack.c +++ b/gdb/tui/tui-stack.c @@ -301,10 +301,10 @@ /* Function to print the frame information for the TUI. The windows are refreshed only if frame information has changed since the last refresh. - Return 1 if frame information has changed (and windows subsequently - refreshed), 0 otherwise. */ + Return true if frame information has changed (and windows + subsequently refreshed), false otherwise. */ -int +bool tui_show_frame_info (struct frame_info *fi) { bool locator_changed_p; @@ -329,15 +329,13 @@ not changed. If frame information has not changed, then the windows' contents will not change. So don't bother refreshing the windows. */ if (!locator_changed_p) - return 0; + return false; for (struct tui_source_window_base *win_info : tui_source_windows ()) { win_info->maybe_update (fi, sal); win_info->update_exec_info (); } - - return 1; } else { @@ -346,13 +344,13 @@ locator_changed_p = locator->set_locator_info (NULL, sal, ""); if (!locator_changed_p) - return 0; + return false; for (struct tui_source_window_base *win_info : tui_source_windows ()) win_info->erase_source_content (); - - return 1; } + + return true; } void diff --git a/gdb/tui/tui-stack.h b/gdb/tui/tui-stack.h index 3bfe529..0a928f3 100644 --- a/gdb/tui/tui-stack.h +++ b/gdb/tui/tui-stack.h @@ -78,6 +78,6 @@ extern void tui_update_locator_fullname (struct symtab *symtab); extern void tui_show_locator_content (void); -extern int tui_show_frame_info (struct frame_info *); +extern bool tui_show_frame_info (struct frame_info *); #endif /* TUI_TUI_STACK_H */