From patchwork Wed Dec 11 15:16:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36715 Received: (qmail 90763 invoked by alias); 11 Dec 2019 15:17:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 90755 invoked by uid 89); 11 Dec 2019 15:17:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT autolearn=ham version=3.3.1 spammy=7.4.0 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 15:17:02 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C699520456; Wed, 11 Dec 2019 10:16:59 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id C3A66202E5 for ; Wed, 11 Dec 2019 10:16:58 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A169F20AF6 for ; Wed, 11 Dec 2019 10:16:58 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 11 Dec 2019 10:16:58 -0500 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Fix unused function error X-Gerrit-Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 X-Gerrit-Change-Number: 753 X-Gerrit-ChangeURL: X-Gerrit-Commit: eaaba2d48c28ad2547ead1aa83176b6160ed4b2e In-Reply-To: References: Reply-To: luis.machado@linaro.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191211151658.A169F20AF6@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/753 ...................................................................... Fix unused function error Attempting to build GDB in Ubuntu 18.04.3 on x86_64, i ran into warnings that caused the build to fail. For some reason the diagnostics macros don't work for my case, but ATTRIBUTE_UNUSED does. The compiler version is gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0. gdb/ChangeLog: 2019-12-11 Luis Machado * gdb/gdbsupport/safe-strerror.c: Remove diagnostics.h (select_strerror_r): Use ATTRIBUTED_UNUSED instead of the diagnostics macros. Change-Id: Iad6123d61d76d111e3ef8d24aa8c60112304c749 --- M gdb/gdbsupport/safe-strerror.c 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gdb/gdbsupport/safe-strerror.c b/gdb/gdbsupport/safe-strerror.c index 9973fa6..9126507 100644 --- a/gdb/gdbsupport/safe-strerror.c +++ b/gdb/gdbsupport/safe-strerror.c @@ -18,7 +18,6 @@ along with this program. If not, see . */ #include "common-defs.h" -#include "diagnostics.h" #include /* There are two different versions of strerror_r; one is GNU-specific, the @@ -29,25 +28,21 @@ /* We only ever use one of the two overloads, so suppress the warning for an unused function. */ -DIAGNOSTIC_PUSH -DIAGNOSTIC_IGNORE_UNUSED_FUNCTION /* Called if we have a XSI-compliant strerror_r. */ -static char * +ATTRIBUTE_UNUSED static char * select_strerror_r (int res, char *buf) { return res == 0 ? buf : nullptr; } /* Called if we have a GNU strerror_r. */ -static char * +ATTRIBUTE_UNUSED static char * select_strerror_r (char *res, char *) { return res; } -DIAGNOSTIC_POP - /* Implementation of safe_strerror as defined in common-utils.h. */ const char *