diff mbox

[review] Change ARI usage to GNU style

Message ID gerrit.1575560698000.Ibe5a867571382d2985d1b8b78dfef3ddd02291ff@gnutoolchain-gerrit.osci.io
State New, archived
Headers

Commit Message

Simon Marchi (Code Review) Dec. 5, 2019, 3:44 p.m. UTC 
  Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................

Change ARI usage to GNU style

This changes the ARI usage text to use the GNU style for
"metasyntactic variables".

gdb/ChangeLog
2019-12-05  Tom Tromey  <tromey@adacore.com>

	* contrib/ari/gdb_ari.sh (usage): Use GNU style.

Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Simon Marchi (Code Review) Dec. 5, 2019, 5:02 p.m. UTC | #1 
Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/contrib/ari/gdb_ari.sh
| +++ gdb/contrib/ari/gdb_ari.sh
| @@ -56,17 +55,18 @@ Usage:
| +    $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
|  Options:
|    --print-doc    Print a list of all potential problems, then exit.
|    --print-idx    Include the problems IDX (index or key) in every message.
|    --src=file     Write source lines to file.
|    -Werror        Treat all problems as errors.
|    -Wall          Report all problems.
|    -Wari          Report problems that should be fixed in new code.
| -  -W<category>   Report problems in the specifed category.  Valid categories
| +  -WCATEGORY     Report problems in the specifed category.  Valid categories

PS1, Line 63:

The disadvantage here is that W is also uppercase.  In this case it
looks unambiguous enough, though.  Not sure this is an improvement
because of that, but I guess it is fine.

|                   are: ${all}
|  EOF
|      exit 1
|  }
|  
|  
|  # Parse the various options
|  Woptions=
|  srclines=""
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e4259c4..3c7e592 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@ 
 2019-12-05  Tom Tromey  <tromey@adacore.com>
 
+	* contrib/ari/gdb_ari.sh (usage): Use GNU style.
+
+2019-12-05  Tom Tromey  <tromey@adacore.com>
+
 	* gdbsupport/agent.c (gdb_connect_sync_socket): Use
 	safe_strerror.
 	(gdb_connect_sync_socket): Use safe_strerror.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index d05f4af..5b74506 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -52,7 +52,7 @@ 
 Error: $1
 
 Usage:
-    $0 --print-doc --print-idx -Wall -Werror -W<category> <file> ...
+    $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
 Options:
   --print-doc    Print a list of all potential problems, then exit.
   --print-idx    Include the problems IDX (index or key) in every message.
@@ -60,7 +60,7 @@ 
   -Werror        Treat all problems as errors.
   -Wall          Report all problems.
   -Wari          Report problems that should be fixed in new code.
-  -W<category>   Report problems in the specifed category.  Valid categories
+  -WCATEGORY     Report problems in the specifed category.  Valid categories
                  are: ${all}
 EOF
     exit 1