From patchwork Thu Dec 5 15:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36538 Received: (qmail 65480 invoked by alias); 5 Dec 2019 15:45:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65037 invoked by uid 89); 5 Dec 2019 15:45:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=socket, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 15:45:09 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4990E203AC; Thu, 5 Dec 2019 10:45:04 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9E52D208B6 for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 8EB7A28175 for ; Thu, 5 Dec 2019 10:44:59 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 5 Dec 2019 10:44:59 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Use safe_strerror in agent.c X-Gerrit-Change-Id: Icdfcf9fef754253d6b17aeaa78329ea9bdc41bb1 X-Gerrit-Change-Number: 748 X-Gerrit-ChangeURL: X-Gerrit-Commit: 346952b564c56420899fb2cb8fd3c120d4bc9afe References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/748 ...................................................................... Use safe_strerror in agent.c ARI pointed out that agent.c is using strerror, where gdb generally prefers safe_strerror. This patch fixes the problem. gdb/ChangeLog 2019-12-05 Tom Tromey * gdbsupport/agent.c (gdb_connect_sync_socket): Use safe_strerror. (gdb_connect_sync_socket): Use safe_strerror. Change-Id: Icdfcf9fef754253d6b17aeaa78329ea9bdc41bb1 --- M gdb/ChangeLog M gdb/gdbsupport/agent.c 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index aff1f2f..e4259c4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2019-12-05 Tom Tromey + * gdbsupport/agent.c (gdb_connect_sync_socket): Use + safe_strerror. + (gdb_connect_sync_socket): Use safe_strerror. + +2019-12-05 Tom Tromey + * gdbsupport/common-utils.c (string_printf, string_vprintf) (string_vappendf): Add ARI comment. diff --git a/gdb/gdbsupport/agent.c b/gdb/gdbsupport/agent.c index 6d55f58..50e9500 100644 --- a/gdb/gdbsupport/agent.c +++ b/gdb/gdbsupport/agent.c @@ -149,7 +149,7 @@ res = fd = gdb_socket_cloexec (PF_UNIX, SOCK_STREAM, 0); if (res == -1) { - warning (_("error opening sync socket: %s"), strerror (errno)); + warning (_("error opening sync socket: %s"), safe_strerror (errno)); return -1; } @@ -168,7 +168,7 @@ { warning (_("error connecting sync socket (%s): %s. " "Make sure the directory exists and that it is writable."), - path, strerror (errno)); + path, safe_strerror (errno)); close (fd); return -1; }